fix(test): eliminate all console noise from jest CI logs at the source (#3822)

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: grimen

__tests__/graphql/network-error-component.spec.tsx

@@ -233,6 +233,10 @@ describe("NetworkErrorComponent", () => {
   })
 
   it("ignores InvalidAuthentication when networkErrorToken differs from current token", async () => {
+    // The component logs the ignored stale-token 401 via console.debug;
+    // capture it so the expected log doesn't pollute CI logs (and assert it
+    // actually happened).
+    const consoleDebugSpy = jest.spyOn(console, "debug").mockImplementation(() => {})
     const { rerender } = render(<NetworkErrorComponent />)
 
     ;(useNetworkError as jest.Mock).mockReturnValue({
@@ -250,9 +254,18 @@ describe("NetworkErrorComponent", () => {
       expect(mockLogout).not.toHaveBeenCalled()
       expect(mockClearNetworkError).toHaveBeenCalled()
     })
+    expect(consoleDebugSpy).toHaveBeenCalledWith(
+      "Ignoring 401 for non-active token",
+      expect.objectContaining({ networkErrorToken: "stale-token" }),
+    )
+    consoleDebugSpy.mockRestore()
   })
 
   it("falls back to logout on error during token expiry handling", async () => {
+    // The component logs the simulated storage failure via console.error;
+    // capture it so the expected error doesn't pollute CI logs (and assert it
+    // actually happened).
+    const consoleErrorSpy = jest.spyOn(console, "error").mockImplementation(() => {})
     ;(KeyStoreWrapper.getSessionProfiles as jest.Mock).mockRejectedValue(
       new Error("Storage error"),
     )
@@ -275,5 +288,10 @@ describe("NetworkErrorComponent", () => {
       })
       expect(mockClearNetworkError).toHaveBeenCalled()
     })
+    expect(consoleErrorSpy).toHaveBeenCalledWith(
+      "Error handling token expiry:",
+      expect.objectContaining({ message: "Storage error" }),
+    )
+    consoleErrorSpy.mockRestore()
   })
 })

__tests__/hooks/use-kyc-flow.spec.ts

@@ -187,6 +187,9 @@ describe("useKycFlow", () => {
   })
 
   it("calls goBack on canceled error", async () => {
+    // The hook logs the simulated failure via console.error; capture it so the
+    // expected error doesn't pollute CI logs (and assert it actually happened).
+    const consoleErrorSpy = jest.spyOn(console, "error").mockImplementation(() => {})
     mockKycFlowStart.mockRejectedValue(new Error("Request canceled by user"))
 
     const { result } = renderHook(() => useKycFlow())
@@ -197,9 +200,17 @@ describe("useKycFlow", () => {
 
     expect(mockGoBack).toHaveBeenCalledTimes(1)
     expect(Alert.alert).not.toHaveBeenCalled()
+    expect(consoleErrorSpy).toHaveBeenCalledWith(
+      "error:",
+      expect.objectContaining({ message: "Request canceled by user" }),
+    )
+    consoleErrorSpy.mockRestore()
   })
 
   it("shows Alert on other errors", async () => {
+    // The hook logs the simulated failure via console.error; capture it so the
+    // expected error doesn't pollute CI logs (and assert it actually happened).
+    const consoleErrorSpy = jest.spyOn(console, "error").mockImplementation(() => {})
     mockKycFlowStart.mockRejectedValue(new Error("Network failure"))
 
     const { result } = renderHook(() => useKycFlow())
@@ -213,6 +224,11 @@ describe("useKycFlow", () => {
       expect.stringContaining("Network failure"),
       expect.arrayContaining([expect.objectContaining({ text: "OK" })]),
     )
+    expect(consoleErrorSpy).toHaveBeenCalledWith(
+      "error:",
+      expect.objectContaining({ message: "Network failure" }),
+    )
+    consoleErrorSpy.mockRestore()
   })
 
   it("sets loading true during startKyc, false after", async () => {

__tests__/hooks/use-show-warning-secure-account.spec.tsx

@@ -5,6 +5,7 @@ import { act } from "react-test-renderer"
 import { MockedProvider } from "@apollo/client/testing"
 import {
   CurrencyListDocument,
+  DisplayCurrencyDocument,
   RealtimePriceDocument,
   WarningSecureAccountDocument,
 } from "@app/graphql/generated"
@@ -42,6 +43,8 @@ const mocksPrice = [
     request: {
       query: RealtimePriceDocument,
     },
+    // The hook re-renders and re-requests; reusable so MockLink never warns
+    maxUsageCount: Number.POSITIVE_INFINITY,
     result: {
       data: {
         me: {
@@ -77,6 +80,7 @@ const mocksPrice = [
     request: {
       query: CurrencyListDocument,
     },
+    maxUsageCount: Number.POSITIVE_INFINITY,
     result: {
       data: {
         currencyList: [
@@ -92,6 +96,25 @@ const mocksPrice = [
       },
     },
   },
+  {
+    request: {
+      query: DisplayCurrencyDocument,
+    },
+    maxUsageCount: Number.POSITIVE_INFINITY,
+    result: {
+      data: {
+        me: {
+          id: "70df9822-efe0-419c-b864-c9efa99872ea",
+          defaultAccount: {
+            id: "84b26b88-89b0-5c6f-9d3d-fbead08f79d8",
+            displayCurrency: "USD",
+            __typename: "ConsumerAccount",
+          },
+          __typename: "User",
+        },
+      },
+    },
+  },
 ]
 
 const mockLevelZeroLowBalance = [

__tests__/i18n/lazy-locale-loader.test.ts

@@ -25,14 +25,23 @@ const mockedLoadLocaleAsync = loadLocaleAsync as jest.MockedFunction<
 >
 
 describe("lazy-locale-loader", () => {
+  // ensureLocaleLoaded logs "Loading locale on demand: <locale>" in __DEV__
+  // (which jest runs as); capture it so the expected log doesn't pollute CI logs.
+  let consoleLogSpy: jest.SpyInstance
+
   beforeEach(() => {
     jest.clearAllMocks()
+    consoleLogSpy = jest.spyOn(console, "log").mockImplementation(() => {})
     // Reset loadedLocales
     for (const key of Object.keys(loadedLocales)) {
       delete (loadedLocales as Record<string, unknown>)[key]
     }
   })
 
+  afterEach(() => {
+    consoleLogSpy.mockRestore()
+  })
+
   describe("isLocaleLoaded", () => {
     it("returns false for an unloaded locale", () => {
       expect(isLocaleLoaded("fr" as Locales)).toBe(false)
@@ -48,6 +57,7 @@ describe("lazy-locale-loader", () => {
     it("calls loadLocaleAsync for an unloaded locale", async () => {
       await ensureLocaleLoaded("de" as Locales)
       expect(mockedLoadLocaleAsync).toHaveBeenCalledWith("de")
+      expect(consoleLogSpy).toHaveBeenCalledWith("Loading locale on demand: de")
     })
 
     it("skips loadLocaleAsync if locale is already loaded", async () => {

__tests__/receive-bitcoin/hooks/use-invoice-lifecycle.spec.ts

@@ -31,6 +31,12 @@ jest.mock("@app/graphql/generated", () => ({
   WalletCurrency: { Btc: "BTC", Usd: "USD" },
 }))
 
+// prcd must keep a stable identity across renders: useInvoiceLifecycle's
+// layout effect recreates the PR whenever prcd changes, so an inline object
+// literal per render would loop with the state-updating effects until React
+// aborts with "Maximum update depth exceeded".
+const stablePrcd = { id: "test" } as never
+
 const mockMutations = {
   lnNoAmountInvoiceCreate: jest.fn(),
   lnInvoiceCreate: jest.fn(),
@@ -116,7 +122,7 @@ describe("useInvoiceLifecycle", () => {
     )
 
     const { result } = renderHook(() =>
-      useInvoiceLifecycle({ id: "test" } as never, mockMutations as never),
+      useInvoiceLifecycle(stablePrcd, mockMutations as never),
     )
 
     expect(result.current.regenerateInvoice).toBeDefined()
@@ -136,7 +142,7 @@ describe("useInvoiceLifecycle", () => {
     mockCreatePaymentRequest.mockReturnValue(mockPR)
     mockUseLnUpdateHashPaid.mockReturnValue("abc123")
 
-    renderHook(() => useInvoiceLifecycle({ id: "test" } as never, mockMutations as never))
+    renderHook(() => useInvoiceLifecycle(stablePrcd, mockMutations as never))
 
     expect(mockHaptic).toHaveBeenCalledWith("notificationSuccess", {
       ignoreAndroidSystemSettings: true,
@@ -156,7 +162,7 @@ describe("useInvoiceLifecycle", () => {
     mockCreatePaymentRequest.mockReturnValue(mockPR)
     mockUseLnUpdateHashPaid.mockReturnValue("different-hash")
 
-    renderHook(() => useInvoiceLifecycle({ id: "test" } as never, mockMutations as never))
+    renderHook(() => useInvoiceLifecycle(stablePrcd, mockMutations as never))
 
     expect(mockHaptic).not.toHaveBeenCalled()
   })
@@ -168,7 +174,7 @@ describe("useInvoiceLifecycle", () => {
     mockUseCountdown.mockReturnValue({ remainingSeconds: 300, isExpired: false })
 
     const { result } = renderHook(() =>
-      useInvoiceLifecycle({ id: "test" } as never, mockMutations as never),
+      useInvoiceLifecycle(stablePrcd, mockMutations as never),
     )
 
     expect(result.current.expiresInSeconds).toBe(300)

__tests__/receive-bitcoin/hooks/use-lnurl-withdraw.spec.ts

@@ -139,6 +139,9 @@ describe("useLnurlWithdraw", () => {
   })
 
   it("shows submission error on non-ok response", async () => {
+    // The hook logs the simulated failure via console.error; capture it so the
+    // expected error doesn't pollute CI logs (and assert it actually happened).
+    const consoleErrorSpy = jest.spyOn(console, "error").mockImplementation(() => {})
     const alertSpy = jest.spyOn(Alert, "alert")
     mockFetch.mockResolvedValue({
       ok: false,
@@ -156,9 +159,17 @@ describe("useLnurlWithdraw", () => {
     })
 
     expect(alertSpy).toHaveBeenCalledWith("Submission error")
+    expect(consoleErrorSpy).toHaveBeenCalledWith(
+      expect.anything(),
+      "error with submitting withdrawalRequest",
+    )
+    consoleErrorSpy.mockRestore()
   })
 
   it("shows redeeming error when response status is not ok", async () => {
+    // The hook logs the simulated failure via console.error; capture it so the
+    // expected error doesn't pollute CI logs (and assert it actually happened).
+    const consoleErrorSpy = jest.spyOn(console, "error").mockImplementation(() => {})
     const alertSpy = jest.spyOn(Alert, "alert")
     mockFetch.mockResolvedValue({
       ok: true,
@@ -176,6 +187,11 @@ describe("useLnurlWithdraw", () => {
     })
 
     expect(alertSpy).toHaveBeenCalledWith("Redeeming error", "Invalid k1")
+    expect(consoleErrorSpy).toHaveBeenCalledWith(
+      expect.objectContaining({ status: "ERROR", reason: "Invalid k1" }),
+      "error with redeeming",
+    )
+    consoleErrorSpy.mockRestore()
   })
 
   it("does not alert on successful withdraw", async () => {

__tests__/receive-bitcoin/hooks/use-payment-request.spec.ts

@@ -1,5 +1,7 @@
 import { renderHook } from "@testing-library/react-hooks"
 
+import { flushEffects } from "../../helpers/flush-effects"
+
 import { usePaymentRequest } from "@app/screens/receive-bitcoin-screen/hooks/use-payment-request"
 import { WalletCurrency } from "@app/graphql/generated"
 import {
@@ -28,12 +30,20 @@ jest.mock("@app/screens/receive-bitcoin-screen/hooks/use-wallet-resolution", ()
   useWalletResolution: () => mockUseWalletResolution(),
 }))
 
+// The mutation functions must keep a stable identity across renders: they
+// feed the `mutations` useMemo in usePaymentRequest, and a fresh jest.fn()
+// per render would re-trigger useInvoiceLifecycle's layout effect on every
+// render, looping until React aborts with "Maximum update depth exceeded".
+const mockLnInvoiceCreate = jest.fn()
+const mockLnNoAmountInvoiceCreate = jest.fn()
+const mockLnUsdInvoiceCreate = jest.fn()
+const mockOnChainAddressCurrent = jest.fn()
 jest.mock("@app/graphql/generated", () => ({
   WalletCurrency: { Btc: "BTC", Usd: "USD" },
-  useLnInvoiceCreateMutation: () => [jest.fn()],
-  useLnNoAmountInvoiceCreateMutation: () => [jest.fn()],
-  useLnUsdInvoiceCreateMutation: () => [jest.fn()],
-  useOnChainAddressCurrentMutation: () => [jest.fn()],
+  useLnInvoiceCreateMutation: () => [mockLnInvoiceCreate],
+  useLnNoAmountInvoiceCreateMutation: () => [mockLnNoAmountInvoiceCreate],
+  useLnUsdInvoiceCreateMutation: () => [mockLnUsdInvoiceCreate],
+  useOnChainAddressCurrentMutation: () => [mockOnChainAddressCurrent],
 }))
 
 const mockUseLnUpdateHashPaid = jest.fn()
@@ -153,17 +163,20 @@ describe("usePaymentRequest", () => {
     expect(result.current).toBeNull()
   })
 
-  it("creates PRCD with PayCode for BTC default wallet with username", () => {
+  it("creates PRCD with PayCode for BTC default wallet with username", async () => {
     setupMocksWithPR()
 
     renderHook(() => usePaymentRequest())
 
+    // Settle generateRequest's async setPR inside act()
+    await flushEffects()
+
     expect(mockCreatePaymentRequestCreationData).toHaveBeenCalledWith(
       expect.objectContaining({ type: Invoice.PayCode }),
     )
   })
 
-  it("creates PRCD with Lightning for wallet without username", () => {
+  it("creates PRCD with Lightning for wallet without username", async () => {
     const walletsNoUsername = { ...mockWallets, username: null }
     const mockPRCD = {
       ...createFullMockPRCD(),
@@ -189,12 +202,15 @@ describe("usePaymentRequest", () => {
 
     renderHook(() => usePaymentRequest())
 
+    // Settle generateRequest's async setPR inside act()
+    await flushEffects()
+
     expect(mockCreatePaymentRequestCreationData).toHaveBeenCalledWith(
       expect.objectContaining({ type: Invoice.Lightning }),
     )
   })
 
-  it("creates PRCD with Lightning for USD default wallet even with username", () => {
+  it("creates PRCD with Lightning for USD default wallet even with username", async () => {
     const walletsUsdDefault = {
       ...mockWallets,
       defaultWallet: { id: "usd-id", balance: 100, walletCurrency: WalletCurrency.Usd },
@@ -219,16 +235,22 @@ describe("usePaymentRequest", () => {
 
     renderHook(() => usePaymentRequest())
 
+    // Settle generateRequest's async setPR inside act()
+    await flushEffects()
+
     expect(mockCreatePaymentRequestCreationData).toHaveBeenCalledWith(
       expect.objectContaining({ type: Invoice.Lightning }),
     )
   })
 
-  it("uses default expiration time for BTC wallet", () => {
+  it("uses default expiration time for BTC wallet", async () => {
     setupMocksWithPR()
 
     renderHook(() => usePaymentRequest())
 
+    // Settle generateRequest's async setPR inside act()
+    await flushEffects()
+
     expect(mockCreatePaymentRequestCreationData).toHaveBeenCalledWith(
       expect.objectContaining({ expirationTime: 1440 }),
     )

__tests__/screens/card-screen/card-status-screen.spec.tsx

@@ -60,6 +60,18 @@ const cardApprovedWithCustomColorParams = {
   iconColor: "#FF5500",
 }
 
+// Some app handlers log placeholder/diagnostic messages via console.log when
+// pressed (e.g. "Add to wallet pressed" in card-status-layout); capture them so expected logs don't pollute CI logs.
+let consoleLogSpy: jest.SpyInstance
+
+beforeEach(() => {
+  consoleLogSpy = jest.spyOn(console, "log").mockImplementation(() => {})
+})
+
+afterEach(() => {
+  consoleLogSpy.mockRestore()
+})
+
 describe("CardStatusScreen - Card Approved variant", () => {
   beforeEach(() => {
     loadLocale("en")

__tests__/screens/card-screen/onboarding/card-flow/card-subscription-screen.spec.tsx

@@ -84,6 +84,18 @@ jest.mock("@app/hooks/use-display-currency", () => ({
   }),
 }))
 
+// Some app handlers log placeholder/diagnostic messages via console.log when
+// pressed (e.g. "TODO: payment flow" in card-subscription-screen); capture them so expected logs don't pollute CI logs.
+let consoleLogSpy: jest.SpyInstance
+
+beforeEach(() => {
+  consoleLogSpy = jest.spyOn(console, "log").mockImplementation(() => {})
+})
+
+afterEach(() => {
+  consoleLogSpy.mockRestore()
+})
+
 describe("CardSubscriptionScreen - subscribe variant", () => {
   beforeEach(() => {
     loadLocale("en")