fix(stablesats): region restriction is enforced inconsistently and can be bypassed

 (#3847)

Author: esaugomez31

.storybook/views/story-screen.tsx

@@ -5,7 +5,7 @@ const PersistentStateWrapper: React.FC<React.PropsWithChildren> = ({ children })
   <PersistentStateContext.Provider
     value={{
       persistentState: {
-        schemaVersion: 13,
+        schemaVersion: 14,
         galoyInstance: {
           id: "Main",
         },

__tests__/components/stablesats-restriction-modal/stablesats-restriction-modal.spec.tsx

@@ -77,41 +77,6 @@ describe("StablesatsRestrictionModal", () => {
     expect(mockNavigate).not.toHaveBeenCalled()
   })
 
-  it("fires onDismiss when Close is pressed", () => {
-    const onDismiss = jest.fn()
-    const { getByText } = render(
-      wrap(
-        <StablesatsRestrictionModal
-          isVisible={true}
-          toggleModal={jest.fn()}
-          onDismiss={onDismiss}
-        />,
-      ),
-    )
-
-    fireEvent.press(getByText("Close"))
-
-    expect(onDismiss).toHaveBeenCalledTimes(1)
-  })
-
-  it("does not fire onDismiss when Create new is pressed (navigates instead)", () => {
-    const onDismiss = jest.fn()
-    const { getByText } = render(
-      wrap(
-        <StablesatsRestrictionModal
-          isVisible={true}
-          toggleModal={jest.fn()}
-          onDismiss={onDismiss}
-        />,
-      ),
-    )
-
-    fireEvent.press(getByText("Create new"))
-
-    expect(onDismiss).not.toHaveBeenCalled()
-    expect(mockNavigate).toHaveBeenCalledWith("getStarted")
-  })
-
   it("renders nothing when isVisible is false", () => {
     const { queryByText } = render(
       wrap(<StablesatsRestrictionModal isVisible={false} toggleModal={jest.fn()} />),

__tests__/components/usd-convert-to-btc-modal/usd-convert-to-btc-modal.spec.tsx

@@ -32,14 +32,15 @@ jest.mock("@app/hooks/use-price-conversion", () => ({
 }))
 
 const mockExecute = jest.fn()
-const mockUseIntraLedgerConversion = jest.fn(() => ({
+const mockUseIntraLedgerConversion = jest.fn((_config?: { onSuccess: () => void }) => ({
   execute: mockExecute,
   loading: false,
   errorMessage: undefined as string | undefined,
 }))
 
 jest.mock("@app/hooks/use-intra-ledger-conversion", () => ({
-  useIntraLedgerConversion: () => mockUseIntraLedgerConversion(),
+  useIntraLedgerConversion: (config: { onSuccess: () => void }) =>
+    mockUseIntraLedgerConversion(config),
 }))
 
 import { UsdConvertToBtcModal } from "@app/components/usd-convert-to-btc-modal"
@@ -146,4 +147,16 @@ describe("UsdConvertToBtcModal", () => {
 
     expect(queryByTestId("icon-close")).toBeNull()
   })
+
+  it("closes only on success: the conversion onSuccess handler is wired to toggleModal", () => {
+    const toggleModal = jest.fn()
+    renderModal({ toggleModal })
+
+    const { onSuccess } = mockUseIntraLedgerConversion.mock.calls[0][0] as {
+      onSuccess: () => void
+    }
+    onSuccess()
+
+    expect(toggleModal).toHaveBeenCalledTimes(1)
+  })
 })

__tests__/hooks/use-default-account-modal-shown.spec.ts

@@ -14,7 +14,7 @@ jest.mock("@app/store/persistent-state", () => ({
 }))
 
 const baseState: PersistentState = {
-  schemaVersion: 13,
+  schemaVersion: 14,
   galoyInstance: { id: "Main" },
   galoyAuthToken: "",
 }

__tests__/hooks/use-device-location.spec.ts

@@ -1,7 +1,7 @@
 import { renderHook, act } from "@testing-library/react-hooks"
 import axios from "axios"
 
-import useDeviceLocation from "@app/hooks/use-device-location"
+import useDeviceLocation, { useIpCountryCode } from "@app/hooks/use-device-location"
 
 const mockLogError = jest.fn()
 const mockUpdateCountryCode = jest.fn()
@@ -62,6 +62,7 @@ describe("useDeviceLocation", () => {
     expect(result.current.loading).toBe(false)
     expect(result.current.countryCode).toBe("DE")
     expect(result.current.detectionFailed).toBe(false)
+    expect(result.current.source).toBe("phone")
     expect(mockedAxios.get).not.toHaveBeenCalled()
   })
 
@@ -123,6 +124,7 @@ describe("useDeviceLocation", () => {
     expect(result.current.loading).toBe(false)
     expect(result.current.countryCode).toBe("PL")
     expect(result.current.detectionFailed).toBe(false)
+    expect(result.current.source).toBe("ip")
     expect(mockedAxios.get).toHaveBeenCalled()
   })
 
@@ -256,3 +258,39 @@ describe("useDeviceLocation", () => {
     expect(mockLogError).toHaveBeenCalled()
   })
 })
+
+describe("useIpCountryCode", () => {
+  beforeEach(() => {
+    jest.clearAllMocks()
+  })
+
+  it("does not call ipapi while disabled", () => {
+    const { result } = renderHook(() => useIpCountryCode(false))
+
+    expect(mockedAxios.get).not.toHaveBeenCalled()
+    expect(result.current).toBeUndefined()
+  })
+
+  it("resolves the country from ipapi when enabled", async () => {
+    // eslint-disable-next-line camelcase
+    mockedAxios.get.mockResolvedValue({ data: { country_code: "HK" } })
+
+    const { result } = renderHook(() => useIpCountryCode(true))
+
+    await act(async () => {})
+
+    expect(mockedAxios.get).toHaveBeenCalled()
+    expect(result.current).toBe("HK")
+  })
+
+  it("stays undefined when ipapi fails", async () => {
+    mockedAxios.get.mockRejectedValue(new Error("403 Forbidden"))
+
+    const { result } = renderHook(() => useIpCountryCode(true))
+
+    await act(async () => {})
+
+    expect(result.current).toBeUndefined()
+    expect(mockLogError).toHaveBeenCalled()
+  })
+})