fix(transaction-detail): show Spark label for self-custodial Spark transactions

Author: esaugomez31

__tests__/screens/transaction-detail-screen.spec.ts

@@ -0,0 +1,30 @@
+import { typeDisplay } from "@app/screens/transaction-detail-screen/transaction-detail-screen"
+import { PaymentType } from "@app/types/transaction.types"
+
+const settlement = <T extends string>(typename: T) => ({ __typename: typename }) as never
+
+describe("typeDisplay", () => {
+  it("returns 'Spark' when the self-custodial paymentType is Spark, even if settlementVia is Lightning", () => {
+    expect(typeDisplay(settlement("SettlementViaLn"), PaymentType.Spark)).toBe("Spark")
+  })
+
+  it("falls back to the settlementVia typename when no self-custodial paymentType is given", () => {
+    expect(typeDisplay(settlement("SettlementViaOnChain"))).toBe("OnChain")
+    expect(typeDisplay(settlement("SettlementViaLn"))).toBe("Lightning")
+    expect(typeDisplay(settlement("SettlementViaIntraLedger"))).toBe("IntraLedger")
+  })
+
+  it("keeps the settlementVia mapping for non-Spark self-custodial paymentTypes (Lightning, Onchain)", () => {
+    expect(typeDisplay(settlement("SettlementViaLn"), PaymentType.Lightning)).toBe(
+      "Lightning",
+    )
+    expect(typeDisplay(settlement("SettlementViaOnChain"), PaymentType.Onchain)).toBe(
+      "OnChain",
+    )
+  })
+
+  it("returns 'Unknown' for missing or malformed settlementVia with no Spark hint", () => {
+    expect(typeDisplay(undefined)).toBe("Unknown")
+    expect(typeDisplay({} as never)).toBe("Unknown")
+  })
+})

app/screens/transaction-detail-screen/transaction-detail-screen.tsx

@@ -23,6 +23,7 @@ import { useAppConfig, useClipboard, useTransactionSeenState } from "@app/hooks"
 import { useDisplayCurrency } from "@app/hooks/use-display-currency"
 import { useI18nContext } from "@app/i18n/i18n-react"
 import { toWalletAmount } from "@app/types/amounts"
+import { PaymentType } from "@app/types/transaction.types"
 import { RouteProp, useNavigation } from "@react-navigation/native"
 import { StackNavigationProp } from "@react-navigation/stack"
 import { makeStyles, Text, useTheme } from "@rn-vui/themed"
@@ -72,7 +73,12 @@ const Row = ({
   )
 }
 
-const typeDisplay = (instance?: SettlementVia | DeepPartialObject<SettlementVia>) => {
+export const typeDisplay = (
+  instance?: SettlementVia | DeepPartialObject<SettlementVia>,
+  selfCustodialPaymentType?: PaymentType,
+) => {
+  if (selfCustodialPaymentType === PaymentType.Spark) return "Spark"
+
   if (!instance || !instance.__typename) {
     return "Unknown"
   }
@@ -130,10 +136,19 @@ export const TransactionDetailScreen: React.FC<Props> = ({ route }) => {
   const [timer, setTimer] = React.useState<number>(0)
 
   const { LL, locale } = useI18nContext()
-  const { isSelfCustodial } = useActiveWallet()
+  const { isSelfCustodial, wallets } = useActiveWallet()
   const { copyToClipboard } = useClipboard()
   const { formatCurrency } = useDisplayCurrency()
 
+  const selfCustodialPaymentType = React.useMemo(() => {
+    if (!isSelfCustodial) return undefined
+    for (const wallet of wallets) {
+      const match = wallet.transactions.find((t) => t.id === txid)
+      if (match) return match.paymentType
+    }
+    return undefined
+  }, [isSelfCustodial, wallets, txid])
+
   const description = useDescriptionDisplay({
     tx,
     bankName: galoyInstance.name,
@@ -429,7 +444,10 @@ export const TransactionDetailScreen: React.FC<Props> = ({ route }) => {
               value={settlementVia.counterPartyUsername || galoyInstance.name}
             />
           )}
-          <Row entry={LL.common.type()} value={typeDisplay(settlementVia)} />
+          <Row
+            entry={LL.common.type()}
+            value={typeDisplay(settlementVia, selfCustodialPaymentType)}
+          />
           {initiationVia?.__typename === "InitiationViaLn" &&
             initiationVia?.paymentHash && (
               <Row