Update behaviour to fail deposit when getting an unexpected risk result (#74)

* Add deposit reversal risk controller

* Update behaviour to fail deposit when getting an unexpected risk result

Author: ametke

innie/src/main/kotlin/xyz/block/bittycity/innie/controllers/DepositRiskController.kt

@@ -40,7 +40,7 @@ class DepositRiskController @Inject constructor(
         when (riskResult) {
           is RiskEvaluation.ActiveScamWarning -> {
             logger.warn { "Unexpected scam result: $riskResult" }
-            value.transitionTo(Settled, metricsClient)
+            value.fail(DepositFailureReason.UNEXPECTED_RISK_RESULT, metricsClient)
           }
           RiskEvaluation.Checked -> value.transitionTo(Settled, metricsClient)
           is RiskEvaluation.Blocked -> value.fail(DepositFailureReason.RISK_BLOCKED, metricsClient)

innie/src/main/kotlin/xyz/block/bittycity/innie/models/DepositFailureReason.kt

@@ -3,5 +3,6 @@ package xyz.block.bittycity.innie.models
 enum class DepositFailureReason {
   INELIGIBLE,
   RISK_BLOCKED,
+  UNEXPECTED_RISK_RESULT,
   UNKNOWN
 }

innie/src/test/kotlin/xyz/block/bittycity/innie/controllers/DepositRiskControllerTest.kt

@@ -11,6 +11,7 @@ import xyz.block.bittycity.common.client.RiskEvaluation
 import xyz.block.bittycity.innie.api.DepositDomainController
 import xyz.block.bittycity.innie.models.CheckingDepositRisk
 import xyz.block.bittycity.innie.models.DepositFailureReason.RISK_BLOCKED
+import xyz.block.bittycity.innie.models.DepositFailureReason.UNEXPECTED_RISK_RESULT
 import xyz.block.bittycity.innie.models.Settled
 import xyz.block.bittycity.innie.models.WaitingForReversal
 import xyz.block.bittycity.innie.testing.Arbitrary.amount
@@ -49,6 +50,29 @@ class DepositRiskControllerTest : BittyCityTestCase() {
     }
   }
 
+  @Test
+  fun `Fail with unexpected risk result`() = runTest {
+    val deposit = data.seedDeposit(
+      state = CheckingDepositRisk,
+      customerId = customerId.next(),
+      amount = amount.next(),
+      exchangeRate = exchangeRate.next(),
+      targetWalletAddress = walletAddress.next(),
+      blockchainTransactionId = stringToken.next(),
+      blockchainTransactionOutputIndex = outputIndex.next(),
+      paymentToken = stringToken.next(),
+    )
+
+    riskClient.nextRiskResult = RiskEvaluation.ActiveScamWarning().success()
+
+    subject.execute(deposit, emptyList(), Operation.EXECUTE).shouldBeSuccess()
+
+    depositWithToken(deposit.id) should {
+      it.state shouldBe WaitingForReversal
+      it.failureReason shouldBe UNEXPECTED_RISK_RESULT
+    }
+  }
+
   @Test
   fun `Continue after risk check is ok`() = runTest {
     val deposit = data.seedDeposit(