Commit 087b5e3
docs(testing): record the setup-race timeout rule
Add a second rule to Review-Proven Test Standards: a wall-clock timeout
that gates test setup is a race budget, not a tuning knob. Size it
against measured worst-case latency on a loaded machine rather than the
idle case, record the measurement at the call site so it is not trimmed
back toward the latency it exists to clear, and make a lost setup race
say so rather than surfacing as an opaque parse error.
Generalizes the flake fixed in a41fcb3, where the escaped-writer probe
in bounded_command.rs budgeted 300ms for a descendant whose spawn-to-ready
latency measured ~30ms idle but p95 233ms / max 498ms under a loaded lane.
Also correct the section intro, which read "this is the test-quality rule"
in the singular and attributed the section wholesale to the 25-PR review
mining. This rule came from a fixed flake, not a review thread, so the
intro now separates the mined rule from later additions instead of
extending that provenance to them.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GecRn4WhoM35gz9fRY7Y1A
Signed-off-by: mraad <mraad23@gmail.com>1 parent a41fcb3 commit 087b5e3
1 file changed
Lines changed: 17 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
18 | 18 | | |
19 | 19 | | |
20 | 20 | | |
21 | | - | |
22 | | - | |
23 | | - | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
24 | 24 | | |
25 | 25 | | |
26 | 26 | | |
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
34 | 48 | | |
35 | 49 | | |
36 | 50 | | |
| |||
0 commit comments