fix(desktop): migrate legacy welcome marker keys

Co-authored-by: Brad Groux <bradgroux@hotmail.com>
Signed-off-by: Brad Groux <bradgroux@hotmail.com>

Author: 2 people

desktop/src/features/onboarding/welcome.test.mjs

@@ -302,6 +302,26 @@ test("Welcome ensured marker canonicalizes relay URL differences", () => {
   }
 });
 
+test("Welcome ensured marker migrates the legacy raw relay URL key", () => {
+  const { restore } = installWindowSessionStorage();
+  try {
+    const rawRelayUrl = "WSS://Community-A.Example/";
+    const legacyKey = `buzz-welcome-channel-ensured.v2:${encodeURIComponent(rawRelayUrl)}:pubkey-a`;
+    window.localStorage.setItem(legacyKey, "true");
+
+    assert.equal(
+      hasEnsuredWelcomeChannel("pubkey-a", rawRelayUrl),
+      true,
+    );
+    assert.equal(
+      hasEnsuredWelcomeChannel("pubkey-a", "wss://community-a.example"),
+      true,
+    );
+  } finally {
+    restore();
+  }
+});
+
 test("ensureStarterChannels reuses existing open starter channels", async () => {
   const general = makeChannel({
     id: "general-channel",

desktop/src/features/onboarding/welcome.ts

@@ -291,6 +291,15 @@ export function welcomeChannelEnsuredStorageKey(
   )}:${pubkey}`;
 }
 
+function legacyWelcomeChannelEnsuredStorageKey(
+  pubkey: string,
+  communityScope: string,
+) {
+  return `${WELCOME_CHANNEL_ENSURED_STORAGE_KEY}:${encodeURIComponent(
+    communityScope,
+  )}:${pubkey}`;
+}
+
 export function hasEnsuredWelcomeChannel(
   pubkey: string | null | undefined,
   communityScope: string | null | undefined,
@@ -300,11 +309,29 @@ export function hasEnsuredWelcomeChannel(
   }
 
   try {
-    return (
-      window.localStorage.getItem(
-        welcomeChannelEnsuredStorageKey(pubkey, communityScope),
-      ) === "true"
+    const canonicalKey = welcomeChannelEnsuredStorageKey(
+      pubkey,
+      communityScope,
     );
+    if (window.localStorage.getItem(canonicalKey) === "true") {
+      return true;
+    }
+
+    // Existing installs wrote the raw relay URL into this key. Migrate the
+    // exact legacy marker while the configured URL is still unchanged, so a
+    // later formatting-only edit cannot trigger one final duplicate team.
+    const legacyKey = legacyWelcomeChannelEnsuredStorageKey(
+      pubkey,
+      communityScope,
+    );
+    if (
+      legacyKey !== canonicalKey &&
+      window.localStorage.getItem(legacyKey) === "true"
+    ) {
+      window.localStorage.setItem(canonicalKey, "true");
+      return true;
+    }
+    return false;
   } catch {
     return false;
   }

desktop/src/features/onboarding/welcomeGuide.test.mjs

@@ -331,7 +331,7 @@ test("starter matching uses persona identity rather than display name", () => {
   );
 });
 
-test("starter matching is relay scoped and normalizes trailing slashes", () => {
+test("starter matching is relay scoped and canonicalizes URL formatting", () => {
   const pollen = WELCOME_TEAM_STARTERS[2];
   const otherRelay = makeAgent({
     personaId: pollen.personaId,
@@ -340,7 +340,7 @@ test("starter matching is relay scoped and normalizes trailing slashes", () => {
   });
   const matchingRelay = makeAgent({
     personaId: pollen.personaId,
-    relayUrl: `${RELAY_A}/`,
+    relayUrl: `${RELAY_A.toUpperCase()}/`,
     pubkey: PUB_B,
   });