Cover external protobuf enum edges

Author: jwils

elasticgraph-proto_ingestion/spec/unit/elastic_graph/proto_ingestion/schema_definition/schema_edge_cases_spec.rb

@@ -66,6 +66,34 @@ def self.enums
           ))
         end
 
+        it "raises when an externally sourced enum value conflicts with the generated zero value" do
+          proto_status = ::Class.new do
+            def self.enums
+              [::Data.define(:name).new(name: :UNSPECIFIED)]
+            end
+          end
+
+          results = define_proto_schema_results do |s|
+            s.enum_type "Status" do |t|
+              t.value "ACTIVE"
+              t.external_proto_enum proto_status
+            end
+
+            s.object_type "Account" do |t|
+              t.field "id", "ID"
+              t.field "status", "Status"
+              t.index "accounts"
+            end
+          end
+
+          expect {
+            results.proto_schema
+          }.to raise_error(Errors::SchemaError, a_string_including(
+            "Enum `Status` value `UNSPECIFIED`",
+            "conflicts with the generated zero value `STATUS_UNSPECIFIED`"
+          ))
+        end
+
         it "raises when an enum value conflicts with the generated zero value" do
           expect {
             define_proto_schema do |s|

elasticgraph-proto_ingestion/spec/unit/elastic_graph/proto_ingestion/schema_definition/schema_spec.rb

@@ -849,11 +849,21 @@ def self.enums
             end
           end
 
+          proto_status_c = ::Class.new do
+            def self.enums
+              [
+                ::Data.define(:name).new(name: :ACTIVE),
+                ::Data.define(:name).new(name: :INACTIVE)
+              ]
+            end
+          end
+
           results = define_proto_schema_results do |s|
             s.enum_type "Status" do |t|
               t.values "ACTIVE", "INACTIVE"
               t.external_proto_enum proto_status_a
               t.external_proto_enum proto_status_b
+              t.external_proto_enum proto_status_c
             end
 
             s.object_type "Account" do |t|
@@ -883,6 +893,7 @@ def self.enums
           proto = define_proto_schema do |s|
             s.enum_type "Status" do |t|
               t.values "ACTIVE", "INACTIVE"
+              expect(t.proto_name).to eq("Status")
               t.external_proto_enum proto_status,
                 proto: "myapp.types.Status",
                 import: "myapp/types/status.proto"