Fix type check for rbs 4.0.3 -> 4.2.0 bump

rbs 4.2 retypes Hash#[]/#fetch/Hash.new's block key param as `_Key`
(hash+eql? only) instead of `K`, breaking type checks wherever custom
interfaces (_Client, _Operation, SupportsFilteringAndAggregation) are
used as hash keys, since those interfaces don't declare hash/eql?.

- Bump steep to ~> 2.1.0 (fixes rbs 4.2's Hash#to_h `_Pair` block sig).
- Add `client`/`operation`/`filterableAndAggregatableType` aliases
  (interface & ::Object) and use them wherever these values flow into
  hash keys, since every real implementer is a Ruby object.
- Reassign-with-annotation inside `Hash.new { |h, key| ... }` blocks
  where the key param's type isn't tied to any generic.

Author: myronmarston

Gemfile

@@ -37,7 +37,7 @@ group :development do
   gem "simplecov", "~> 1.0", ">= 1.0.3"
   gem "simplecov-console", "~> 0.9", ">= 0.9.5"
   gem "standard", "~> 1.56.0"
-  gem "steep", "~> 2.0.0", platforms: :ruby
+  gem "steep", "~> 2.1.0", platforms: :ruby
   gem "super_diff", "~> 0.19"
   gem "vcr", "~> 6.4"
 end

Gemfile.lock

@@ -603,7 +603,7 @@ GEM
     standard-performance (1.9.0)
       lint_roller (~> 1.1)
       rubocop-performance (~> 1.26.0)
-    steep (2.0.0)
+    steep (2.1.0)
       concurrent-ruby (>= 1.1.10)
       csv (>= 3.0.9)
       fileutils (>= 1.1.0)
@@ -614,7 +614,7 @@ GEM
       parser (>= 3.2)
       prism (>= 0.25.0)
       rainbow (>= 2.2.2, < 4.0)
-      rbs (~> 4.0)
+      rbs (~> 4.2)
       securerandom (>= 0.1)
       strscan (>= 1.0.0)
       terminal-table (>= 2, < 5)
@@ -722,7 +722,7 @@ DEPENDENCIES
   simplecov (~> 1.0, >= 1.0.3)
   simplecov-console (~> 0.9, >= 0.9.5)
   standard (~> 1.56.0)
-  steep (~> 2.0.0)
+  steep (~> 2.1.0)
   super_diff (~> 0.19)
   vcr (~> 6.4)
   yard (~> 0.9, >= 0.9.45)
@@ -754,7 +754,6 @@ CHECKSUMS
   benchmark-ips (2.15.1) sha256=07a1a9f3c6105ecaf68c174fc3fbcddd71a0e9ada6236ae03093a0dcfd812d59
   bigdecimal (4.1.2) sha256=53d217666027eab4280346fba98e7d5b66baaae1b9c3c1c0ffe89d48188a3fbd
   bigdecimal (4.1.2-java) sha256=ccc836eab720a525529f70ed0de26a206fdbc9a9e8ac67b3b4ac7318b03e114d
-  bundler (4.0.13) sha256=19f08be7f27022cf0b89f27da0b044ae075e8270a9ef44ad248a932614e1ca3b
   coderay (1.1.3) sha256=dc530018a4684512f8f38143cd2a096c9f02a1fc2459edcfe534787a7fc77d4b
   colorator (1.1.0) sha256=e2f85daf57af47d740db2a32191d1bdfb0f6503a0dfbc8327d0c9154d5ddfc38
   concurrent-ruby (1.3.8) sha256=b2f1be836e968ccc78ccfce277ea79c72a88633f22306782c16ff23fb415d1e1
@@ -926,7 +925,7 @@ CHECKSUMS
   standard (1.56.0) sha256=ae2af4d9669589162ac69ed5ef59dcf9f346d4afc81f7e62b84339310dfcb787
   standard-custom (1.0.2) sha256=424adc84179a074f1a2a309bb9cf7cd6bfdb2b6541f20c6bf9436c0ba22a652b
   standard-performance (1.9.0) sha256=49483d31be448292951d80e5e67cdcb576c2502103c7b40aec6f1b6e9c88e3f2
-  steep (2.0.0) sha256=6eb0ecc09637bbb54f0a5f2cf63daea6d3208ccace64b4f1107d976333605c30
+  steep (2.1.0) sha256=1daf53573283b0e6d404a7273cca41fe5c15b14ece05167934f5ffc179e171d9
   strscan (3.1.8) sha256=aae2db611a225559f21ffbb71765c9a4e60fd262534a9ea84f4f11c7f32f679e
   strscan (3.1.8-java) sha256=07c9fb169931fc7327e9ae64b27999e355c2eadd0eaae4ed0f1e7d4e05a2b429
   super_diff (0.19.0) sha256=c35fc1c0daa223d67b203fe3fb49a6cfd67850a53920319565c3c654e03ec902

elasticgraph-admin/sig/elastic_graph/admin/cluster_configurator.rbs

@@ -2,7 +2,7 @@ module ElasticGraph
   class Admin
     class ClusterConfigurator
       def initialize: (
-        datastore_clients_by_name: ::Hash[::String, DatastoreCore::_Client],
+        datastore_clients_by_name: ::Hash[::String, DatastoreCore::client],
         index_defs: ::Array[DatastoreCore::indexDefinition],
         index_configurations_by_name: ::Hash[::String, untyped],
         index_template_configurations_by_name: ::Hash[::String, untyped],
@@ -18,7 +18,7 @@ module ElasticGraph
 
       private
 
-      @datastore_clients_by_name: ::Hash[::String, DatastoreCore::_Client]
+      @datastore_clients_by_name: ::Hash[::String, DatastoreCore::client]
       @index_defs: ::Array[DatastoreCore::indexDefinition]
       @index_configurations_by_name: DatastoreCore::indexConfigHash
       @scripts_by_id: datastoreScriptsByIdHash

elasticgraph-admin/sig/elastic_graph/admin/cluster_configurator/cluster_settings_manager.rbs

@@ -5,7 +5,7 @@ module ElasticGraph
         type clusterSpec = ::String | :all_clusters
 
         def initialize: (
-          datastore_clients_by_name: ::Hash[::String, DatastoreCore::_Client],
+          datastore_clients_by_name: ::Hash[::String, DatastoreCore::client],
           datastore_config: DatastoreCore::Config,
           logger: ::Logger) -> void
 
@@ -15,12 +15,12 @@ module ElasticGraph
 
         private
 
-        @datastore_clients_by_name: ::Hash[::String, DatastoreCore::_Client]
+        @datastore_clients_by_name: ::Hash[::String, DatastoreCore::client]
         @datastore_config: DatastoreCore::Config
         @logger: ::Logger
 
         def desired_cluster_settings: (::String, ?auto_create_index_patterns: ::Array[::String]) -> ::Hash[::String, untyped]
-        def datastore_client_named: (::String) -> DatastoreCore::_Client
+        def datastore_client_named: (::String) -> DatastoreCore::client
         def cluster_names_for: (clusterSpec) -> ::Array[::String]
       end
     end

elasticgraph-admin/sig/elastic_graph/admin/cluster_configurator/script_configurator.rbs

@@ -3,7 +3,7 @@ module ElasticGraph
     class ClusterConfigurator
       class ScriptConfigurator
         def initialize: (
-            datastore_client: DatastoreCore::_Client,
+            datastore_client: DatastoreCore::client,
             script_context: datastoreScriptContext,
             script_id: ::String,
             script: datastoreScriptScriptHash,
@@ -14,7 +14,7 @@ module ElasticGraph
 
         private
 
-        @datastore_client: DatastoreCore::_Client
+        @datastore_client: DatastoreCore::client
         @script_context: datastoreScriptContext
         @script_id: ::String
         @script: datastoreScriptScriptHash

elasticgraph-admin/sig/elastic_graph/admin/datastore_client_dry_run_decorator.rbs

@@ -2,7 +2,7 @@ module ElasticGraph
   class Admin
     class DatastoreClientDryRunDecorator
       include DatastoreCore::_Client
-      def initialize: (DatastoreCore::_Client) -> void
+      def initialize: (DatastoreCore::client) -> void
     end
   end
 end

elasticgraph-admin/sig/elastic_graph/admin/index_definition_configurator.rbs

@@ -4,7 +4,7 @@ module ElasticGraph
 
     module IndexDefinitionConfigurator
       def self.new: (
-        DatastoreCore::_Client,
+        DatastoreCore::client,
         DatastoreCore::indexDefinition,
         ::Hash[::String, untyped],
         io,

elasticgraph-admin/sig/elastic_graph/admin/index_definition_configurator/for_index.rbs

@@ -5,7 +5,7 @@ module ElasticGraph
         attr_reader index: DatastoreCore::IndexDefinition::Index
 
         def initialize: (
-          DatastoreCore::_Client,
+          DatastoreCore::client,
           DatastoreCore::IndexDefinition::Index,
           ::Hash[::String, untyped],
           io
@@ -16,7 +16,7 @@ module ElasticGraph
 
         private
 
-        @datastore_client: DatastoreCore::_Client
+        @datastore_client: DatastoreCore::client
         @index: DatastoreCore::IndexDefinition::Index
         @env_agnostic_index_config: ::Hash[::String, untyped]
         @reporter: ClusterConfigurator::ActionReporter

elasticgraph-admin/sig/elastic_graph/admin/index_definition_configurator/for_index_template.rbs

@@ -5,7 +5,7 @@ module ElasticGraph
         attr_reader index_template: DatastoreCore::IndexDefinition::RolloverIndexTemplate
 
         def initialize: (
-          DatastoreCore::_Client,
+          DatastoreCore::client,
           DatastoreCore::IndexDefinition::RolloverIndexTemplate,
           ::Hash[::String, untyped],
           io,
@@ -17,7 +17,7 @@ module ElasticGraph
 
         private
 
-        @datastore_client: DatastoreCore::_Client
+        @datastore_client: DatastoreCore::client
         @index_template: DatastoreCore::IndexDefinition::RolloverIndexTemplate
         @env_agnostic_index_config_parent: ::Hash[::String, untyped]
         @env_agnostic_index_config: ::Hash[::String, untyped]

elasticgraph-datastore_core/sig/elastic_graph/datastore_core.rbs

@@ -12,7 +12,7 @@ module ElasticGraph
       config: Config,
       logger: ::Logger,
       schema_artifacts: schemaArtifacts,
-      ?clients_by_name: ::Hash[::String, _Client]?,
+      ?clients_by_name: ::Hash[::String, client]?,
       ?client_customization_block: (^(untyped) -> void)?
     ) -> void
 
@@ -22,8 +22,8 @@ module ElasticGraph
     @index_definitions_by_graphql_type: ::Hash[::String, ::Array[indexDefinition]]?
     def index_definitions_by_graphql_type: () -> ::Hash[::String, ::Array[indexDefinition]]
 
-    @clients_by_name: ::Hash[::String, _Client]?
-    def clients_by_name: () -> ::Hash[::String, _Client]
+    @clients_by_name: ::Hash[::String, client]?
+    def clients_by_name: () -> ::Hash[::String, client]
 
     private