Replace deprecated SimpleCov APIs with their supported equivalents (#1350)

SimpleCov 1.0.3 deprecated `# :nocov:` and a few config APIs, so every
coverage-enabled run emits `[DEPRECATION]` warnings. This migrates to
the supported replacements:
- All `# :nocov:` toggle pairs (201 markers, 64 files) rewritten via
script to `# simplecov:disable` / `# simplecov:enable`, preserving
reason text. Docs/prose mentions updated too.
- In `enable_simplecov.rb`: `enable_for_subprocesses` →
`merge_subprocesses` and `add_filter` → `skip` (both documented
same-behavior renames).

One non-mechanical change: `track_files` → `cover` is not a drop-in
replacement — `cover` also *restricts* the report to its matchers, which
would silently drop loaded files outside the glob (e.g.
`spec_support/**`) from coverage enforcement on multi-gem runs. Since
only string globs drive unloaded-file backfill, adding a
match-everything block matcher restores the old semantics:

 ```ruby
cover "{#{gems_being_tested_globs.join(",")}}"
cover { |_source_file| true }
```

Verified: same multi-gem spec run on `main` and this branch produces an identical coverage report file universe; single-gem run has identical coverage totals with zero deprecation warnings.

Author: ellisandrews-toast

ai-memory/README.md

@@ -50,7 +50,7 @@ When in doubt, follow `AGENTS.md` for workflow and coding practices.
 - **Immutable functional style**: Prefer immutable objects and functional transformations where feasible.
 - **Prefer simpler approaches**: Choose simpler implementations for easier debugging and contributor onboarding.
 - **Avoid monkey patching**: Prevents future problems common with this Ruby technique.
-- **100% test coverage**: Every line and branch covered except where explicitly opted out with `:nocov:` comments.
+- **100% test coverage**: Every line and branch covered except where explicitly opted out with `simplecov:disable` comments.
 - **Validate all documentation snippets**: Code examples in documentation are validated by CI to ensure they always work.
 
 ## System Patterns

config/schema/teams.rb

@@ -180,22 +180,22 @@
     t.field "id", "ID!"
     t.relates_to_many "teams", "Team", via: "country_code", dir: :in, singular: "team"
 
-    # :nocov: -- only one side of these conditionals is executed in our test suite (but both are covered by rake tasks)
+    # simplecov:disable -- only one side of these conditionals is executed in our test suite (but both are covered by rake tasks)
     t.apollo_key fields: "id" if t.respond_to?(:apollo_key)
-    # :nocov:
+    # simplecov:enable
 
     # Note: we use `paginated_collection_field` here in order to exercise a case with the Apollo entity resolver and
     # a paginated collection field, which initially yielded an exception.
     t.paginated_collection_field "names", "String" do |f|
-      # :nocov: -- only one side of these conditionals is executed in our test suite (but both are covered by rake tasks)
+      # simplecov:disable -- only one side of these conditionals is executed in our test suite (but both are covered by rake tasks)
       f.apollo_external if f.respond_to?(:apollo_external)
-      # :nocov:
+      # simplecov:enable
     end
 
     t.field "currency", "String" do |f|
-      # :nocov: -- only one side of these conditionals is executed in our test suite (but both are covered by rake tasks)
+      # simplecov:disable -- only one side of these conditionals is executed in our test suite (but both are covered by rake tasks)
       f.apollo_external if f.respond_to?(:apollo_external)
-      # :nocov:
+      # simplecov:enable
     end
   end
 

config/schema/widgets.rb

@@ -164,9 +164,9 @@
       i.route_with "workspace_id"
       i.default_sort "created_at", :desc
       i.has_had_multiple_sources!
-      # :nocov: -- test suite only covers one side of the conditional
+      # simplecov:disable -- test suite only covers one side of the conditional
       i.warehouse_table "widget_records" if ENV["DEMONSTRATE_WAREHOUSE_APIS"]
-      # :nocov:
+      # simplecov:enable
     end
 
     t.derive_indexed_type_fields "WidgetCurrency", from_id: "cost.currency", route_with: "cost_currency_primary_continent", rollover_with: "cost_currency_introduced_on" do |derive|
@@ -236,9 +236,9 @@
 
     # Exclude this internal lookup table from the data warehouse.
     t.index "widget_workspaces" do |i|
-      # :nocov: -- test suite only covers one side of the conditional
+      # simplecov:disable -- test suite only covers one side of the conditional
       i.exclude_from_warehouse if ENV["DEMONSTRATE_WAREHOUSE_APIS"]
-      # :nocov:
+      # simplecov:enable
     end
   end
 
@@ -293,7 +293,7 @@
 
     # Define some Apollo-specific schema elements when we are defining the schema for Apollo.
     if schema.respond_to?(:target_apollo_federation_version)
-      # :nocov: -- this file is only exercised in a test running without `elasticgraph-apollo`.
+      # simplecov:disable -- this file is only exercised in a test running without `elasticgraph-apollo`.
       t.apollo_entity_ref_field "owner", "ComponentOwner", id_field_name_in_index: "owner_id"
       t.apollo_entity_ref_field "owners", "[ComponentOwner!]!", id_field_name_in_index: "owner_ids"
       t.apollo_entity_ref_paginated_collection_field "owners_paginated", "ComponentOwner", id_field_name_in_index: "owner_ids"
@@ -302,7 +302,7 @@
         t.field "token", "ID"
         t.apollo_key fields: "token", resolvable: false
       end
-      # :nocov:
+      # simplecov:enable
     end
 
     t.index "components" do |i|

config/site/Rakefile

@@ -579,7 +579,7 @@ module ElasticGraph
 
           Every executable line in example Ruby files must be executed during
           validation. If a line intentionally can't be covered, mark it with
-          `# :nocov:` (same syntax as SimpleCov).
+          `# simplecov:disable` / `# simplecov:enable` (same syntax as SimpleCov).
         EOS
       end
     end

config/site/examples/custom_resolver/validate.rb

@@ -17,11 +17,11 @@
 data = response.fetch("data")
 
 unless (3..36).cover?(data.fetch("roll6SidedDice")) && (3..60).cover?(data.fetch("roll10SidedDice"))
-  # :nocov: -- only executes on validation failure
+  # simplecov:disable -- only executes on validation failure
   raise <<~EOS
     Got an unexpected response:
 
     #{::JSON.pretty_generate(response)}
   EOS
-  # :nocov:
+  # simplecov:enable
 end

config/site/examples/music/Rakefile

@@ -17,7 +17,7 @@ ElasticGraph::Local::RakeTasks.new(
   tasks.schema_definition_extension_modules << ElasticGraph::JSONIngestion::SchemaDefinition::APIExtension
 end
 
-# :nocov: -- only used for manual live-server query validation, not during the build
+# simplecov:disable -- only used for manual live-server query validation, not during the build
 require "graphql"
 require "json"
 require "net/http"
@@ -214,4 +214,4 @@ namespace :example_queries do
     end
   end
 end
-# :nocov:
+# simplecov:enable

config/site/src/guides/guiding-principles.md

@@ -107,10 +107,10 @@ These are the "north stars" that guide ElasticGraph development. They guide the
   we avoid it.
 
 **Every line and branch of code must be covered by tests except where we intentionally opt-out.**
-: Our CI build enforces 100% test coverage except where we opt-out using [`:nocov:` comments](https://github.com/search?q=repo%3Ablock%2Felasticgraph%20nocov&type=code).
+: Our CI build enforces 100% test coverage except where we opt-out using [`simplecov:disable` comments](https://github.com/search?q=repo%3Ablock%2Felasticgraph%20%22simplecov%3Adisable%22&type=code).
   This high level of test coverage means that most of the time, if it passes the CI build, it works in production.
   It also makes it obvious at a glance which lines of code are uncovered by tests--if a line isn't wrapped with a
-  `:nocov:` comment then you know it's covered!
+  `simplecov:disable` comment then you know it's covered!
 
 **We aim to validate all snippets and code examples at this website.**
 : Our documentation is so much more useful if users can trust that the code snippets we provide always work.

elasticgraph-admin/spec/integration/elastic_graph/admin/index_definition_configurator/for_index_template_spec.rb

@@ -43,9 +43,9 @@ def put_index_definition_url(index_definition_name, _subresource = nil)
           alias_method :put_index_template_definition_url, :put_index_definition_url
 
           def make_datastore_calls_to_configure_index_def(index_name, subresource = nil)
-            # :nocov: -- when we are building against OpenSearch, one side of this conditional is not covered
+            # simplecov:disable -- when we are building against OpenSearch, one side of this conditional is not covered
             subresource = :mapping if subresource == :mappings && datastore_backend == :elasticsearch
-            # :nocov:
+            # simplecov:enable
 
             path_for_now_index = "/#{concrete_index_name_for_now(index_name)}"
             path_for_now_index += "/_#{subresource}" if subresource

elasticgraph-admin/spec/integration/elastic_graph/admin/index_definition_configurator/shared_examples.rb

@@ -20,9 +20,9 @@ def get_index_definition_configuration(index_definition_name)
 
         def put_index_definition_url(index_definition_name, subresource = nil)
           url = "/#{index_definition_name}"
-          # :nocov: -- when we are building against OpenSearch, one side of this conditional is not covered
+          # simplecov:disable -- when we are building against OpenSearch, one side of this conditional is not covered
           subresource = :mapping if subresource == :mappings && datastore_backend == :elasticsearch
-          # :nocov:
+          # simplecov:enable
           subresource ? "#{url}/_#{subresource}" : url
         end
 

elasticgraph-apollo/lib/elastic_graph/apollo/graphql/entities_field_resolver.rb

@@ -294,15 +294,15 @@ def adapter
             self
           end
 
-          # :nocov: -- these methods are not called on an adapter when `root_document_type?` returns `false`.
+          # simplecov:disable -- these methods are not called on an adapter when `root_document_type?` returns `false`.
           def customize_query(query, representations)
             nil
           end
 
           def index_search_hits(response)
             nil
           end
-          # :nocov:
+          # simplecov:enable
 
           def identify_matching_hit(indexed_search_hits, representation, context:, index:)
             representation.representation_hash