Memoize sourced_from update target resolution on Results

Author: ellisandrews-toast

elasticgraph-schema_definition/lib/elastic_graph/schema_definition/results.rb

@@ -55,6 +55,11 @@ def derived_indexing_type_names
           .to_set
       end
 
+      # @private
+      def sourced_update_targets_by_source_type_name
+        @sourced_update_targets_by_source_type_name ||= Indexing::SourcedFromUpdateTargetsResolver.new(state).resolve
+      end
+
       private
 
       def after_initialize
@@ -89,7 +94,9 @@ def build_dynamic_scripts
       end
 
       def build_runtime_metadata
-        sourced_update_targets_by_source_type_name = Indexing::SourcedFromUpdateTargetsResolver.new(state).resolve
+        # Resolve `sourced_from` update targets before touching `all_types` so that `sourced_from`
+        # validation errors take precedence over any errors raised while generating derived types.
+        sourced_update_targets_by_source_type_name = self.sourced_update_targets_by_source_type_name
 
         object_types_by_name = all_types
           .select { |t| t.respond_to?(:graphql_fields_by_name) }

elasticgraph-schema_definition/sig/elastic_graph/schema_definition/results.rbs

@@ -12,6 +12,7 @@ module ElasticGraph
       def datastore_config: () -> ::Hash[::String, untyped]
       def runtime_metadata: () -> SchemaArtifacts::RuntimeMetadata::Schema
       def derived_indexing_type_names: () -> ::Set[::String]
+      def sourced_update_targets_by_source_type_name: () -> ::Hash[::String, ::Array[SchemaArtifacts::RuntimeMetadata::UpdateTarget]]
 
       @graphql_schema_string: ::String?
       @datastore_config: ::Hash[::String, untyped]
@@ -20,6 +21,7 @@ module ElasticGraph
       @no_circular_dependencies: bool?
       @field_path_resolver: SchemaElements::FieldPath::Resolver?
       @derived_indexing_type_names: ::Set[::String]?
+      @sourced_update_targets_by_source_type_name: ::Hash[::String, ::Array[SchemaArtifacts::RuntimeMetadata::UpdateTarget]]?
 
       STATIC_SCRIPT_REPO: Scripting::FileSystemRepository