Cover external protobuf enum edges

Author: jwils

elasticgraph-proto_ingestion/spec/unit/elastic_graph/proto_ingestion/schema_definition/factory_extension_spec.rb

@@ -48,6 +48,31 @@ module SchemaDefinition
             end
           }.to raise_error(Errors::SchemaError, a_string_including("both map to the same proto type name `package_`"))
         end
+
+        it "detects proto type name collisions after enum configuration blocks run" do
+          proto_status = ::Data.define(:enums).new(enums: [])
+
+          expect {
+            define_proto_schema do |s|
+              s.enum_type "CurrentStatus" do |t|
+                t.value "ACTIVE"
+                t.external_proto_enum proto_status,
+                  proto: "myapp.types.Status",
+                  import: "myapp/types/status.proto"
+              end
+
+              s.enum_type "PreviousStatus" do |t|
+                t.value "ACTIVE"
+                t.external_proto_enum proto_status,
+                  proto: "myapp.types.Status",
+                  import: "myapp/types/status.proto"
+              end
+            end
+          }.to raise_error(Errors::SchemaError, a_string_including(
+            "Type names `CurrentStatus` and `PreviousStatus`",
+            "same proto type name `myapp.types.Status`"
+          ))
+        end
       end
     end
   end

elasticgraph-proto_ingestion/spec/unit/elastic_graph/proto_ingestion/schema_definition/schema_spec.rb

@@ -877,11 +877,21 @@ def self.enums
             end
           end
 
+          proto_status_c = ::Class.new do
+            def self.enums
+              [
+                ::Data.define(:name).new(name: :ACTIVE),
+                ::Data.define(:name).new(name: :INACTIVE)
+              ]
+            end
+          end
+
           results = define_proto_schema_results do |s|
             s.enum_type "Status" do |t|
               t.values "ACTIVE", "INACTIVE"
               t.external_proto_enum proto_status_a
               t.external_proto_enum proto_status_b
+              t.external_proto_enum proto_status_c
             end
 
             s.object_type "Account" do |t|
@@ -911,6 +921,7 @@ def self.enums
           proto = define_proto_schema do |s|
             s.enum_type "Status" do |t|
               t.values "ACTIVE", "INACTIVE"
+              expect(t.proto_name).to eq("Status")
               t.external_proto_enum proto_status,
                 proto: "myapp.types.Status",
                 import: "myapp/types/status.proto"