Skip to content

Commit ac64752

Browse files
committed
chore: add memory leak note for future reference
1 parent 765b80f commit ac64752

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

lib/modal-hooks.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,8 @@ export function useDialog<T extends string>(
1717
const ref = useRef<HTMLDialogElement | null>(null);
1818

1919
const modalEmitterRef = useRef(new ModalEmitter<T>());
20+
21+
// is this a memory leak? it adds a listener on every call
2022
const closeEvent = useCallback(
2123
() =>
2224
new Promise<T | ''>((resolve) => {
@@ -78,6 +80,8 @@ export function useModal<T extends string>(
7880
const [open, toggleOpen] = useToggle();
7981

8082
const modalEmitterRef = useRef(new ModalEmitter<T>());
83+
84+
// is this a memory leak? it adds a listener on every call
8185
const closeEvent = useCallback(
8286
() =>
8387
new Promise<T | ''>((resolve) => {

0 commit comments

Comments
 (0)