refactor: fromDate and fromEndDate to be number

Author: LeonardoVieira1630

apps/logic-system/src/interfaces/proposal.interface.ts

@@ -28,10 +28,10 @@ export interface ListProposalsOptions {
     status?: string | string[];
     /** Filter by DAO (passed as header, not query param) */
     daoId?: string;
-    /** Filter proposals after this date (timestamp in seconds as float) */
-    fromDate?: string;
-    /** Filter proposals by end timestamp (timestamp in seconds as float) */
-    fromEndDate?: string;
+    /** Filter proposals after this date (timestamp in seconds) */
+    fromDate?: number;
+    /** Filter proposals by end timestamp (timestamp in seconds) */
+    fromEndDate?: number;
     /** Order direction - asc or desc */
     orderDirection?: string;
 }

apps/logic-system/src/repositories/proposal.repository.ts

@@ -22,13 +22,11 @@ export class ProposalRepository implements ProposalDataSource {
 
     // Date filtering
     if (options?.fromDate) {
-      // Convert string timestamp to integer
-      variables.fromDate = parseInt(options.fromDate, 10);
+      variables.fromDate = options.fromDate;
     }
 
     if (options?.fromEndDate) {
-      // Convert string timestamp to integer
-      variables.fromEndDate = parseInt(options.fromEndDate, 10);
+      variables.fromEndDate = options.fromEndDate;
     }
 
     // Pagination

apps/logic-system/src/triggers/new-proposal-trigger.ts

@@ -22,7 +22,7 @@ export class NewProposalTrigger extends Trigger<ProposalOnChain, ListProposalsOp
     if (initialTimestamp) {
       this.timestampCursor = parseInt(initialTimestamp, 10);
     } else {
-      this.timestampCursor = Math.floor((Date.now() - 24 * 60 * 60 * 1000) / 1000);
+      this.timestampCursor = Math.floor((Date.now() - 24 * 60 * 60 * 1000) / 1000); // 24 hours ago
     }
   }
 
@@ -36,7 +36,7 @@ export class NewProposalTrigger extends Trigger<ProposalOnChain, ListProposalsOp
     if (timestamp) {
       this.timestampCursor = parseInt(timestamp, 10);
     } else {
-      this.timestampCursor = Math.floor((Date.now() - 24 * 60 * 60 * 1000) / 1000);
+      this.timestampCursor = Math.floor((Date.now() - 24 * 60 * 60 * 1000) / 1000); // 24 hours ago
     }
   }
 
@@ -66,9 +66,9 @@ export class NewProposalTrigger extends Trigger<ProposalOnChain, ListProposalsOp
     if (!options?.status) {
       throw new Error('Status is required in filter options');
     }
-    return await this.proposalRepository.listAll({ 
+    return await this.proposalRepository.listAll({
       status: options.status,
-      fromDate: this.timestampCursor.toString() 
+      fromDate: this.timestampCursor
     });
   }
 } 

apps/logic-system/src/triggers/proposal-finished-trigger.ts

@@ -22,7 +22,7 @@ export class ProposalFinishedTrigger extends Trigger<ProposalOnChain, void> {
     if (initialTimestamp) {
       this.endTimestampCursor = parseInt(initialTimestamp, 10);
     } else {
-      this.endTimestampCursor = Math.floor((Date.now() - 24 * 60 * 60 * 1000) / 1000);
+      this.endTimestampCursor = Math.floor((Date.now() - 24 * 60 * 60 * 1000) / 1000); // 24 hours ago
     }
   }
 
@@ -36,14 +36,14 @@ export class ProposalFinishedTrigger extends Trigger<ProposalOnChain, void> {
     if (timestamp) {
       this.endTimestampCursor = parseInt(timestamp, 10);
     } else {
-      this.endTimestampCursor = Math.floor((Date.now() - 24 * 60 * 60 * 1000) / 1000);
+      this.endTimestampCursor = Math.floor((Date.now() - 24 * 60 * 60 * 1000) / 1000); // 24 hours ago
     }
   }
 
   protected async fetchData(): Promise<ProposalOnChain[]> {
     return await this.proposalRepository.listAll({
       status: this.finishedStatuses,  // API accepts array
-      fromEndDate: this.endTimestampCursor.toString(),
+      fromEndDate: this.endTimestampCursor,
       orderDirection: 'desc',  // API orders by endTimestamp when using fromEndDate
       limit: 100
     });

apps/logic-system/src/triggers/voting-reminder-trigger.ts

@@ -47,7 +47,7 @@ export class VotingReminderTrigger extends Trigger<ProposalOnChain> {
     if (initialTimestamp) {
       this.timestampCursor = parseInt(initialTimestamp, 10);
     } else {
-      this.timestampCursor = Math.floor((Date.now() - 24 * 60 * 60 * 1000) / 1000);
+      this.timestampCursor = Math.floor((Date.now() - 24 * 60 * 60 * 1000) / 1000); // 24 hours ago
     }
   }
 
@@ -59,7 +59,7 @@ export class VotingReminderTrigger extends Trigger<ProposalOnChain> {
     if (timestamp) {
       this.timestampCursor = parseInt(timestamp, 10);
     } else {
-      this.timestampCursor = Math.floor((Date.now() - 24 * 60 * 60 * 1000) / 1000);
+      this.timestampCursor = Math.floor((Date.now() - 24 * 60 * 60 * 1000) / 1000); // 24 hours ago
     }
   }
 
@@ -179,9 +179,9 @@ export class VotingReminderTrigger extends Trigger<ProposalOnChain> {
    * Fetches active proposals from the repository
    */
   protected async fetchData(): Promise<ProposalOnChain[]> {
-    return await this.proposalRepository.listAll({ 
+    return await this.proposalRepository.listAll({
       status: 'ACTIVE',
-      fromDate: this.timestampCursor.toString()
+      fromDate: this.timestampCursor
     });
   }
 }

apps/logic-system/tests/new-proposal-trigger.test.ts

@@ -93,7 +93,7 @@ describe('NewProposalTrigger', () => {
       expect(mockProposalDataSource.listAll).toHaveBeenCalledTimes(1);
       expect(mockProposalDataSource.listAll).toHaveBeenCalledWith({ 
         status: 'ACTIVE',
-        fromDate: initialTimestamp.toString() 
+        fromDate: initialTimestamp 
       });
     });
 
@@ -107,7 +107,7 @@ describe('NewProposalTrigger', () => {
 
       expect(mockProposalDataSource.listAll).toHaveBeenCalledWith({ 
         status: 'ACTIVE',
-        fromDate: initialTimestamp.toString() 
+        fromDate: initialTimestamp 
       });
     });
 
@@ -119,7 +119,7 @@ describe('NewProposalTrigger', () => {
       expect(mockProposalDataSource.listAll).toHaveBeenCalledTimes(1);
       expect(mockProposalDataSource.listAll).toHaveBeenCalledWith({ 
         status: 'ACTIVE',
-        fromDate: initialTimestamp.toString() 
+        fromDate: initialTimestamp 
       });
 
       mockProposalDataSource.listAll.mockClear();

apps/logic-system/tests/proposal-finished-trigger.test.ts

@@ -39,7 +39,7 @@ describe('ProposalFinishedTrigger', () => {
 
       expect(mockProposalRepository.listAll).toHaveBeenCalledWith({
         status: ['EXECUTED', 'DEFEATED', 'SUCCEEDED', 'EXPIRED', 'CANCELED'],
-        fromEndDate: initialTimestamp.toString(),
+        fromEndDate: initialTimestamp,
         orderDirection: 'desc',
         limit: 100
       });
@@ -203,7 +203,7 @@ describe('ProposalFinishedTrigger', () => {
         // This ensures A is not fetched again, avoiding duplicates
         expect(mockProposalRepository.listAll).toHaveBeenLastCalledWith({
           status: ['EXECUTED', 'DEFEATED', 'SUCCEEDED', 'EXPIRED', 'CANCELED'],
-          fromEndDate: '2001',  // A's endTimestamp + 1 converted to string for repository
+          fromEndDate: 2001,  // A's endTimestamp + 1
           orderDirection: 'desc',
           limit: 100
         });

apps/logic-system/tests/voting-reminder-trigger.test.ts

@@ -200,7 +200,7 @@ describe('VotingReminderTrigger', () => {
       // Should include fromDate filter with timestampCursor
       expect(mockProposalRepository.listAll).toHaveBeenCalledWith({
         status: 'ACTIVE',
-        fromDate: expect.any(String)
+        fromDate: expect.any(Number)
       });
       expect(result).toEqual(proposals);
     });