fix: use conductor values for Common App form step checkpoints (#5504)

* feat: use conductor values for form step checkpoints

* test: rework redirection tests to use conductor

* test: fix inconsistent setups

Author: jaredcwhite

sites/public/__tests__/pages/applications/review/redirection.test.tsx

@@ -13,6 +13,8 @@ window.scrollTo = jest.fn()
 
 const server = setupServer()
 
+const mockApplication = JSON.parse(JSON.stringify(blankApplication))
+
 beforeAll(() => {
   server.listen()
 })
@@ -31,12 +33,12 @@ describe("applications pages", () => {
   describe("back button to ada step", () => {
     it("no listing available should redirect to listings page", async () => {
       const { pushMock } = mockNextRouter()
-      const conductor = new ApplicationConductor({}, {})
+      const conductor = new ApplicationConductor(mockApplication, null)
       render(
         <AppSubmissionContext.Provider
           value={{
             conductor: conductor,
-            application: JSON.parse(JSON.stringify(blankApplication)),
+            application: mockApplication,
             listing: null,
             syncApplication: () => {
               return
@@ -57,12 +59,12 @@ describe("applications pages", () => {
 
     it("listing available should not redirect to listings page", async () => {
       const { pushMock } = mockNextRouter()
-      const conductor = new ApplicationConductor({}, {})
+      const conductor = new ApplicationConductor(mockApplication, {})
       render(
         <AppSubmissionContext.Provider
           value={{
             conductor: conductor,
-            application: JSON.parse(JSON.stringify(blankApplication)),
+            application: mockApplication,
             listing: {} as Listing,
             syncApplication: () => {
               return
@@ -85,12 +87,12 @@ describe("applications pages", () => {
   describe("back button to summary step", () => {
     it("no listing available should redirect to listings page", async () => {
       const { pushMock } = mockNextRouter()
-      const conductor = new ApplicationConductor({}, {})
+      const conductor = new ApplicationConductor(mockApplication, null)
       render(
         <AppSubmissionContext.Provider
           value={{
             conductor: conductor,
-            application: JSON.parse(JSON.stringify(blankApplication)),
+            application: mockApplication,
             listing: null,
             syncApplication: () => {
               return
@@ -111,12 +113,12 @@ describe("applications pages", () => {
 
     it("listing available should not redirect to listings page", async () => {
       const { pushMock } = mockNextRouter()
-      const conductor = new ApplicationConductor({}, {})
+      const conductor = new ApplicationConductor(mockApplication, {})
       render(
         <AppSubmissionContext.Provider
           value={{
             conductor: conductor,
-            application: JSON.parse(JSON.stringify(blankApplication)),
+            application: mockApplication,
             listing: {} as Listing,
             syncApplication: () => {
               return

sites/public/src/lib/hooks.ts

@@ -84,14 +84,11 @@ export const useRedirectToPrevPage = (defaultPath = "/") => {
  * @param bypassCheckpoint true if it should bypass checking that listing & application is in progress
  * @returns
  */
-export const useFormConductor = (stepName: string, bypassCheckpoint?: boolean) => {
+export const useFormConductor = (stepName: string) => {
   useRequireLoggedInUser("/", !process.env.showMandatedAccounts)
   const context = useContext(AppSubmissionContext)
-  if (!bypassCheckpoint) {
-    // eslint-disable-next-line react-hooks/rules-of-hooks
-    useAuthenticApplicationCheckpoint(context.listing, context.application)
-  }
   const conductor = context.conductor
+  useAuthenticApplicationCheckpoint(conductor.listing, conductor.application)
 
   conductor.stepTo(stepName)
 

sites/public/src/pages/applications/start/autofill.tsx

@@ -27,7 +27,7 @@ import { CardSection } from "@bloom-housing/ui-seeds/src/blocks/Card"
 
 const Autofill = () => {
   const router = useRouter()
-  const context = useFormConductor("autofill", true)
+  const context = useFormConductor("autofill")
   const { conductor, application, listing } = context
   const { initialStateLoaded, profile, applicationsService } = useContext(AuthContext)
   const [submitted, setSubmitted] = useState(false)

sites/public/src/pages/applications/start/what-to-expect.tsx

@@ -16,7 +16,7 @@ import { isUnitGroupAppBase, isUnitGroupAppWaitlist } from "../../../lib/helpers
 
 const ApplicationWhatToExpect = () => {
   const { profile } = useContext(AuthContext)
-  const { conductor, listing } = useFormConductor("whatToExpect", true)
+  const { conductor, listing } = useFormConductor("whatToExpect")
   const router = useRouter()
 
   const { handleSubmit } = useForm()