refactor: pr review

Author: emilyjablonski

sites/partners/src/components/listings/PaperListingForm/index.tsx

@@ -64,7 +64,6 @@ import ListingApprovalDialog from "./dialogs/ListingApprovalDialog"
 import SaveBeforeExitDialog from "./dialogs/SaveBeforeExitDialog"
 
 import * as styles from "./ListingForm.module.scss"
-
 const CHARACTER_LIMIT = 1000
 
 type ListingFormProps = {
@@ -187,11 +186,11 @@ const ListingForm = ({
 
   useEffect(() => {
     if (profile) {
-      setSelectedJurisdictionData(
-        profile?.jurisdictions?.find((juris) => jurisdictionId === juris.id)
-      )
+      const jurisdiction = profile?.jurisdictions?.find((juris) => jurisdictionId === juris.id)
+      if (!jurisdiction) void router.replace("/")
+      setSelectedJurisdictionData(jurisdiction)
     }
-  }, [profile, jurisdictionId])
+  }, [profile, jurisdictionId, router])
 
   useEffect(() => {
     if (selectedJurisdictionData && !listing) {

sites/partners/src/components/listings/PaperListingForm/sections/AdditionalFees.tsx

@@ -15,8 +15,8 @@ import { GridRow } from "@bloom-housing/ui-seeds/src/layout/Grid"
 import { ListingContext } from "../../ListingContext"
 
 type AdditionalFeesProps = {
-  enableNonRegulatedListings: boolean
-  enableUtilitiesIncluded: boolean
+  enableNonRegulatedListings?: boolean
+  enableUtilitiesIncluded?: boolean
   existingUtilities: ListingUtilities
   requiredFields: string[]
 }

sites/partners/src/components/listings/PaperListingForm/sections/ApplicationDates.tsx

@@ -25,8 +25,8 @@ import { fieldMessage, fieldHasError, getLabel } from "../../../../lib/helpers"
 import styles from "../ListingForm.module.scss"
 
 type ApplicationDatesProps = {
-  enableMarketingStatus: boolean
-  enableMarketingStatusMonths: boolean
+  enableMarketingStatus?: boolean
+  enableMarketingStatusMonths?: boolean
   openHouseEvents: TempEvent[]
   requiredFields: string[]
   listing?: FormListing

sites/partners/src/components/listings/PaperListingForm/sections/BuildingDetails.tsx

@@ -45,8 +45,8 @@ interface MapboxApiResponse {
 
 type BuildingDetailsProps = {
   customMapPositionChosen?: boolean
-  enableNonRegulatedListings: boolean
-  enableRegions: boolean
+  enableNonRegulatedListings?: boolean
+  enableRegions?: boolean
   latLong?: LatitudeLongitude
   listing?: FormListing
   requiredFields: string[]

sites/partners/src/components/listings/PaperListingForm/sections/BuildingFeatures.tsx

@@ -9,7 +9,7 @@ import { defaultFieldProps } from "../../../../lib/helpers"
 import styles from "../ListingForm.module.scss"
 
 type BuildingFeaturesProps = {
-  enableAccessibilityFeatures: boolean
+  enableAccessibilityFeatures?: boolean
   existingFeatures: ListingFeatures
   requiredFields: string[]
 }

sites/partners/src/components/listings/PaperListingForm/sections/CommunityType.tsx

@@ -22,7 +22,7 @@ import styles from "../ListingForm.module.scss"
 type CommunityTypeProps = {
   listing?: FormListing
   requiredFields: string[]
-  swapCommunityTypeWithPrograms: boolean
+  swapCommunityTypeWithPrograms?: boolean
 }
 
 const CommunityType = ({

sites/partners/src/components/listings/PaperListingForm/sections/LeasingAgent.tsx

@@ -13,7 +13,7 @@ import {
 import SectionWithGrid from "../../../shared/SectionWithGrid"
 
 type LeasingAgentProps = {
-  enableCompanyWebsite: boolean
+  enableCompanyWebsite?: boolean
   requiredFields: string[]
 }
 

sites/partners/src/components/listings/PaperListingForm/sections/ListingIntro.tsx

@@ -10,9 +10,9 @@ import { defaultFieldProps, fieldHasError, fieldMessage } from "../../../../lib/
 import SectionWithGrid from "../../../shared/SectionWithGrid"
 
 interface ListingIntroProps {
-  enableHousingDeveloperOwner: boolean
-  enableListingFileNumber: boolean
-  enableNonRegulatedListings: boolean
+  enableHousingDeveloperOwner?: boolean
+  enableListingFileNumber?: boolean
+  enableNonRegulatedListings?: boolean
   jurisdictionName: string
   listingId: string
   requiredFields: string[]

sites/partners/src/components/listings/PaperListingForm/sections/ListingVerification.tsx

@@ -4,7 +4,7 @@ import { useFormContext } from "react-hook-form"
 import styles from "../ListingForm.module.scss"
 
 type ListingVerificationProps = {
-  enableIsVerified: boolean
+  enableIsVerified?: boolean
 }
 
 const ListingVerification = (props: ListingVerificationProps) => {

sites/partners/src/components/listings/PaperListingForm/sections/NeighborhoodAmenities.tsx

@@ -19,8 +19,8 @@ enum NeighborhoodAmenityDistanceEnum {
 }
 
 type NeighborhoodAmenitiesProps = {
-  enableNeighborhoodAmenities: boolean
-  enableNeighborhoodAmenitiesDropdown: boolean
+  enableNeighborhoodAmenities?: boolean
+  enableNeighborhoodAmenitiesDropdown?: boolean
   visibleNeighborhoodAmenities: NeighborhoodAmenitiesEnum[]
 }