Cleanup bdl (#4814)

* Cleanup bdlma

* Cleanup bdlmt

* Cleanup bdlcc

* Cleanup bdlc

groups/bdl/bdlc/bdlc_hashtable.cpp

@@ -1,12 +1,4 @@
 // bdlc_hashtable.cpp                                                 -*-C++-*-
-
-// ----------------------------------------------------------------------------
-//                                   NOTICE
-//
-// This component is not up to date with current BDE coding standards, and
-// should not be used as an example for new development.
-// ----------------------------------------------------------------------------
-
 #include <bdlc_hashtable.h>
 
 #include <bsls_ident.h>

groups/bdl/bdlc/bdlc_hashtable.h

@@ -1,12 +1,4 @@
 // bdlc_hashtable.h                                                   -*-C++-*-
-
-// ----------------------------------------------------------------------------
-//                                   NOTICE
-//
-// This component is not up to date with current BDE coding standards, and
-// should not be used as an example for new development.
-// ----------------------------------------------------------------------------
-
 #ifndef INCLUDED_BDLC_HASHTABLE
 #define INCLUDED_BDLC_HASHTABLE
 
@@ -495,6 +487,10 @@ BSLS_IDENT("$Id: $")
 //
 ///Usage
 ///-----
+// This section illustrates intended use of this component.
+//
+///Example 1: Basic Usage
+/// - - - - - - - - - - -
 // The following snippets of code illustrate the usage of this component.
 // Suppose we wanted to store a table of 'int' keys with 'double' values.  We
 // will use a capacity hint of 10, default traits, and default hash functors

groups/bdl/bdlc/bdlc_hashtable.t.cpp

@@ -1,13 +1,4 @@
 // bdlc_hashtable.t.cpp                                               -*-C++-*-
-
-// ----------------------------------------------------------------------------
-//                                   NOTICE
-//
-// This component is not up to date with current BDE coding standards, and
-// should not be used as an example for new development.
-// ----------------------------------------------------------------------------
-
-
 #include <bdlc_hashtable.h>
 
 #include <bslim_testutil.h>

groups/bdl/bdlc/bdlc_indexclerk.cpp

@@ -1,12 +1,4 @@
 // bdlc_indexclerk.cpp                                                -*-C++-*-
-
-// ----------------------------------------------------------------------------
-//                                   NOTICE
-//
-// This component is not up to date with current BDE coding standards, and
-// should not be used as an example for new development.
-// ----------------------------------------------------------------------------
-
 #include <bdlc_indexclerk.h>
 
 #include <bsls_ident.h>

groups/bdl/bdlc/bdlc_indexclerk.h

@@ -1,12 +1,4 @@
 // bdlc_indexclerk.h                                                  -*-C++-*-
-
-// ----------------------------------------------------------------------------
-//                                   NOTICE
-//
-// This component is not up to date with current BDE coding standards, and
-// should not be used as an example for new development.
-// ----------------------------------------------------------------------------
-
 #ifndef INCLUDED_BDLC_INDEXCLERK
 #define INCLUDED_BDLC_INDEXCLERK
 
@@ -56,6 +48,10 @@ BSLS_IDENT("$Id: $")
 //
 ///Usage
 ///-----
+// This section illustrates intended use of this component.
+//
+///Example 1: Basic Usage
+/// - - - - - - - - - - -
 // A 'bdlc::IndexClerk' is commonly used in conjunction with an array to enable
 // machine-address-independent referencing.  Rather than dynamically allocating
 // an object and holding its address, the object is stored in the array at the

groups/bdl/bdlc/bdlc_indexclerk.t.cpp

@@ -1,22 +1,8 @@
 // bdlc_indexclerk.t.cpp                                              -*-C++-*-
-
-// ----------------------------------------------------------------------------
-//                                   NOTICE
-//
-// This component is not up to date with current BDE coding standards, and
-// should not be used as an example for new development.
-// ----------------------------------------------------------------------------
-
-
 #include <bdlc_indexclerk.h>
 
 #include <bslim_testutil.h>
 
-#include <bslx_outstreamfunctions.h>            // for testing only
-#include <bslx_testoutstream.h>                 // for testing only
-#include <bslx_testinstream.h>                  // for testing only
-#include <bslx_testinstreamexception.h>         // for testing only
-
 #include <bslma_default.h>                      // for testing only
 #include <bslma_defaultallocatorguard.h>        // for testing only
 #include <bslma_testallocator.h>                // for testing only
@@ -27,6 +13,11 @@
 #include <bsls_review.h>
 #include <bsls_types.h>
 
+#include <bslx_outstreamfunctions.h>            // for testing only
+#include <bslx_testinstream.h>                  // for testing only
+#include <bslx_testinstreamexception.h>         // for testing only
+#include <bslx_testoutstream.h>                 // for testing only
+
 #include <bsl_iostream.h>
 #include <bsl_sstream.h>
 #include <bsl_vector.h>
@@ -36,7 +27,7 @@
 #include <bsl_cstring.h>     // strcmp
 
 using namespace BloombergLP;
-using namespace bsl;  // automatically added by script
+using namespace bsl;
 
 // ============================================================================
 //                                TEST PLAN

groups/bdl/bdlc/bdlc_queue.cpp

@@ -1,12 +1,4 @@
 // bdlc_queue.cpp                                                     -*-C++-*-
-
-// ----------------------------------------------------------------------------
-//                                   NOTICE
-//
-// This component is not up to date with current BDE coding standards, and
-// should not be used as an example for new development.
-// ----------------------------------------------------------------------------
-
 #include <bdlc_queue.h>
 
 #include <bsls_ident.h>

groups/bdl/bdlc/bdlc_queue.h

@@ -86,6 +86,10 @@ BSLS_IDENT("$Id: $")
 //
 ///Usage
 ///-----
+// This section illustrates intended use of this component.
+//
+///Example 1: Basic Usage
+/// - - - - - - - - - - -
 // The following snippets of code illustrate how to create and use a queue.
 // First, create an empty 'bdlc::Queue<double>' 'q' and populate it with two
 // elements 'E1' and 'E2'.

groups/bdl/bdlc/bdlc_queue.t.cpp

@@ -1,19 +1,10 @@
 // bdlc_queue.t.cpp                                                   -*-C++-*-
-
-// ----------------------------------------------------------------------------
-//                                   NOTICE
-//
-// This component is not up to date with current BDE coding standards, and
-// should not be used as an example for new development.
-// ----------------------------------------------------------------------------
-
-
 #include <bdlc_queue.h>
 
-#include <bslim_testutil.h>
-
 #include <bdlma_bufferedsequentialallocator.h>
 
+#include <bslim_testutil.h>
+
 #include <bslma_testallocator.h>                // for testing only
 #include <bslma_testallocatorexception.h>       // for testing only
 
@@ -23,18 +14,17 @@
 #include <bslx_testinstreamexception.h>         // for testing only
 #include <bslx_testoutstream.h>                 // for testing only
 
+#include <bsl_cstdlib.h>     // atoi()
+#include <bsl_cstring.h>     // strlen(), memset(), memcpy(), memcmp()
 #include <bsl_iostream.h>
 #include <bsl_new.h>         // placement syntax
 #include <bsl_sstream.h>
 
-#include <bsl_cstdlib.h>     // atoi()
-#include <bsl_cstring.h>     // strlen(), memset(), memcpy(), memcmp()
-
 #undef SS  // Solaris 5.10/x86 sys/regset.h via stdlib.h
 #undef ES
 
 using namespace BloombergLP;
-using namespace bsl;  // automatically added by script
+using namespace bsl;
 
 // ============================================================================
 //                             TEST PLAN

groups/bdl/bdlcc/bdlcc_fixedqueue.cpp

@@ -1,19 +1,11 @@
 // bdlcc_fixedqueue.cpp                                               -*-C++-*-
-
-// ----------------------------------------------------------------------------
-//                                   NOTICE
-//
-// This component is not up to date with current BDE coding standards, and
-// should not be used as an example for new development.
-// ----------------------------------------------------------------------------
-
-
 #include <bdlcc_fixedqueue.h>
 
 #include <bsls_ident.h>
 BSLS_IDENT_RCSID(bdlcc_fixedqueue_cpp,"$Id$$CSID$")
 
 namespace BloombergLP {
+namespace bdlcc {
 
 ///Implementation Note
 ///===================
@@ -86,6 +78,7 @@ namespace BloombergLP {
 // 'bdlcc::FixedQueue' object holds a 'bdlcc::AtomicRinBufferIndexManager' that
 // it uses to manage the state of the elements in 'd_elements'.
 
+}  // close pacakge namespace
 }  // close enterprise namespace
 
 // ----------------------------------------------------------------------------

groups/bdl/bdlcc/bdlcc_fixedqueue.h

@@ -1,12 +1,4 @@
 // bdlcc_fixedqueue.h                                                 -*-C++-*-
-
-// ----------------------------------------------------------------------------
-//                                   NOTICE
-//
-// This component is not up to date with current BDE coding standards, and
-// should not be used as an example for new development.
-// ----------------------------------------------------------------------------
-
 #ifndef INCLUDED_BDLCC_FIXEDQUEUE
 #define INCLUDED_BDLCC_FIXEDQUEUE
 
@@ -197,11 +189,6 @@ BSLS_IDENT("$Id: $")
 
 #include <bdlcc_fixedqueueindexmanager.h>
 
-#include <bslmt_semaphore.h>
-#include <bslmt_threadutil.h>
-
-#include <bsls_atomic.h>
-
 #include <bslalg_scalarprimitives.h>
 
 #include <bslma_default.h>
@@ -211,9 +198,13 @@ BSLS_IDENT("$Id: $")
 #include <bslmf_movableref.h>
 #include <bslmf_nestedtraitdeclaration.h>
 
+#include <bslmt_semaphore.h>
+#include <bslmt_threadutil.h>
+
 #include <bsls_assert.h>
-#include <bsls_platform.h>
+#include <bsls_atomic.h>
 #include <bsls_performancehint.h>
+#include <bsls_platform.h>
 #include <bsls_types.h>
 
 #include <bsl_algorithm.h>
@@ -943,8 +934,8 @@ void FixedQueue_PushProctor<VALUE>::release()
 {
     d_parent_p = 0;
 }
-}  // close package namespace
 
+}  // close package namespace
 }  // close enterprise namespace
 
 #endif

groups/bdl/bdlcc/bdlcc_fixedqueue.t.cpp

@@ -1,44 +1,37 @@
 // bdlcc_fixedqueue.t.cpp                                             -*-C++-*-
-
-// ----------------------------------------------------------------------------
-//                                   NOTICE
-//
-// This component is not up to date with current BDE coding standards, and
-// should not be used as an example for new development.
-// ----------------------------------------------------------------------------
-
 #include <bdlcc_fixedqueue.h>
 
 #include <bdlcc_queue.h>
 #include <bdlcc_skiplist.h>
 
+#include <bdlb_random.h>
+
+#include <bdlf_bind.h>
+
 #include <bslim_testutil.h>
 
+#include <bslma_defaultallocatorguard.h>
+#include <bslma_testallocator.h>
+#include <bslma_testallocatormonitor.h>
+
 #include <bslmt_barrier.h>
 #include <bslmt_condition.h>
 #include <bslmt_configuration.h>
 #include <bslmt_lockguard.h>
 #include <bslmt_mutex.h>
 #include <bslmt_qlock.h>
 #include <bslmt_recursivemutex.h>
-#include <bslma_testallocator.h>
-#include <bslmt_timedsemaphore.h>
 #include <bslmt_threadattributes.h>
 #include <bslmt_threadgroup.h>
 #include <bslmt_threadutil.h>
+#include <bslmt_timedsemaphore.h>
 #include <bslmt_turnstile.h>
-#include <bsls_systemtime.h>
-
-#include <bdlf_bind.h>
-#include <bdlb_random.h>
-
-#include <bslma_defaultallocatorguard.h>
-#include <bslma_testallocatormonitor.h>
 
 #include <bsls_atomic.h>
 #include <bsls_compilerfeatures.h>
 #include <bsls_platform.h>
 #include <bsls_stopwatch.h>
+#include <bsls_systemtime.h>
 #include <bsls_timeutil.h>
 #include <bsls_types.h>
 
@@ -62,7 +55,7 @@
 #endif
 
 using namespace BloombergLP;
-using namespace bsl;  // automatically added by script
+using namespace bsl;
 
 // ============================================================================
 //                      STANDARD BDE ASSERT TEST MACRO

groups/bdl/bdlcc/bdlcc_fixedqueueindexmanager.cpp

@@ -1,24 +1,16 @@
 // bdlcc_fixedqueueindexmanager.cpp                                   -*-C++-*-
-
-// ----------------------------------------------------------------------------
-//                                   NOTICE
-//
-// This component is not up to date with current BDE coding standards, and
-// should not be used as an example for new development.
-// ----------------------------------------------------------------------------
-
 #include <bdlcc_fixedqueueindexmanager.h>
 
 #include <bsls_ident.h>
 BSLS_IDENT_RCSID(bdlcc_fixedqueueindexmanager_cpp,"$Id$ $CSID$")
 
-#include <bslmt_threadutil.h>
-
 #include <bslalg_arraydestructionprimitives.h>
 #include <bslalg_arrayprimitives.h>
 
 #include <bslma_default.h>
 
+#include <bslmt_threadutil.h>
+
 #include <bsls_assert.h>
 
 #include <bsl_algorithm.h>

groups/bdl/bdlcc/bdlcc_fixedqueueindexmanager.h

@@ -1,12 +1,4 @@
 // bdlcc_fixedqueueindexmanager.h                                     -*-C++-*-
-
-// ----------------------------------------------------------------------------
-//                                   NOTICE
-//
-// This component is not up to date with current BDE coding standards, and
-// should not be used as an example for new development.
-// ----------------------------------------------------------------------------
-
 #ifndef INCLUDED_BDLCC_FIXEDQUEUEINDEXMANAGER
 #define INCLUDED_BDLCC_FIXEDQUEUEINDEXMANAGER