Replace !"" with 0!="" in ASSERTs (#4793)

* Replace !"" with 0!="" in ASSERTs * Missed some assert cases * Fix 0!= into 0== (spotted by osubbotin)
bloomberg · Jun 14, 2024 · 3409f8f · 3409f8f
1 parent 0098f67
commit 3409f8f
Show file tree

Hide file tree

Showing 53 changed files with 528 additions and 528 deletions.
diff --git a/groups/bal/balb/balb_pipecontrolchannel.t.cpp b/groups/bal/balb/balb_pipecontrolchannel.t.cpp
@@ -526,7 +526,7 @@ void testCase14(const string& pipeName)
 
     const int rc = server.start(pipeName);
     if (0 != rc) {
-        ASSERT(!"Failed to start pipe control channel");
+        ASSERT(0 == "Failed to start pipe control channel");
         return;                                                       // RETURN
     }
 
@@ -545,7 +545,7 @@ void testCase14(const string& pipeName)
 
     DWORD dummy;
     if (!WriteFile(pipe, "EXIT\n", 5, &dummy, 0)) {
-        ASSERT(!"Failed to send EXIT message");
+        ASSERT(0 == "Failed to send EXIT message");
         return;                                                       // RETURN
     }
 
@@ -563,18 +563,18 @@ void testCase14(const string& pipeName)
 
     const int rc = server.start(pipeName);
     if (0 != rc) {
-        ASSERT(!"Failed to start pipe control channel");
+        ASSERT(0 == "Failed to start pipe control channel");
         return;                                                       // RETURN
     }
 
     const int pipe = open(pipeName.c_str(), O_WRONLY);
     if (pipe < 0) {
-        ASSERT(!"Failed to open the pipe for writing");
+        ASSERT(0 == "Failed to open the pipe for writing");
         return;                                                       // RETURN
     }
 
     if (write(pipe, "EXIT\n", 5) <= static_cast<ssize_t>(0)) {
-        ASSERT(!"Failed to send EXIT message");
+        ASSERT(0 == "Failed to send EXIT message");
         return;                                                       // RETURN
     }
 
@@ -1397,7 +1397,7 @@ int main(int argc, char *argv[])
         _exit(1);
 #endif
 
-        ASSERT(!"unreachable");
+        ASSERT(0 == "unreachable");
       } break;
       case 8: {
         // --------------------------------------------------------------------

diff --git a/groups/bal/balb/balb_pipetaskmanager.t.cpp b/groups/bal/balb/balb_pipetaskmanager.t.cpp
@@ -183,7 +183,7 @@ void noop(const bsl::string_view& , bsl::istream& )
     // Fail the test.  Note that in the absence of errors this callback is
     // never invoked.
 {
-    ASSERT(!"called");
+    ASSERT(0 == "called");
 }
 
 void rc1cb(const bsl::string_view& , bsl::istream&, int *rc)
@@ -603,7 +603,7 @@ int main(int argc, char *argv[])
                 objPtr = new (fa) Obj(sharedCm, objAllocatorPtr);       // TEST
               } break;
               default: {
-                BSLS_ASSERT_OPT(!"Bad allocator config.");
+                BSLS_ASSERT_OPT(0 == "Bad allocator config.");
               } break;
             }
             ASSERT(objPtr);
@@ -1072,7 +1072,7 @@ int main(int argc, char *argv[])
                 objPtr = new (fa) Obj(objAllocatorPtr);
               } break;
               default: {
-                BSLS_ASSERT_OPT(!"Bad allocator config.");
+                BSLS_ASSERT_OPT(0 == "Bad allocator config.");
               } break;
             }
 

diff --git a/groups/bal/baljsn/baljsn_decoder.t.cpp b/groups/bal/baljsn/baljsn_decoder.t.cpp
@@ -34346,7 +34346,7 @@ const char *Colors::toString(Colors::Value value)
       } break;
     }
 
-    BSLS_ASSERT(!"invalid enumerator");
+    BSLS_ASSERT(0 == "invalid enumerator");
     return 0;
 }
 
@@ -35573,7 +35573,7 @@ const char *Color::toString(Color::Value value)
       } break;
     }
 
-    BSLS_ASSERT(!"invalid enumerator");
+    BSLS_ASSERT(0 == "invalid enumerator");
     return 0;
 }
 

diff --git a/groups/bal/baljsn/baljsn_decoderoptionsutil.cpp b/groups/bal/baljsn/baljsn_decoderoptionsutil.cpp
@@ -31,7 +31,7 @@ void DecoderOptionsUtil::setMode(DecoderOptions *options, Mode mode)
         options->setAllowUnescapedControlCharacters(false);
       } break;
       default: {
-        BSLS_ASSERT_OPT(!"reachable");
+        BSLS_ASSERT_OPT(0 == "reachable");
       } break;
     }
 }

diff --git a/groups/bal/ball/ball_attributecollectorregistry.t.cpp b/groups/bal/ball/ball_attributecollectorregistry.t.cpp
@@ -713,7 +713,7 @@ int main(int argc, char *argv[])
                 objPtr = new (fa) Obj(alloc);
               } break;
               default: {
-                BSLS_ASSERT_OPT(!"Bad allocator config.");
+                BSLS_ASSERT_OPT(0 == "Bad allocator config.");
               } break;
             }
 

diff --git a/groups/bal/ball/ball_loggermanager.t.cpp b/groups/bal/ball/ball_loggermanager.t.cpp
@@ -1657,7 +1657,7 @@ class TestObserverVisitor {
     void operator()(bsl::shared_ptr<ball::Observer>&,
                     const bsl::string_view&) const
     {
-        ASSERT(!"This overload must not be ever called.");
+        ASSERT(0 == "This overload must not be ever called.");
     }
 };
 

diff --git a/groups/bal/ball/ball_record.t.cpp b/groups/bal/ball/ball_record.t.cpp
@@ -615,7 +615,7 @@ int main(int argc, char *argv[])
                             objPtr = new (fa) Obj(Z, objAllocatorPtr);
                           } break;
                           default: {
-                            BSLS_ASSERT_OPT(!"Bad allocator config.");
+                            BSLS_ASSERT_OPT(0 == "Bad allocator config.");
                           } break;
                         }
                         ASSERTV(CONFIG, sizeof(Obj) == fa.numBytesInUse());
@@ -987,7 +987,7 @@ int main(int argc, char *argv[])
                 objPtr = new (fa) Obj(objAllocatorPtr);
               } break;
               default: {
-                BSLS_ASSERT_OPT(!"Bad allocator config.");
+                BSLS_ASSERT_OPT(0 == "Bad allocator config.");
               } break;
             }
 

diff --git a/groups/bal/baltzo/baltzo_localdatetime.t.cpp b/groups/bal/baltzo/baltzo_localdatetime.t.cpp
@@ -973,7 +973,7 @@ int main(int argc, char *argv[])
                                               alloc);
                       } break;
                       default: {
-                        BSLS_ASSERT_OPT(!"Bad allocator config.");
+                        BSLS_ASSERT_OPT(0 == "Bad allocator config.");
                       } break;
                     }
                     ASSERTV(LINE, CONFIG, 2*sizeof(Obj) == fa.numBytesInUse());

diff --git a/groups/bal/baltzo/baltzo_localtimedescriptor.t.cpp b/groups/bal/baltzo/baltzo_localtimedescriptor.t.cpp
@@ -1771,7 +1771,7 @@ int main(int argc, char *argv[])
                                               alloc);
                       } break;
                       default: {
-                        BSLS_ASSERT_OPT(!"Bad allocator config.");
+                        BSLS_ASSERT_OPT(0 == "Bad allocator config.");
                       } break;
                     }
                     ASSERTV(LINE, CONFIG, 2*sizeof(Obj) == fa.numBytesInUse());
@@ -2130,7 +2130,7 @@ int main(int argc, char *argv[])
                         objPtr = new (fa) Obj(Z, alloc);
                       } break;
                       default: {
-                        BSLS_ASSERT_OPT(!"Bad allocator config.");
+                        BSLS_ASSERT_OPT(0 == "Bad allocator config.");
                       } break;
                     }
                     ASSERTV(LINE, CONFIG, sizeof(Obj) == fa.numBytesInUse());
@@ -3223,7 +3223,7 @@ int main(int argc, char *argv[])
                         objPtr = new (fa) Obj(OFFSET, FLAG, DESC, alloc);
                       } break;
                       default: {
-                        BSLS_ASSERT_OPT(!"Bad allocator config.");
+                        BSLS_ASSERT_OPT(0 == "Bad allocator config.");
                       } break;
                     }
                     ASSERTV(LINE, CONFIG,
@@ -3568,7 +3568,7 @@ int main(int argc, char *argv[])
                 objPtr = new (fa) Obj(alloc);
               } break;
               default: {
-                BSLS_ASSERT_OPT(!"Bad allocator config.");
+                BSLS_ASSERT_OPT(0 == "Bad allocator config.");
               } break;
             }
 

diff --git a/groups/bal/baltzo/baltzo_windowstimezoneutil.t.cpp b/groups/bal/baltzo/baltzo_windowstimezoneutil.t.cpp
@@ -898,7 +898,7 @@ static int loadTimezoneObsoleteFlag(bool        *isTimezoneObsoleteFlag,
                                    &zoneSubKey);
 
     if (res != ERROR_SUCCESS) {
-        ASSERT(!"error opening registry for some specific time zone\n");
+        ASSERT(0 == "error opening registry for some specific time zone\n");
         P(timezone);
         return -1;                                                    // RETURN
     }
@@ -912,7 +912,7 @@ static int loadTimezoneObsoleteFlag(bool        *isTimezoneObsoleteFlag,
                           reinterpret_cast<LPBYTE>(&obsoleteValue),
                           &obsoleteValueSize);
     if (ERROR_SUCCESS != res && ERROR_FILE_NOT_FOUND != res) {
-        ASSERT(!"error querying value of 'IsObsolete'\n");
+        ASSERT(0 == "error querying value of 'IsObsolete'\n");
         RegCloseKey(zoneSubKey);
         return -1;                                                    // RETURN
     }
@@ -940,7 +940,7 @@ static int loadTimezonesFromRegistry(vector<string> *timezones)
                                             &zonesKey);
 
     if (res != ERROR_SUCCESS) {
-        ASSERT(!"error opening registry: Time Zones\n");
+        ASSERT(0 == "error opening registry: Time Zones\n");
         return -1;                                                    // RETURN
     }
 
@@ -971,7 +971,7 @@ static int loadTimezonesFromRegistry(vector<string> *timezones)
                                        zonesKey,
                                        zoneBuf);
         if (0 != res) {
-            ASSERT(!"error getting timezone obsolete flag");
+            ASSERT(0 == "error getting timezone obsolete flag");
             RegCloseKey(zonesKey);  // put this into a guard
             return -1;                                                // RETURN
         }

diff --git a/groups/bal/baltzo/baltzo_zoneinfo.t.cpp b/groups/bal/baltzo/baltzo_zoneinfo.t.cpp
@@ -2133,7 +2133,7 @@ int main(int argc, char *argv[])
                                 0 == da.numBlocksTotal());
                       } break;
                       default: {
-                        BSLS_ASSERT_OPT(!"Bad allocator config.");
+                        BSLS_ASSERT_OPT(0 == "Bad allocator config.");
                       } break;
                     }
                     ASSERTV(LINE, CONFIG, 2*sizeof(Obj) == fa.numBytesInUse());

diff --git a/groups/bal/baltzo/baltzo_zoneinfocache.t.cpp b/groups/bal/baltzo/baltzo_zoneinfocache.t.cpp
@@ -1550,7 +1550,7 @@ int main(int argc, char *argv[])
                 objPtr = new (fa) Obj(&testLoader, alloc);
               } break;
               default: {
-                BSLS_ASSERT_OPT(!"Bad allocator config.");
+                BSLS_ASSERT_OPT(0 == "Bad allocator config.");
               } break;
             }
 

diff --git a/groups/bal/balxml/balxml_formatter.t.cpp b/groups/bal/balxml/balxml_formatter.t.cpp
@@ -427,7 +427,7 @@ using namespace bsl;  // automatically added by script
       case ScalarData::Ft::e_TIME:
         os << data.d_time; break;
       default:
-        BSLS_ASSERT_OPT(!"ScalarData type not accepted");
+        BSLS_ASSERT_OPT(0 == "ScalarData type not accepted");
     }
     return os;
 }

diff --git a/groups/bal/balxml/balxml_typesparserutil.h b/groups/bal/balxml/balxml_typesparserutil.h
@@ -934,7 +934,7 @@ int TypesParserUtil::parse(TYPE       *result,
                                               Tag());                 // RETURN
       } break;
       default: {
-        BSLS_ASSERT_SAFE(!"Unsupported operation!");
+        BSLS_ASSERT_SAFE(0 == "Unsupported operation!");
 
         return k_FAILURE;                                             // RETURN
       } break;
@@ -1047,7 +1047,7 @@ int TypesParserUtil_Imp::parseBase64(TYPE *, const char *, int, ANY_CATEGORY)
 {
     enum { k_FAILURE = -1 };
 
-    BSLS_ASSERT_SAFE(!"Unsupported operation!");
+    BSLS_ASSERT_SAFE(0 == "Unsupported operation!");
 
     // Note: 'parseBase64' for 'bsl::string' and 'bsl::vector<char>' is inside
     //       the CPP file.
@@ -1116,7 +1116,7 @@ int TypesParserUtil_Imp::parseDecimal(TYPE *, const char *, int, ANY_CATEGORY)
 {
     enum { k_FAILURE = -1 };
 
-    BSLS_ASSERT_SAFE(!"Unsupported operation!");
+    BSLS_ASSERT_SAFE(0 == "Unsupported operation!");
 
     return k_FAILURE;
 }
@@ -1175,7 +1175,7 @@ int TypesParserUtil_Imp::parseDefault(TYPE *, const char *, int, ANY_CATEGORY)
 {
     enum { k_FAILURE = -1 };
 
-    BSLS_ASSERT_SAFE(!"Unsupported operation!");
+    BSLS_ASSERT_SAFE(0 == "Unsupported operation!");
 
     return k_FAILURE;
 }
@@ -1422,7 +1422,7 @@ int TypesParserUtil_Imp::parseHex(TYPE *, const char *, int, ANY_CATEGORY)
 {
     enum { k_FAILURE = -1 };
 
-    BSLS_ASSERT_SAFE(!"Unsupported operation!");
+    BSLS_ASSERT_SAFE(0 == "Unsupported operation!");
 
     // Note: 'parseHex' for 'bsl::string' and 'bsl::vector<char>' is inside the
     //       CPP file.
@@ -1476,7 +1476,7 @@ int TypesParserUtil_Imp::parseList(TYPE *, const char *, int, ANY_CATEGORY)
 {
     enum { k_FAILURE = -1 };
 
-    BSLS_ASSERT_SAFE(!"Unsupported operation!");
+    BSLS_ASSERT_SAFE(0 == "Unsupported operation!");
 
     return k_FAILURE;
 }
@@ -1579,7 +1579,7 @@ int TypesParserUtil_Imp::parseText(TYPE *, const char *, int, ANY_CATEGORY)
 {
     enum { k_FAILURE = -1 };
 
-    BSLS_ASSERT_SAFE(!"Unsupported operation!");
+    BSLS_ASSERT_SAFE(0 == "Unsupported operation!");
 
     return k_FAILURE;
 }

diff --git a/groups/bal/balxml/balxml_typesprintutil.h b/groups/bal/balxml/balxml_typesprintutil.h
@@ -1134,7 +1134,7 @@ bsl::ostream& TypesPrintUtil::print(bsl::ostream&         stream,
             stream, object, encoderOptions, Tag());
       } break;
       default: {
-        BSLS_ASSERT_SAFE(!"Unsupported operation!");
+        BSLS_ASSERT_SAFE(0 == "Unsupported operation!");
         stream.setstate(bsl::ios_base::failbit);
         return stream;                                                // RETURN
       } break;
@@ -1269,7 +1269,7 @@ bsl::ostream& TypesPrintUtil_Imp::printBase64(bsl::ostream&         stream,
                                               const EncoderOptions *,
                                               ANY_CATEGORY)
 {
-    BSLS_ASSERT_SAFE(!"Unsupported operation!");
+    BSLS_ASSERT_SAFE(0 == "Unsupported operation!");
 
     stream.setstate(bsl::ios_base::failbit);
 
@@ -1333,7 +1333,7 @@ bsl::ostream& TypesPrintUtil_Imp::printDecimal(bsl::ostream&         stream,
                                                const EncoderOptions *,
                                                ANY_CATEGORY)
 {
-    BSLS_ASSERT_SAFE(!"Unsupported operation!");
+    BSLS_ASSERT_SAFE(0 == "Unsupported operation!");
 
     stream.setstate(bsl::ios_base::failbit);
 
@@ -1522,7 +1522,7 @@ bsl::ostream& TypesPrintUtil_Imp::printDefault(bsl::ostream&         stream,
                                                const EncoderOptions *,
                                                ANY_CATEGORY)
 {
-    BSLS_ASSERT_SAFE(!"Unsupported operation!");
+    BSLS_ASSERT_SAFE(0 == "Unsupported operation!");
 
     stream.setstate(bsl::ios_base::failbit);
 
@@ -1873,7 +1873,7 @@ bsl::ostream& TypesPrintUtil_Imp::printHex(bsl::ostream&         stream,
                                            const EncoderOptions *,
                                            ANY_CATEGORY)
 {
-    BSLS_ASSERT_SAFE(!"Unsupported operation!");
+    BSLS_ASSERT_SAFE(0 == "Unsupported operation!");
 
     stream.setstate(bsl::ios_base::failbit);
 
@@ -1946,7 +1946,7 @@ bsl::ostream& TypesPrintUtil_Imp::printList(bsl::ostream&         stream,
                                             const EncoderOptions *,
                                             ANY_CATEGORY)
 {
-    BSLS_ASSERT_SAFE(!"Unsupported operation!");
+    BSLS_ASSERT_SAFE(0 == "Unsupported operation!");
 
     stream.setstate(bsl::ios_base::failbit);
 
@@ -2004,7 +2004,7 @@ bsl::ostream& TypesPrintUtil_Imp::printText(bsl::ostream&         stream,
                                             const EncoderOptions *,
                                             ANY_CATEGORY)
 {
-    BSLS_ASSERT_SAFE(!"Unsupported operation!");
+    BSLS_ASSERT_SAFE(0 == "Unsupported operation!");
 
     stream.setstate(bsl::ios_base::failbit);
 

diff --git a/groups/bdl/bdlat/bdlat_choicefunctions.h b/groups/bdl/bdlat/bdlat_choicefunctions.h
@@ -291,7 +291,7 @@ BSLS_IDENT("$Id: $")
 //          return manipulator(&object->d_floatValue, info);          // RETURN
 //        }
 //        default:
-//          BSLS_ASSERT_SAFE(!"Invalid selection!");
+//          BSLS_ASSERT_SAFE(0 == "Invalid selection!");
 //      }
 //      return 0;
 //  }
@@ -337,7 +337,7 @@ BSLS_IDENT("$Id: $")
 //          return accessor(object.d_floatValue, info);               // RETURN
 //        }
 //        default:
-//          BSLS_ASSERT_SAFE(!"Invalid selection!");
+//          BSLS_ASSERT_SAFE(0 == "Invalid selection!");
 //      }
 //      return 0;
 //  }