Fix ASSERT_SAFE from bad BER date. (#4732)

bloomberg · May 9, 2024 · 53725e3 · 53725e3
1 parent e5ec57f
commit 53725e3
Show file tree

Hide file tree

Showing 2 changed files with 198 additions and 187 deletions.
diff --git a/groups/bal/balber/balber_berutil.cpp b/groups/bal/balber/balber_berutil.cpp
@@ -2001,6 +2001,11 @@ int BerUtil_DatetimeImpUtil::getExtendedBinaryDatetimeValue(
     bdlt::ProlepticDateImpUtil::serialToYmd(
         &year, &month, &day, daysSince0001Jan01);
 
+    // Make sure that the date actually exists before trying to create it
+    if (!bdlt::SerialDateImpUtil::isValidYearMonthDay(year, month, day)) {
+        return -1;                                                    // RETURN
+    }
+
     const bdlt::Date date(year, month, day);
 
     bsls::Types::Int64 microsecondsSinceMidnight;
@@ -2202,6 +2207,11 @@ int BerUtil_DatetimeImpUtil::getExtendedBinaryDatetimeTzValue(
     bdlt::ProlepticDateImpUtil::serialToYmd(
         &year, &month, &day, daysSince0001Jan01);
 
+    // Make sure that Date think it's actually valid before trying to create it
+    if (!bdlt::SerialDateImpUtil::isValidYearMonthDay(year, month, day)) {
+        return -1;                                                    // RETURN
+    }
+
     const bdlt::Date date(year, month, day);
 
     bsls::Types::Int64 microsecondsSinceMidnight;