diff --git a/groups/bal/balber/balber_beruniversaltagnumber.t.cpp b/groups/bal/balber/balber_beruniversaltagnumber.t.cpp index f1282cdf12..af38e44cd8 100644 --- a/groups/bal/balber/balber_beruniversaltagnumber.t.cpp +++ b/groups/bal/balber/balber_beruniversaltagnumber.t.cpp @@ -35,9 +35,11 @@ #include #include #include + #include #include #include +#include #include #include @@ -56,6 +58,12 @@ using bsl::ends; using bsl::flush; namespace test = BloombergLP::s_baltst; +#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC +#ifdef BSLS_PLATFORM_CMP_CLANG +#pragma GCC diagnostic ignored "-Wuninitialized-const-reference" +#endif +#endif + // ============================================================================ // TEST PLAN // ---------------------------------------------------------------------------- diff --git a/groups/bal/ball/ball_recordjsonformatter.t.cpp b/groups/bal/ball/ball_recordjsonformatter.t.cpp index 71f11b7104..0257b9fe93 100644 --- a/groups/bal/ball/ball_recordjsonformatter.t.cpp +++ b/groups/bal/ball/ball_recordjsonformatter.t.cpp @@ -2146,12 +2146,12 @@ int main(int argc, char *argv[]) ASSERTV(LINE, SPEC, SPEC == X.format()); ASSERTV(LINE, RSEP, RSEP == X.recordSeparator()); -#ifdef BSLS_PLATFORM_CMP_GNU +#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC # pragma GCC diagnostic push # pragma GCC diagnostic ignored "-Wdeprecated-declarations" #endif ASSERTV(LINE, SPEC, &oa == X.allocator()); -#ifdef BSLS_PLATFORM_CMP_GNU +#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC # pragma GCC diagnostic pop #endif ASSERTV(LINE, SPEC, &oa == X.get_allocator()); diff --git a/groups/bal/balm/balm_collector.t.cpp b/groups/bal/balm/balm_collector.t.cpp index b30bef0568..da458daa9e 100644 --- a/groups/bal/balm/balm_collector.t.cpp +++ b/groups/bal/balm/balm_collector.t.cpp @@ -114,10 +114,9 @@ class ConcurrencyTest { // Invoke a set of operations operations synchronously. // DATA - bdlmt::FixedThreadPool d_pool; - bslmt::Barrier d_barrier; - balm::Collector *d_collector_p; - BSLA_MAYBE_UNUSED bslma::Allocator *d_allocator_p; + bdlmt::FixedThreadPool d_pool; + bslmt::Barrier d_barrier; + balm::Collector *d_collector_p; // PRIVATE MANIPULATORS void execute(); @@ -132,7 +131,6 @@ class ConcurrencyTest { : d_pool(numThreads, 1000, basicAllocator) , d_barrier(numThreads) , d_collector_p(collector) - , d_allocator_p(basicAllocator) { d_pool.start(); } diff --git a/groups/bal/balm/balm_integercollector.t.cpp b/groups/bal/balm/balm_integercollector.t.cpp index 6c5601c79f..862534bfb3 100644 --- a/groups/bal/balm/balm_integercollector.t.cpp +++ b/groups/bal/balm/balm_integercollector.t.cpp @@ -111,10 +111,9 @@ class ConcurrencyTest { // Invoke a set of operations operations synchronously. // DATA - bdlmt::FixedThreadPool d_pool; - bslmt::Barrier d_barrier; - balm::IntegerCollector *d_collector_p; - BSLA_MAYBE_UNUSED bslma::Allocator *d_allocator_p; + bdlmt::FixedThreadPool d_pool; + bslmt::Barrier d_barrier; + balm::IntegerCollector *d_collector_p; // PRIVATE MANIPULATORS void execute(); @@ -129,7 +128,6 @@ class ConcurrencyTest { : d_pool(numThreads, 1000, basicAllocator) , d_barrier(numThreads) , d_collector_p(collector) - , d_allocator_p(basicAllocator) { d_pool.start(); } diff --git a/groups/bal/balm/balm_integermetric.t.cpp b/groups/bal/balm/balm_integermetric.t.cpp index 12c548a646..124e6cfb24 100644 --- a/groups/bal/balm/balm_integermetric.t.cpp +++ b/groups/bal/balm/balm_integermetric.t.cpp @@ -154,11 +154,10 @@ class MetricConcurrencyTest { // Invoke a set of operations operations synchronously. // DATA - bdlmt::FixedThreadPool d_pool; - balm::IntegerMetric *d_metric; - balm::MetricRegistry *d_registry; - bslmt::Barrier d_barrier; - BSLA_MAYBE_UNUSED bslma::Allocator *d_allocator_p; + bdlmt::FixedThreadPool d_pool; + balm::IntegerMetric *d_metric; + balm::MetricRegistry *d_registry; + bslmt::Barrier d_barrier; // PRIVATE MANIPULATORS void execute(); @@ -175,7 +174,6 @@ class MetricConcurrencyTest { , d_metric(metric) , d_registry(registry) , d_barrier(numThreads) - , d_allocator_p(basicAllocator) { d_pool.start(); } diff --git a/groups/bal/balm/balm_metric.t.cpp b/groups/bal/balm/balm_metric.t.cpp index dd48dffc3e..91702c1770 100644 --- a/groups/bal/balm/balm_metric.t.cpp +++ b/groups/bal/balm/balm_metric.t.cpp @@ -151,11 +151,10 @@ class MetricConcurrencyTest { // Invoke a set of operations operations synchronously. // DATA - bdlmt::FixedThreadPool d_pool; - balm::Metric *d_metric; - balm::MetricRegistry *d_registry; - bslmt::Barrier d_barrier; - BSLA_MAYBE_UNUSED bslma::Allocator *d_allocator_p; + bdlmt::FixedThreadPool d_pool; + balm::Metric *d_metric; + balm::MetricRegistry *d_registry; + bslmt::Barrier d_barrier; // PRIVATE MANIPULATORS void execute(); @@ -172,7 +171,6 @@ class MetricConcurrencyTest { , d_metric(metric) , d_registry(registry) , d_barrier(numThreads) - , d_allocator_p(basicAllocator) { d_pool.start(); } diff --git a/groups/bal/balm/balm_metricformat.t.cpp b/groups/bal/balm/balm_metricformat.t.cpp index fb52dce9a8..7614e2daa8 100644 --- a/groups/bal/balm/balm_metricformat.t.cpp +++ b/groups/bal/balm/balm_metricformat.t.cpp @@ -6,10 +6,13 @@ #include #include + #include #include #include + #include +#include #include #include @@ -25,6 +28,12 @@ using bsl::cout; using bsl::endl; using bsl::flush; +#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC +#ifdef BSLS_PLATFORM_CMP_CLANG +#pragma GCC diagnostic ignored "-Wself-assign-overloaded" +#endif +#endif + // ============================================================================ // TEST PLAN // ---------------------------------------------------------------------------- diff --git a/groups/bal/balm/balm_metricrecord.t.cpp b/groups/bal/balm/balm_metricrecord.t.cpp index 56fdf39d90..3338e27fdb 100644 --- a/groups/bal/balm/balm_metricrecord.t.cpp +++ b/groups/bal/balm/balm_metricrecord.t.cpp @@ -3,6 +3,8 @@ #include +#include + #include #include #include @@ -18,6 +20,12 @@ using bsl::cout; using bsl::endl; using bsl::flush; +#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC +#ifdef BSLS_PLATFORM_CMP_CLANG +#pragma GCC diagnostic ignored "-Wself-assign-overloaded" +#endif +#endif + // ============================================================================ // TEST PLAN // ---------------------------------------------------------------------------- diff --git a/groups/bal/balm/balm_metrics.t.cpp b/groups/bal/balm/balm_metrics.t.cpp index 9cd0a137e0..f5b89e67fb 100644 --- a/groups/bal/balm/balm_metrics.t.cpp +++ b/groups/bal/balm/balm_metrics.t.cpp @@ -347,7 +347,6 @@ class StandardMacroConcurrencyTest { // DATA Corp::bdlmt::FixedThreadPool d_pool; Corp::bslmt::Barrier d_barrier; - Corp::bslma::Allocator *d_allocator_p; // PRIVATE MANIPULATORS void execute(); @@ -360,7 +359,6 @@ class StandardMacroConcurrencyTest { Corp::bslma::Allocator *basicAllocator) : d_pool(numThreads, 1000, basicAllocator) , d_barrier(numThreads) - , d_allocator_p(basicAllocator) { d_pool.start(); } @@ -494,7 +492,6 @@ class DynamicMacroConcurrencyTest { // DATA Corp::bdlmt::FixedThreadPool d_pool; Corp::bslmt::Barrier d_barrier; - Corp::bslma::Allocator *d_allocator_p; // PRIVATE MANIPULATORS void execute(); @@ -506,7 +503,6 @@ class DynamicMacroConcurrencyTest { Corp::bslma::Allocator *basicAllocator) : d_pool(numThreads, 1000, basicAllocator) , d_barrier(numThreads) - , d_allocator_p(basicAllocator) { d_pool.start(); } @@ -802,7 +798,6 @@ class StandardIntMacroConcurrencyTest { // DATA Corp::bdlmt::FixedThreadPool d_pool; Corp::bslmt::Barrier d_barrier; - Corp::bslma::Allocator *d_allocator_p; // PRIVATE MANIPULATORS void execute(); @@ -815,7 +810,6 @@ class StandardIntMacroConcurrencyTest { Corp::bslma::Allocator *basicAllocator) : d_pool(numThreads, 1000, basicAllocator) , d_barrier(numThreads) - , d_allocator_p(basicAllocator) { d_pool.start(); } @@ -950,7 +944,6 @@ class DynamicIntMacroConcurrencyTest { // DATA Corp::bdlmt::FixedThreadPool d_pool; Corp::bslmt::Barrier d_barrier; - Corp::bslma::Allocator *d_allocator_p; // PRIVATE MANIPULATORS void execute(); @@ -962,7 +955,6 @@ class DynamicIntMacroConcurrencyTest { Corp::bslma::Allocator *basicAllocator) : d_pool(numThreads, 1000, basicAllocator) , d_barrier(numThreads) - , d_allocator_p(basicAllocator) { d_pool.start(); } diff --git a/groups/bal/balm/balm_metricsample.t.cpp b/groups/bal/balm/balm_metricsample.t.cpp index 81267c6c4c..f054c7b291 100644 --- a/groups/bal/balm/balm_metricsample.t.cpp +++ b/groups/bal/balm/balm_metricsample.t.cpp @@ -5,9 +5,12 @@ #include #include + #include #include + #include +#include #include #include @@ -23,6 +26,12 @@ using bsl::cout; using bsl::endl; using bsl::flush; +#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC +#ifdef BSLS_PLATFORM_CMP_CLANG +#pragma GCC diagnostic ignored "-Wself-assign-overloaded" +#endif +#endif + // ============================================================================ // TEST PLAN // ---------------------------------------------------------------------------- diff --git a/groups/bal/balm/balm_metricsmanager.t.cpp b/groups/bal/balm/balm_metricsmanager.t.cpp index e448c728b9..3632ed8944 100644 --- a/groups/bal/balm/balm_metricsmanager.t.cpp +++ b/groups/bal/balm/balm_metricsmanager.t.cpp @@ -2053,7 +2053,7 @@ int main(int argc, char *argv[]) const char *CATEGORIES[] = {"A", "B", "C", "Test", "12312category"}; const int NUM_CATEGORIES = sizeof (CATEGORIES)/sizeof (*CATEGORIES); - const char *METRICS[] = { "A", "B", "C", "MyMetric" "90123metric" }; + const char *METRICS[] = { "A", "B", "C", "MyMetric", "90123metric" }; const int NUM_METRICS = sizeof (METRICS) / sizeof (*METRICS); typedef bsl::shared_ptr CbPtr; @@ -2119,7 +2119,7 @@ int main(int argc, char *argv[]) const char *CATEGORIES[] = {"A", "B", "C", "Test", "12312category"}; const int NUM_CATEGORIES = sizeof (CATEGORIES)/sizeof (*CATEGORIES); - const char *METRICS[] = { "A", "B", "C", "MyMetric" "90123metric" }; + const char *METRICS[] = { "A", "B", "C", "MyMetric", "90123metric" }; const int NUM_METRICS = sizeof (METRICS) / sizeof (*METRICS); // Create a map, from metric id to 'TestCallback' functor. @@ -2357,7 +2357,7 @@ int main(int argc, char *argv[]) const char *CATEGORIES[] = {"A", "B", "C", "Test", "12312category"}; const int NUM_CATEGORIES = sizeof (CATEGORIES)/sizeof (*CATEGORIES); - const char *METRICS[] = { "A", "B", "C", "MyMetric" "90123metric" }; + const char *METRICS[] = { "A", "B", "C", "MyMetric", "90123metric" }; const int NUM_METRICS = sizeof (METRICS) / sizeof (*METRICS); // Create a map, from metric id to 'TestCallback' functor. @@ -3771,7 +3771,7 @@ int main(int argc, char *argv[]) const char *CATEGORIES[] = {"A", "B", "C", "Test", "12312category"}; const int NUM_CATEGORIES = sizeof (CATEGORIES)/sizeof (*CATEGORIES); - const char *METRICS[] = { "A", "B", "C", "MyMetric" "90123metric" }; + const char *METRICS[] = { "A", "B", "C", "MyMetric", "90123metric" }; const int NUM_METRICS = sizeof (METRICS) / sizeof (*METRICS); // Create a map, from metric id to 'TestCallback' functor. diff --git a/groups/bal/balst/balst_stacktraceframe.t.cpp b/groups/bal/balst/balst_stacktraceframe.t.cpp index ed2fa926a3..670b5777f0 100644 --- a/groups/bal/balst/balst_stacktraceframe.t.cpp +++ b/groups/bal/balst/balst_stacktraceframe.t.cpp @@ -1865,7 +1865,7 @@ int main(int argc, char *argv[]) objAllocatorPtr = &sa; } break; default: { - LOOP_ASSERT(CONFIG, !"Bad allocator config."); + LOOP_ASSERT(CONFIG, 0 == "Bad allocator config."); continue; } break; } @@ -3250,7 +3250,7 @@ int main(int argc, char *argv[]) objAllocatorPtr = &sa; } break; default: { - LOOP2_ASSERT(LINE, CONFIG, !"Bad allocator config."); + LOOP2_ASSERT(LINE, CONFIG, 0 == "Bad allocator config."); continue; } break; } @@ -3674,7 +3674,7 @@ int main(int argc, char *argv[]) objAllocatorPtr = &sa; } break; default: { - LOOP_ASSERT(CONFIG, !"Bad allocator config."); + LOOP_ASSERT(CONFIG, 0 == "Bad allocator config."); continue; } break; } diff --git a/groups/bal/baltzo/baltzo_datafileloader.t.cpp b/groups/bal/baltzo/baltzo_datafileloader.t.cpp index 66701cbc7d..9114a8b915 100644 --- a/groups/bal/baltzo/baltzo_datafileloader.t.cpp +++ b/groups/bal/baltzo/baltzo_datafileloader.t.cpp @@ -1350,7 +1350,7 @@ int main(int argc, char *argv[]) objAllocatorPtr = &sa; } break; default: { - LOOP_ASSERT(CONFIG, !"Bad allocator Config."); + LOOP_ASSERT(CONFIG, 0 == "Bad allocator Config."); } break; } diff --git a/groups/bal/baltzo/baltzo_localtimeperiod.t.cpp b/groups/bal/baltzo/baltzo_localtimeperiod.t.cpp index 17472d9168..c24061c0dd 100644 --- a/groups/bal/baltzo/baltzo_localtimeperiod.t.cpp +++ b/groups/bal/baltzo/baltzo_localtimeperiod.t.cpp @@ -1039,7 +1039,7 @@ int main(int argc, char *argv[]) done = true; } break; default: { - ASSERTV(CONFIG, !"Bad allocator config."); + ASSERTV(CONFIG, 0 == "Bad allocator config."); } break; } ASSERTV(LINE, CONFIG, @@ -2414,7 +2414,7 @@ int main(int argc, char *argv[]) objAllocatorPtr = &sa; } break; default: { - LOOP_ASSERT(CONFIG, !"Bad allocator config."); + LOOP_ASSERT(CONFIG, 0 == "Bad allocator config."); } break; } LOOP2_ASSERT(LINE, CONFIG, @@ -3532,7 +3532,7 @@ int main(int argc, char *argv[]) objAllocatorPtr = &sa; } break; default: { - LOOP2_ASSERT(LINE, CONFIG, !"Bad allocator config."); + LOOP2_ASSERT(LINE, CONFIG, 0 == "Bad allocator config."); } break; } LOOP2_ASSERT(LINE, CONFIG, @@ -3875,7 +3875,7 @@ int main(int argc, char *argv[]) objAllocatorPtr = &sa; } break; default: { - LOOP_ASSERT(CONFIG, !"Bad allocator config."); + LOOP_ASSERT(CONFIG, 0 == "Bad allocator config."); } break; } diff --git a/groups/bal/baltzo/baltzo_timezoneutil.t.cpp b/groups/bal/baltzo/baltzo_timezoneutil.t.cpp index df29be4c6c..dd6ef08f82 100644 --- a/groups/bal/baltzo/baltzo_timezoneutil.t.cpp +++ b/groups/bal/baltzo/baltzo_timezoneutil.t.cpp @@ -2957,7 +2957,7 @@ int main(int argc, char *argv[]) TZID)); } break; default: { - LOOP2_ASSERT(LINE, CONFIG, !"Bad test config."); + LOOP2_ASSERT(LINE, CONFIG, 0 == "Bad test config."); } break; } diff --git a/groups/bal/baltzo/baltzo_zoneinfobinaryreader.t.cpp b/groups/bal/baltzo/baltzo_zoneinfobinaryreader.t.cpp index 766672ca92..6f67435499 100644 --- a/groups/bal/baltzo/baltzo_zoneinfobinaryreader.t.cpp +++ b/groups/bal/baltzo/baltzo_zoneinfobinaryreader.t.cpp @@ -42,6 +42,12 @@ using bsl::memcmp; using bsl::strncmp; using bsl::strncpy; +#ifdef BSLS_PLATFORM_HAS_PRAGMA_GCC_DIAGNOSTIC +#ifdef BSLS_PLATFORM_CMP_CLANG +#pragma GCC diagnostic ignored "-Wunused-private-field" +#endif +#endif + // ============================================================================ // TEST PLAN // ---------------------------------------------------------------------------- @@ -4679,7 +4685,7 @@ int main(int argc, char *argv[]) ++iter; if (iter == TZ.endTransitions()) { - LOOP_ASSERT(ti, !"Unexpected number of transitions"); + LOOP_ASSERT(ti, 0 == "Unexpected number of transitions"); continue; } @@ -4717,7 +4723,7 @@ int main(int argc, char *argv[]) ++iter; if (iter == TZ.endTransitions()) { - LOOP_ASSERT(ti, !"Unexpected number of transitions"); + LOOP_ASSERT(ti, 0 == "Unexpected number of transitions"); continue; } @@ -4762,7 +4768,7 @@ int main(int argc, char *argv[]) --iter; if (iter == TZ.beginTransitions()) { - LOOP_ASSERT(ti, !"Unexpected number of transitions"); + LOOP_ASSERT(ti, 0 == "Unexpected number of transitions"); continue; } @@ -4808,7 +4814,7 @@ int main(int argc, char *argv[]) --iter; if (iter == TZ.beginTransitions()) { - LOOP_ASSERT(ti, !"Unexpected number of transitions"); + LOOP_ASSERT(ti, 0 == "Unexpected number of transitions"); continue; }