Add functions to unit test framework

Signed-off-by: Emelia Lei <[email protected]>

Author: emelialei88

src/groups/bmq/bmqimp/bmqimp_brokersession.t.cpp

@@ -2834,6 +2834,26 @@ class DTTestTracer : public bmqpi::DTTracer {
             d_allocator_p);
         return result;
     }
+
+    int
+    serializeSpan(BSLS_ANNOTATION_UNUSED bsl::vector<unsigned char>* buffer,
+                  BSLS_ANNOTATION_UNUSED const bsl::shared_ptr<bmqpi::DTSpan>&
+                      dtSpan) const BSLS_KEYWORD_OVERRIDE
+    {
+        // NOT IMPLEMENTED
+        return 0;
+    }
+
+    int deserializeAndCreateChildSpan(
+        BSLS_ANNOTATION_UNUSED bsl::shared_ptr<bmqpi::DTSpan>* child,
+        BSLS_ANNOTATION_UNUSED const bsl::vector<unsigned char>& buffer,
+        BSLS_ANNOTATION_UNUSED const bsl::string_view& operation,
+        BSLS_ANNOTATION_UNUSED const bmqpi::DTSpan::Baggage& baggage) const
+        BSLS_KEYWORD_OVERRIDE
+    {
+        // NOT IMPLEMENTED
+        return 0;
+    }
 };
 
 }  // close unnamed namespace

src/groups/bmq/bmqpi/bmqpi_dttracer.h

@@ -58,20 +58,19 @@ class DTTracer {
         const bsl::string_view&        operation,
         const DTSpan::Baggage&         baggage = DTSpan::Baggage()) const = 0;
 
-    /// Serialize the underlying context for a specified `DTSpan` and return
-    /// the bit stream as `out`.  Return 0 on success, or a non-zero error code
-    /// on error.
-    virtual int serializeSpan(bsl::vector<unsigned char>*    out,
+    /// Serialize the specified `dtSpan` into the specified `buffer`.
+    /// Return 0 on success, or a non-zero error code on error with `buffer`
+    /// being valid-but-unspecified.
+    virtual int serializeSpan(bsl::vector<unsigned char>*    buffer,
                               const bsl::shared_ptr<DTSpan>& dtSpan) const = 0;
 
-    /// Deserialize the specified bit stream `in` into a span context.
-    /// Create a child span and pass into `out` based on the deserialized
-    /// parent span context, the given `operation`, and an optional key-value
-    /// tags `baggage`.  Return 0 on success, or a non-zero error code on
-    /// error.
+    /// Deserialize the specified `buffer` as a span, and then construct a
+    /// new `DTSpan` in `child`, representing `operation` as a child of the
+    /// deserialized span and having the key-value tags defined by `baggage`.
+    /// Return 0 on success, or a non-zero error code on error.
     virtual int deserializeAndCreateChildSpan(
-        bsl::shared_ptr<DTSpan>*          out,
-        const bsl::vector<unsigned char>& in,
+        bsl::shared_ptr<DTSpan>*          child,
+        const bsl::vector<unsigned char>& buffer,
         const bsl::string_view&           operation,
         const DTSpan::Baggage& baggage = DTSpan::Baggage()) const = 0;
 };

src/groups/bmq/bmqpi/bmqpi_dttracer.t.cpp

@@ -31,18 +31,18 @@ using namespace BloombergLP;
 
 /// A test implementation of the `bmqpi::DTTracer` protocol.
 struct DTTracerTestImp : public bsls::ProtocolTestImp<bmqpi::DTTracer> {
-    virtual bsl::shared_ptr<bmqpi::DTSpan> createChildSpan(
+    bsl::shared_ptr<bmqpi::DTSpan> createChildSpan(
         const bsl::shared_ptr<bmqpi::DTSpan>& parent,
         const bsl::string_view&               operation,
         const bmqpi::DTSpan::Baggage& baggage) const BSLS_KEYWORD_OVERRIDE;
 
-    virtual int serializeSpan(bsl::vector<unsigned char>*           out,
-                              const bsl::shared_ptr<bmqpi::DTSpan>& dtSpan)
-        const BSLS_KEYWORD_OVERRIDE;
+    int serializeSpan(bsl::vector<unsigned char>*           buffer,
+                      const bsl::shared_ptr<bmqpi::DTSpan>& dtSpan) const
+        BSLS_KEYWORD_OVERRIDE;
 
-    virtual int deserializeAndCreateChildSpan(
-        bsl::shared_ptr<bmqpi::DTSpan>*   out,
-        const bsl::vector<unsigned char>& in,
+    int deserializeAndCreateChildSpan(
+        bsl::shared_ptr<bmqpi::DTSpan>*   child,
+        const bsl::vector<unsigned char>& buffer,
         const bsl::string_view&           operation,
         const bmqpi::DTSpan::Baggage& baggage = bmqpi::DTSpan::Baggage()) const
         BSLS_KEYWORD_OVERRIDE;
@@ -126,8 +126,8 @@ static void test1_breathingTest()
     BMQTST_ASSERT(tracer.testVirtualDestructor());
 
     PV("Verify that all methods are public and virtual");
-    bmqpi::DTSpan::Baggage     empty;
-    bsl::vector<unsigned char> emptyVec;
+    bmqpi::DTSpan::Baggage     empty(bmqtst::TestHelperUtil::allocator());
+    bsl::vector<unsigned char> emptyVec(bmqtst::TestHelperUtil::allocator());
     BSLS_PROTOCOLTEST_ASSERT(tracer, createChildSpan(NULL, "", empty));
     BSLS_PROTOCOLTEST_ASSERT(tracer, serializeSpan(NULL, NULL));
     BSLS_PROTOCOLTEST_ASSERT(