Remove unused parameter from RelayQueueEngine

During the fixes relating to monolithic storage, we left an unused
parameter in `RelayQueueEngine::storePush` originally denoting whether
the push was out-of-order or not.  This is no longer needed, so this
patch removes the parameter.

Signed-off-by: Patrick M. Niedzielski <[email protected]>

Author: pniedzielski

Diff for: src/groups/mqb/mqbblp/mqbblp_relayqueueengine.cpp

@@ -1802,7 +1802,7 @@ RelayQueueEngine::push(mqbi::StorageMessageAttributes*     attributes,
             ordinalPlusOne = 1 + app->ordinal();
             subscriptions.begin()->setId(ordinalPlusOne);
 
-            storePush(attributes, msgGUID, appData, subscriptions, true);
+            storePush(attributes, msgGUID, appData, subscriptions);
 
             // Attempt to deliver
             processAppRedelivery(subQueueId, app);
@@ -1886,7 +1886,7 @@ RelayQueueEngine::push(mqbi::StorageMessageAttributes*     attributes,
     if (count) {
         // Pass correct ref count
         attributes->setRefCount(count);
-        storePush(attributes, msgGUID, appData, subscriptions, false);
+        storePush(attributes, msgGUID, appData, subscriptions);
     }
     return count;
 }
@@ -1927,8 +1927,7 @@ void RelayQueueEngine::storePush(
     mqbi::StorageMessageAttributes*           attributes,
     const bmqt::MessageGUID&                  msgGUID,
     const bsl::shared_ptr<bdlbb::Blob>&       appData,
-    const bmqp::Protocol::SubQueueInfosArray& subscriptions,
-    bool                                      isOutOfOrder)
+    const bmqp::Protocol::SubQueueInfosArray& subscriptions)
 {
     if (d_queueState_p->domain()->cluster()->isRemote()) {
         // Save the message along with the subIds in the storage.  Note that

Diff for: src/groups/mqb/mqbblp/mqbblp_relayqueueengine.h

@@ -350,8 +350,7 @@ class RelayQueueEngine BSLS_KEYWORD_FINAL : public mqbi::QueueEngine {
     void storePush(mqbi::StorageMessageAttributes*           attributes,
                    const bmqt::MessageGUID&                  msgGUID,
                    const bsl::shared_ptr<bdlbb::Blob>&       appData,
-                   const bmqp::Protocol::SubQueueInfosArray& subscriptions,
-                   bool                                      isOutOfOrder);
+                   const bmqp::Protocol::SubQueueInfosArray& subscriptions);
 
     void beforeOneAppRemoved(unsigned int upstreamSubQueueId);