Fix: Remove all uses of bmqsys::ThreadUtil::k_SUPPORT_THREAD_NAME

The contracts of `bmqsys::ThreadUtil::setCurrentThreadName` and
`bmqsys::ThreadUtil::setCurrentThreadNameOnce` are wide; they may be called on
any platform, and they have no side effects on platforms where setting a thread
name is unsupported.  This means we do not need to guard calls to them by
checking a constant that is only true on platforms where setting a thread name
is supported.  This patch removes all such guards, which removes all uses of
this constant.

In most cases, the use of this constant is in an `if` statement that obviously
wraps some call to `bmqsys::ThreadUtil::setCurrentThreadName` or
`bmqsys::ThreadUtil::setCurrentThreadNameOnce`.  The only less obvious case is
in `m_bmqbrkr_task`’s mtrap support, where this constant guards a write of the
command `k_MTRAP_SET_THREADNAME` to the mtrap pipe.  The command is handled by
`Task::onControlMessage` in the same file, which in turn calls
`bmqsys::ThreadUtil::setCurrentThreadName`.  Presumably, this is where the `if`
guard should have been, but now it is safe to remove the guard on the write.

Signed-off-by: Patrick M. Niedzielski <[email protected]>

Author: pniedzielski

src/applications/bmqbrkr/m_bmqbrkr_task.cpp

@@ -279,12 +279,10 @@ int Task::initialize(bsl::ostream& errorDescription)
         return rc_SCHEDULER_START_FAILED;  // RETURN
     }
 
-    if (bmqsys::ThreadUtil::k_SUPPORT_THREAD_NAME) {
-        d_scheduler.scheduleEvent(
-            bsls::TimeInterval(0, 0),  // now
-            bdlf::BindUtil::bind(&bmqsys::ThreadUtil::setCurrentThreadName,
-                                 "bmqSchedTask"));
-    }
+    d_scheduler.scheduleEvent(
+        bsls::TimeInterval(0, 0),  // now
+        bdlf::BindUtil::bind(&bmqsys::ThreadUtil::setCurrentThreadName,
+                             "bmqSchedTask"));
 
     // -------------
     // LogController
@@ -344,10 +342,7 @@ int Task::initialize(bsl::ostream& errorDescription)
         return rc_CONTROLCHANNEL_START_FAILED;  // RETURN
     }
 
-    if (bmqsys::ThreadUtil::k_SUPPORT_THREAD_NAME) {
-        bdls::PipeUtil::send(pipePath,
-                             bsl::string(k_MTRAP_SET_THREADNAME) + "\n");
-    }
+    bdls::PipeUtil::send(pipePath, bsl::string(k_MTRAP_SET_THREADNAME) + "\n");
 
     // -------------------
     // M-Trap registration

src/groups/bmq/bmqimp/bmqimp_brokersession.cpp

@@ -5850,9 +5850,7 @@ void BrokerSession::setChannel(const bsl::shared_ptr<bmqio::Channel>& channel)
 {
     // executed by the *IO* thread
 
-    if (bmqsys::ThreadUtil::k_SUPPORT_THREAD_NAME) {
-        bmqsys::ThreadUtil::setCurrentThreadNameOnce("bmqTCPIO");
-    }
+    bmqsys::ThreadUtil::setCurrentThreadNameOnce("bmqTCPIO");
 
     if (channel) {  // We are now connected to bmqbrkr
         BALL_LOG_INFO << "Channel is CREATED [host: " << channel->peerUri()

src/groups/mqb/mqba/mqba_dispatcher.cpp

@@ -522,17 +522,15 @@ int Dispatcher::start(bsl::ostream& errorDescription)
         return rc;  // RETURN
     }
 
-    if (bmqsys::ThreadUtil::k_SUPPORT_THREAD_NAME) {
-        execute(bdlf::BindUtil::bind(&bmqsys::ThreadUtil::setCurrentThreadName,
-                                     "bmqDispSession"),
-                mqbi::DispatcherClientType::e_SESSION);
-        execute(bdlf::BindUtil::bind(&bmqsys::ThreadUtil::setCurrentThreadName,
-                                     "bmqDispQueue"),
-                mqbi::DispatcherClientType::e_QUEUE);
-        execute(bdlf::BindUtil::bind(&bmqsys::ThreadUtil::setCurrentThreadName,
-                                     "bmqDispCluster"),
-                mqbi::DispatcherClientType::e_CLUSTER);
-    }
+    execute(bdlf::BindUtil::bind(&bmqsys::ThreadUtil::setCurrentThreadName,
+                                 "bmqDispSession"),
+            mqbi::DispatcherClientType::e_SESSION);
+    execute(bdlf::BindUtil::bind(&bmqsys::ThreadUtil::setCurrentThreadName,
+                                 "bmqDispQueue"),
+            mqbi::DispatcherClientType::e_QUEUE);
+    execute(bdlf::BindUtil::bind(&bmqsys::ThreadUtil::setCurrentThreadName,
+                                 "bmqDispCluster"),
+            mqbi::DispatcherClientType::e_CLUSTER);
 
     d_isStarted = true;
 

src/groups/mqb/mqbnet/mqbnet_elector.cpp

@@ -2234,15 +2234,13 @@ Elector::Elector(mqbcfg::ElectorConfig&      config,
 
     d_state.setTerm(initialTerm);
 
-    if (bmqsys::ThreadUtil::k_SUPPORT_THREAD_NAME) {
-        // Per scheduler's contract, it's ok to schedule events before its
-        // started.
+    // Per scheduler's contract, it's ok to schedule events before its
+    // started.
 
-        d_scheduler.scheduleEvent(
-            bsls::TimeInterval(0, 0),  // now
-            bdlf::BindUtil::bind(&bmqsys::ThreadUtil::setCurrentThreadName,
-                                 "bmqSchedElec"));
-    }
+    d_scheduler.scheduleEvent(
+        bsls::TimeInterval(0, 0),  // now
+        bdlf::BindUtil::bind(&bmqsys::ThreadUtil::setCurrentThreadName,
+                             "bmqSchedElec"));
 }
 
 Elector::~Elector()

src/groups/mqb/mqbnet/mqbnet_tcpsessionfactory.cpp

@@ -656,9 +656,7 @@ void TCPSessionFactory::channelStateCallback(
     // This is an infrequent enough operation (compared to a 'readCb') that it
     // is fine to do this here (since we have no other ways to
     // proactively-execute code in the IO threads created by the channelPool).
-    if (bmqsys::ThreadUtil::k_SUPPORT_THREAD_NAME) {
-        bmqsys::ThreadUtil::setCurrentThreadNameOnce(d_threadName);
-    }
+    bmqsys::ThreadUtil::setCurrentThreadNameOnce(d_threadName);
 
     BALL_LOG_TRACE << "TCPSessionFactory '" << d_config.name()
                    << "': channelStateCallback [event: " << event

src/groups/mqb/mqbstat/mqbstat_statcontroller.cpp

@@ -725,12 +725,10 @@ int StatController::start(bsl::ostream& errorDescription)
         return -2;  // RETURN
     }
 
-    if (bmqsys::ThreadUtil::k_SUPPORT_THREAD_NAME) {
-        d_scheduler_mp->scheduleEvent(
-            bsls::TimeInterval(0),  // execute as soon as possible
-            bdlf::BindUtil::bind(&bmqsys::ThreadUtil::setCurrentThreadName,
-                                 "bmqSchedStat"));
-    }
+    d_scheduler_mp->scheduleEvent(
+        bsls::TimeInterval(0),  // execute as soon as possible
+        bdlf::BindUtil::bind(&bmqsys::ThreadUtil::setCurrentThreadName,
+                             "bmqSchedStat"));
 
     // Create and start the system stat monitor.  The SystemStats are used in
     // the dashboard screen, stat consumers, stats printer, ...  So we need to