Skip to content

Commit e616419

Browse files
committed
Remove unused parameter from RelayQueueEngine
During the fixes relating to monolithic storage, we left an unused parameter in `RelayQueueEngine::storePush` originally denoting whether the push was out-of-order or not. This is no longer needed, so this patch removes the parameter. Signed-off-by: Patrick M. Niedzielski <[email protected]>
1 parent 523fc20 commit e616419

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

Diff for: src/groups/mqb/mqbblp/mqbblp_relayqueueengine.cpp

+3-4
Original file line numberDiff line numberDiff line change
@@ -1796,7 +1796,7 @@ RelayQueueEngine::push(mqbi::StorageMessageAttributes* attributes,
17961796
ordinalPlusOne = 1 + app->ordinal();
17971797
subscriptions.begin()->setId(ordinalPlusOne);
17981798

1799-
storePush(attributes, msgGUID, appData, subscriptions, true);
1799+
storePush(attributes, msgGUID, appData, subscriptions);
18001800

18011801
// Attempt to deliver
18021802
processAppRedelivery(subQueueId, app);
@@ -1880,7 +1880,7 @@ RelayQueueEngine::push(mqbi::StorageMessageAttributes* attributes,
18801880
if (count) {
18811881
// Pass correct ref count
18821882
attributes->setRefCount(count);
1883-
storePush(attributes, msgGUID, appData, subscriptions, false);
1883+
storePush(attributes, msgGUID, appData, subscriptions);
18841884
}
18851885
return count;
18861886
}
@@ -1921,8 +1921,7 @@ void RelayQueueEngine::storePush(
19211921
mqbi::StorageMessageAttributes* attributes,
19221922
const bmqt::MessageGUID& msgGUID,
19231923
const bsl::shared_ptr<bdlbb::Blob>& appData,
1924-
const bmqp::Protocol::SubQueueInfosArray& subscriptions,
1925-
bool isOutOfOrder)
1924+
const bmqp::Protocol::SubQueueInfosArray& subscriptions)
19261925
{
19271926
if (d_queueState_p->domain()->cluster()->isRemote()) {
19281927
// Save the message along with the subIds in the storage. Note that

Diff for: src/groups/mqb/mqbblp/mqbblp_relayqueueengine.h

+1-2
Original file line numberDiff line numberDiff line change
@@ -350,8 +350,7 @@ class RelayQueueEngine BSLS_KEYWORD_FINAL : public mqbi::QueueEngine {
350350
void storePush(mqbi::StorageMessageAttributes* attributes,
351351
const bmqt::MessageGUID& msgGUID,
352352
const bsl::shared_ptr<bdlbb::Blob>& appData,
353-
const bmqp::Protocol::SubQueueInfosArray& subscriptions,
354-
bool isOutOfOrder);
353+
const bmqp::Protocol::SubQueueInfosArray& subscriptions);
355354

356355
void beforeOneAppRemoved(unsigned int upstreamSubQueueId);
357356

0 commit comments

Comments
 (0)