Skip to content

Improve mqbs_datastore.t.cpp unit tests #388

Open
@678098

Description

@678098

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

The current implementation is mostly a copy-paste of bmqt::MessageGUID unit tests.
It has several flaws:

  1. These comments are misleading and not true:

    // Above value is just chosen after looking at the number of collisions
    // by running this test case manually. In most runs, number of
    // collisions was in the range of [0, 3].

  2. The way how mqbs::DataStoreRecordKeys are generated is not representative to the usage pattern in the broker:

    mqbs::DataStoreRecordKey key(i, 7);

To get it right, both args should be modified.

Expected Behavior

No response

Steps To Reproduce

BlazingMQ Version

all

Anything else?

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workinggood first issueGood for newcomers

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions