Skip to content

ensure directory exists log message ( and directory setting in registry on harvest all ) #27

@sdm7g

Description

@sdm7g

Log message from
https://github.com/bloomonkey/oai-harvest/blob/develop/oaiharvest/harvest.py#L211
logger.debug("Creating target directory {0}".format(self._dir))
would make more sense as:
logger.debug("Creating target directory {0}".format(os.path.dirname))
It is logging the top level directory and not the directory it is actually creating.

Also note that when using a directory setting in the registry, and doing a harvest "all" , all of the files from all providers go into the directory from the first provider chosen. Not sure that anything can be done about that other than documenting that is the case, or perhaps it would be less confusing just to take directory out of the registry. Since the directory setting is per invocation rather than per provider, it would make more sense to restrict it to the command line and not have registry values that are ignored.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions