Skip to content

Commit 5b0a02e

Browse files
committed
fix profiles urls
1 parent 609b827 commit 5b0a02e

File tree

6 files changed

+18
-6
lines changed

6 files changed

+18
-6
lines changed

README.MD

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -89,6 +89,8 @@ First of all you need to create a Google Spreadsheet following the same rules as
8989
- **coverLetter:** Your cover letter template
9090
- **__translation__:** Add your custom translations
9191

92+
###**Please make sure to [publish your Spreadsheet to the web](https://support.google.com/a/users/answer/9308870)**, otherwise it won't work.
93+
9294
## Libraries
9395
- I'm using [gatsby.js](https://github.com/gatsbyjs/gatsby), [react.js](https://github.com/facebook/react), [js-xlsx](https://github.com/sheetjs/js-xlsx), [Material UI](https://material-ui.com/) and [mustache.js](https://github.com/janl/mustache.js/).
9496
- Gatsby template from [gatsby-material-ui-blog-starter](https://github.com/blopa/gatsby-material-ui-blog-starter)
@@ -303,6 +305,12 @@ The following `JSON` is a result of [this Google Spreadsheet](https://docs.googl
303305
![ScreenShot](https://raw.githubusercontent.com/blopa/Resume-Builder/main/screenshots/v4/screenshot_3.png)
304306

305307
## Release Notes
308+
- **v4.0.5:**
309+
- Fix `profiles` not being parsed correctly from the Spreadsheet
310+
- Fix parsing Google Spreadsheet (but you need to publish it to the web to work)
311+
- **v4.0.4:**
312+
- *Error 404: Release not found*
313+
- Sorry I had to make this joke...
306314
- **v4.0.3:**
307315
- Add toggler for `keywords` and `highlights` on the sidebar.
308316
- Bump Gatsby and plugins to 3.5.

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "resume-builder",
3-
"version": "4.0.3",
3+
"version": "4.0.5",
44
"description": "Resume Builder",
55
"main": "index.js",
66
"author": "Pablo Pirata",

resume.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
{
2121
"network": "Twitter",
2222
"username": "neutralthoughts",
23-
"url": ""
23+
"url": "https://twitter.com/neutralthoughts"
2424
},
2525
{
2626
"network": "SoundCloud",

src/utils/spreadsheet-parser.js

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,11 @@ export const downloadSpreadsheetFile =
3131
xhr.overrideMimeType('text/plain; charset=x-user-defined');
3232
xhr.onload = (event) => {
3333
if (event.currentTarget.status === 200) {
34-
return readSpreadsheetData(xhr.responseText, callback);
34+
if (xhr.responseText.startsWith('PK')) {
35+
return readSpreadsheetData(xhr.responseText, callback);
36+
}
37+
38+
return errorCallback(downloadUrl);
3539
}
3640

3741
return errorCallback(downloadUrl);
@@ -58,7 +62,7 @@ export const parseSpreadsheetUrl =
5862
}
5963
const spreadsheetId = spreadsheetIdResult[1];
6064

61-
downloadSpreadsheetFile(spreadsheetId, sheetId, callback, errorCallback);
65+
downloadSpreadsheetFile(spreadsheetId, sheetId, callback, errorCallback, false);
6266
};
6367

6468
export const readSpreadsheet = (file, callback) => {

src/utils/spreadsheet-to-json-resume.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -347,7 +347,7 @@ export default function spreadsheetToJsonResume(jsonSpreadsheet) {
347347
.some((entry) => entry[1].enabled),
348348
value: {
349349
...jsonResume.basics.value,
350-
profile: {
350+
profiles: {
351351
enabled: profileEnabled,
352352
value: profilesArray,
353353
},

0 commit comments

Comments
 (0)