Oh CodeQL do be quiet.

blowdart · blowdart · commit 9cb8dc6e06b3 · 2025-03-31T04:11:11.000-07:00
diff --git a/src/idunno.AtProto/Json/AtIdentiferConverter.cs b/src/idunno.AtProto/Json/AtIdentiferConverter.cs
@@ -41,15 +41,15 @@ public sealed class AtIdentifierConverter : JsonConverter<AtIdentifier>
         /// Writes the specified <see cref="AtIdentifier"></see> as JSON.
         /// </summary>
         /// <param name="writer">The writer to write to.</param>
-        /// <param name="atIdentifier">The <see cref="Cid"/> to convert to JSON.</param>
+        /// <param name="value">The <see cref="Cid"/> to convert to JSON.</param>
         /// <param name="options">An object that specifies serialization options to use.</param>
-        /// <exception cref="ArgumentNullException">Throws when <paramref name="writer"/> or <paramref name="atIdentifier"/> is null.</exception>
-        public override void Write(Utf8JsonWriter writer, AtIdentifier atIdentifier, JsonSerializerOptions options)
+        /// <exception cref="ArgumentNullException">Throws when <paramref name="writer"/> or <paramref name="value"/> is null.</exception>
+        public override void Write(Utf8JsonWriter writer, AtIdentifier value, JsonSerializerOptions options)
         {
             ArgumentNullException.ThrowIfNull(writer);
-            ArgumentNullException.ThrowIfNull(atIdentifier);
+            ArgumentNullException.ThrowIfNull(value);
 
-            writer.WriteStringValue(atIdentifier.ToString());
+            writer.WriteStringValue(value.ToString());
         }
     }
 }
diff --git a/src/idunno.AtProto/Json/AtUriConverter.cs b/src/idunno.AtProto/Json/AtUriConverter.cs
@@ -52,15 +52,15 @@ public sealed class AtUriConverter : JsonConverter<AtUri>
         /// Writes the specified <see cref="AtUri"></see> as JSON.
         /// </summary>
         /// <param name="writer">The writer to write to.</param>
-        /// <param name="atUri">The <see cref="Did"/> to convert to JSON.</param>
+        /// <param name="value">The <see cref="Did"/> to convert to JSON.</param>
         /// <param name="options">An object that specifies serialization options to use.</param>
-        /// <exception cref="ArgumentNullException">Throws when <paramref name="writer"/> or <paramref name="atUri"/> is null.</exception>
-        public override void Write(Utf8JsonWriter writer, AtUri atUri, JsonSerializerOptions options)
+        /// <exception cref="ArgumentNullException">Throws when <paramref name="writer"/> or <paramref name="value"/> is null.</exception>
+        public override void Write(Utf8JsonWriter writer, AtUri value, JsonSerializerOptions options)
         {
             ArgumentNullException.ThrowIfNull(writer);
-            ArgumentNullException.ThrowIfNull(atUri);
+            ArgumentNullException.ThrowIfNull(value);
 
-            writer.WriteStringValue(atUri.ToString());
+            writer.WriteStringValue(value.ToString());
         }
     }
 }
diff --git a/src/idunno.AtProto/Json/CidConverter.cs b/src/idunno.AtProto/Json/CidConverter.cs
@@ -44,15 +44,15 @@ public sealed class CidConverter : JsonConverter<Cid>
         /// Writes the specified <see cref="Cid"></see> as JSON.
         /// </summary>
         /// <param name="writer">The writer to write to.</param>
-        /// <param name="cid">The <see cref="Cid"/> to convert to JSON.</param>
+        /// <param name="value">The <see cref="Cid"/> to convert to JSON.</param>
         /// <param name="options">An object that specifies serialization options to use.</param>
-        /// <exception cref="ArgumentNullException">Throws when <paramref name="writer"/> or <paramref name="cid"/> is null.</exception>
-        public override void Write(Utf8JsonWriter writer, Cid cid, JsonSerializerOptions options)
+        /// <exception cref="ArgumentNullException">Throws when <paramref name="writer"/> or <paramref name="value"/> is null.</exception>
+        public override void Write(Utf8JsonWriter writer, Cid value, JsonSerializerOptions options)
         {
             ArgumentNullException.ThrowIfNull(writer);
-            ArgumentNullException.ThrowIfNull(cid);
+            ArgumentNullException.ThrowIfNull(value);
 
-            writer.WriteStringValue(cid.Value);
+            writer.WriteStringValue(value.Value);
         }
     }
 }
diff --git a/src/idunno.AtProto/Json/DidConverter.cs b/src/idunno.AtProto/Json/DidConverter.cs
@@ -48,15 +48,15 @@ public sealed class DidConverter : JsonConverter<Did>
         /// Writes the specified <see cref="Did"></see> as JSON.
         /// </summary>
         /// <param name="writer">The writer to write to.</param>
-        /// <param name="did">The <see cref="Did"/> to convert to JSON.</param>
+        /// <param name="value">The <see cref="Did"/> to convert to JSON.</param>
         /// <param name="options">An object that specifies serialization options to use.</param>
-        /// <exception cref="ArgumentNullException">Throws when <paramref name="writer"/> or <paramref name="did"/> is null.</exception>
-        public override void Write(Utf8JsonWriter writer, Did did, JsonSerializerOptions options)
+        /// <exception cref="ArgumentNullException">Throws when <paramref name="writer"/> or <paramref name="value"/> is null.</exception>
+        public override void Write(Utf8JsonWriter writer, Did value, JsonSerializerOptions options)
         {
             ArgumentNullException.ThrowIfNull(writer);
-            ArgumentNullException.ThrowIfNull(did);
+            ArgumentNullException.ThrowIfNull(value);
 
-            writer.WriteStringValue(did.Value);
+            writer.WriteStringValue(value.Value);
         }
     }
 }
diff --git a/src/idunno.AtProto/Json/HandleConverter.cs b/src/idunno.AtProto/Json/HandleConverter.cs
@@ -48,15 +48,15 @@ public sealed class HandleConverter : JsonConverter<Handle>
         /// Writes the specified <see cref="Handle"/> as JSON.
         /// </summary>
         /// <param name="writer">The writer to write to.</param>
-        /// <param name="handle">The <see cref="Handle"/> to convert to JSON.</param>
+        /// <param name="value">The <see cref="Handle"/> to convert to JSON.</param>
         /// <param name="options">An object that specifies serialization options to use.</param>
-        /// <exception cref="ArgumentNullException">Throws when <paramref name="writer"/> or <paramref name="handle"/> is null.</exception>
-        public override void Write(Utf8JsonWriter writer, Handle handle, JsonSerializerOptions options)
+        /// <exception cref="ArgumentNullException">Throws when <paramref name="writer"/> or <paramref name="value"/> is null.</exception>
+        public override void Write(Utf8JsonWriter writer, Handle value, JsonSerializerOptions options)
         {
             ArgumentNullException.ThrowIfNull(writer);
-            ArgumentNullException.ThrowIfNull(handle);
+            ArgumentNullException.ThrowIfNull(value);
 
-            writer.WriteStringValue(handle.Value);
+            writer.WriteStringValue(value.Value);
         }
     }
 }
diff --git a/src/idunno.AtProto/Json/NsidConverter.cs b/src/idunno.AtProto/Json/NsidConverter.cs
@@ -52,15 +52,15 @@ public sealed class NsidConverter : JsonConverter<Nsid>
         /// Writes the specified <see cref="RecordKey" /> as JSON.
         /// </summary>
         /// <param name="writer">The writer to write to.</param>
-        /// <param name="nsid">The <see cref="Cid"/> to convert to JSON.</param>
+        /// <param name="value">The <see cref="Cid"/> to convert to JSON.</param>
         /// <param name="options">An object that specifies serialization options to use.</param>
-        /// <exception cref="ArgumentNullException">Throws when <paramref name="writer"/> or <paramref name="nsid"/> is null.</exception>
-        public override void Write(Utf8JsonWriter writer, Nsid nsid, JsonSerializerOptions options)
+        /// <exception cref="ArgumentNullException">Throws when <paramref name="writer"/> or <paramref name="value"/> is null.</exception>
+        public override void Write(Utf8JsonWriter writer, Nsid value, JsonSerializerOptions options)
         {
             ArgumentNullException.ThrowIfNull(writer);
-            ArgumentNullException.ThrowIfNull(nsid);
+            ArgumentNullException.ThrowIfNull(value);
 
-            writer.WriteStringValue(nsid.ToString());
+            writer.WriteStringValue(value.ToString());
         }
     }
 }
diff --git a/src/idunno.AtProto/Json/RecordKeyConverter.cs b/src/idunno.AtProto/Json/RecordKeyConverter.cs
@@ -52,15 +52,15 @@ public sealed class RecordKeyConverter : JsonConverter<RecordKey>
         /// Writes the specified <see cref="RecordKey" /> as JSON.
         /// </summary>
         /// <param name="writer">The writer to write to.</param>
-        /// <param name="recordKey">The <see cref="Cid"/> to convert to JSON.</param>
+        /// <param name="value">The <see cref="Cid"/> to convert to JSON.</param>
         /// <param name="options">An object that specifies serialization options to use.</param>
-        /// <exception cref="ArgumentNullException">Throws when <paramref name="writer"/> or <paramref name="recordKey"/> is null.</exception>
-        public override void Write(Utf8JsonWriter writer, RecordKey recordKey, JsonSerializerOptions options)
+        /// <exception cref="ArgumentNullException">Throws when <paramref name="writer"/> or <paramref name="value"/> is null.</exception>
+        public override void Write(Utf8JsonWriter writer, RecordKey value, JsonSerializerOptions options)
         {
             ArgumentNullException.ThrowIfNull(writer);
-            ArgumentNullException.ThrowIfNull(recordKey);
+            ArgumentNullException.ThrowIfNull(value);
 
-            writer.WriteStringValue(recordKey.ToString());
+            writer.WriteStringValue(value.ToString());
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -41,15 +41,15 @@ public sealed class AtIdentifierConverter : JsonConverter<AtIdentifier>`
`41`	`41`	`/// Writes the specified <see cref="AtIdentifier"></see> as JSON.`
`42`	`42`	`/// </summary>`
`43`	`43`	`/// <param name="writer">The writer to write to.</param>`
`44`		`- /// <param name="atIdentifier">The <see cref="Cid"/> to convert to JSON.</param>`
	`44`	`+ /// <param name="value">The <see cref="Cid"/> to convert to JSON.</param>`
`45`	`45`	`/// <param name="options">An object that specifies serialization options to use.</param>`
`46`		`- /// <exception cref="ArgumentNullException">Throws when <paramref name="writer"/> or <paramref name="atIdentifier"/> is null.</exception>`
`47`		`- public override void Write(Utf8JsonWriter writer, AtIdentifier atIdentifier, JsonSerializerOptions options)`
	`46`	`+ /// <exception cref="ArgumentNullException">Throws when <paramref name="writer"/> or <paramref name="value"/> is null.</exception>`
	`47`	`+ public override void Write(Utf8JsonWriter writer, AtIdentifier value, JsonSerializerOptions options)`
`48`	`48`	`{`
`49`	`49`	`ArgumentNullException.ThrowIfNull(writer);`
`50`		`- ArgumentNullException.ThrowIfNull(atIdentifier);`
	`50`	`+ ArgumentNullException.ThrowIfNull(value);`
`51`	`51`
`52`		`- writer.WriteStringValue(atIdentifier.ToString());`
	`52`	`+ writer.WriteStringValue(value.ToString());`
`53`	`53`	`}`
`54`	`54`	`}`
`55`	`55`	`}`
Original file line number	Diff line number	Diff line change
`@@ -52,15 +52,15 @@ public sealed class AtUriConverter : JsonConverter<AtUri>`
`52`	`52`	`/// Writes the specified <see cref="AtUri"></see> as JSON.`
`53`	`53`	`/// </summary>`
`54`	`54`	`/// <param name="writer">The writer to write to.</param>`
`55`		`- /// <param name="atUri">The <see cref="Did"/> to convert to JSON.</param>`
	`55`	`+ /// <param name="value">The <see cref="Did"/> to convert to JSON.</param>`
`56`	`56`	`/// <param name="options">An object that specifies serialization options to use.</param>`
`57`		`- /// <exception cref="ArgumentNullException">Throws when <paramref name="writer"/> or <paramref name="atUri"/> is null.</exception>`
`58`		`- public override void Write(Utf8JsonWriter writer, AtUri atUri, JsonSerializerOptions options)`
	`57`	`+ /// <exception cref="ArgumentNullException">Throws when <paramref name="writer"/> or <paramref name="value"/> is null.</exception>`
	`58`	`+ public override void Write(Utf8JsonWriter writer, AtUri value, JsonSerializerOptions options)`
`59`	`59`	`{`
`60`	`60`	`ArgumentNullException.ThrowIfNull(writer);`
`61`		`- ArgumentNullException.ThrowIfNull(atUri);`
	`61`	`+ ArgumentNullException.ThrowIfNull(value);`
`62`	`62`
`63`		`- writer.WriteStringValue(atUri.ToString());`
	`63`	`+ writer.WriteStringValue(value.ToString());`
`64`	`64`	`}`
`65`	`65`	`}`
`66`	`66`	`}`
Original file line number	Diff line number	Diff line change
`@@ -44,15 +44,15 @@ public sealed class CidConverter : JsonConverter<Cid>`
`44`	`44`	`/// Writes the specified <see cref="Cid"></see> as JSON.`
`45`	`45`	`/// </summary>`
`46`	`46`	`/// <param name="writer">The writer to write to.</param>`
`47`		`- /// <param name="cid">The <see cref="Cid"/> to convert to JSON.</param>`
	`47`	`+ /// <param name="value">The <see cref="Cid"/> to convert to JSON.</param>`
`48`	`48`	`/// <param name="options">An object that specifies serialization options to use.</param>`
`49`		`- /// <exception cref="ArgumentNullException">Throws when <paramref name="writer"/> or <paramref name="cid"/> is null.</exception>`
`50`		`- public override void Write(Utf8JsonWriter writer, Cid cid, JsonSerializerOptions options)`
	`49`	`+ /// <exception cref="ArgumentNullException">Throws when <paramref name="writer"/> or <paramref name="value"/> is null.</exception>`
	`50`	`+ public override void Write(Utf8JsonWriter writer, Cid value, JsonSerializerOptions options)`
`51`	`51`	`{`
`52`	`52`	`ArgumentNullException.ThrowIfNull(writer);`
`53`		`- ArgumentNullException.ThrowIfNull(cid);`
	`53`	`+ ArgumentNullException.ThrowIfNull(value);`
`54`	`54`
`55`		`- writer.WriteStringValue(cid.Value);`
	`55`	`+ writer.WriteStringValue(value.Value);`
`56`	`56`	`}`
`57`	`57`	`}`
`58`	`58`	`}`
Original file line number	Diff line number	Diff line change
`@@ -48,15 +48,15 @@ public sealed class DidConverter : JsonConverter<Did>`
`48`	`48`	`/// Writes the specified <see cref="Did"></see> as JSON.`
`49`	`49`	`/// </summary>`
`50`	`50`	`/// <param name="writer">The writer to write to.</param>`
`51`		`- /// <param name="did">The <see cref="Did"/> to convert to JSON.</param>`
	`51`	`+ /// <param name="value">The <see cref="Did"/> to convert to JSON.</param>`
`52`	`52`	`/// <param name="options">An object that specifies serialization options to use.</param>`
`53`		`- /// <exception cref="ArgumentNullException">Throws when <paramref name="writer"/> or <paramref name="did"/> is null.</exception>`
`54`		`- public override void Write(Utf8JsonWriter writer, Did did, JsonSerializerOptions options)`
	`53`	`+ /// <exception cref="ArgumentNullException">Throws when <paramref name="writer"/> or <paramref name="value"/> is null.</exception>`
	`54`	`+ public override void Write(Utf8JsonWriter writer, Did value, JsonSerializerOptions options)`
`55`	`55`	`{`
`56`	`56`	`ArgumentNullException.ThrowIfNull(writer);`
`57`		`- ArgumentNullException.ThrowIfNull(did);`
	`57`	`+ ArgumentNullException.ThrowIfNull(value);`
`58`	`58`
`59`		`- writer.WriteStringValue(did.Value);`
	`59`	`+ writer.WriteStringValue(value.Value);`
`60`	`60`	`}`
`61`	`61`	`}`
`62`	`62`	`}`