Made repo models internal only and added a corresponding results record for public consumption in an attempt to avoid enums for trimming.

Author: blowdart

docs/docs/posting.md

@@ -5,8 +5,7 @@
 Let's start off by creating a simple post with the `CreatePost()` method.
 
 ```c#
-AtProtoHttpResult<CreateRecordResponse> postResult = 
-    await agent.Post("Hello world!");
+var postResult = await agent.Post("Hello world!");
 
 if (postResult.Succeeded)
 {
@@ -63,7 +62,7 @@ If its false, the `StatusCode` property will contain the HTTP status code return
 error information the API returned.
 
 ```c#
-AtProtoHttpResult<CreateRecordResponse> postResult =  await agent.Post("Hello world!");
+var postResult =  await agent.Post("Hello world!");
 
 if (postResult.Succeeded)
 {
@@ -88,7 +87,7 @@ For example, to delete the post you just made using the first code snippet above
 you got from creating the post, or the strong reference itself.
 
 ```c#
-HttpResult<Commit> deleteResult = await agent.DeletePost(postResult.Result.StrongReference.Uri);
+var deleteResult = await agent.DeletePost(postResult.Result.StrongReference.Uri);
 if (!deleteResult.Succeeded)
 {
     Console.ForegroundColor = ConsoleColor.Red;
@@ -128,23 +127,22 @@ var likeResult = await agent.Like(postStrongReference);
 Liking a post will return a `StrongReference` to the record for your like. You can use this strong reference to delete your like with `UndoLike()`.
 
 ```c#
-HttpResult<bool> undoResult = await agent.UndoLike(likeResult.Result);
+var undoResult = await agent.UndoLike(likeResult.Result);
 ```
 
 Reposting works in just the same way.
 
 ```c#
-HttpResult<StrongReference> repostResult = await agent.Repost(postReference);
-HttpResult<bool> undoRepostResult = await agent.UndoRepost(repostResult.Result);
+var repostResult = await agent.Repost(postReference);
+var undoRepostResult = await agent.UndoRepost(repostResult.Result);
 ```
 
 Quoting a post requires both the post strong reference, and the text you the quote post to contain.
 Deleting a post quoting another post is like deleting a regular post, you call `DeletePost`;
 
 ```c#
-HttpResult<StrongReference> quoteResult = 
-    await agent.Quote(postReference, "This is a quote of a post.");
-HttpResult<bool> deleteResult = await agent.DeleteQuote(quoteResult.Result!);
+var quoteResult = await agent.Quote(postReference, "This is a quote of a post.");
+var deleteResult = await agent.DeleteQuote(quoteResult.Result!);
 ```
 
 ## <a name="postRelationships">Getting your relationships with a post</a>
@@ -168,8 +166,7 @@ The majority of the `Post()` APIs will try to detect links, mentions and hashtag
 `extractFacets` parameter to `false`. For example:
 
 ```c#
-var postResult = 
-    await agent.Post("Hello #beans");
+var postResult =  await agent.Post("Hello #beans");
 ```
 
 This will result in a hashtag of beans being added to the post. Detection works for hashtags, @ mentions and for uris which begin with either
@@ -275,7 +272,7 @@ postBuilder.Append('.');
 var hashTag = new HashTag("beans");
 postBuilder.Append(hashTag);
 
-AtProtoHttpResult<CreateRecordResponse> facetedCreatePostResponse =
+var facetedCreatePostResponse =
     await agent.Post(postBuilder, cancellationToken: cancellationToken);
 ```
 
@@ -311,7 +308,7 @@ using (MemoryStream ms = new())
 Once you have your byte array upload it using `UploadImage`:
 
 ```c#
-AtProtoHttpResult<EmbeddedImage> imageUploadResult = await agent.UploadImage(
+var imageUploadResult = await agent.UploadImage(
     imageAsBytes,
     "image/jpg",
     "The Bluesky Logo",
@@ -343,7 +340,7 @@ You can, of course, add images to a `PostBuilder`:
 ```c#
 PostBuilder postBuilder = new("A reply with an image.");
 
-AtProtoHttpResult<EmbeddedImage> imageUploadResult = await agent.UploadImage(
+var imageUploadResult = await agent.UploadImage(
     imageAsBytes,
     "image/jpg",
     "The Bluesky Logo",

samples/Samples.Posting/Program.cs

@@ -107,7 +107,7 @@ static async Task PerformOperations(string? handle, string? password, string? au
 
                 {
                     // Simple post creation and deletion.
-                    AtProtoHttpResult<CreateRecordResponse> createPostResult = await agent.Post("Hello world", cancellationToken: cancellationToken);
+                    AtProtoHttpResult<CreateRecordResult> createPostResult = await agent.Post("Hello world", cancellationToken: cancellationToken);
                     if (!createPostResult.Succeeded)
                     {
                         Console.ForegroundColor = ConsoleColor.Red;
@@ -133,7 +133,7 @@ static async Task PerformOperations(string? handle, string? password, string? au
                     // In the past post creation and deletion.
                     DateTimeOffset past = DateTimeOffset.UtcNow.AddDays(-1);
 
-                    AtProtoHttpResult<CreateRecordResponse> createPostResult = await agent.Post("Hello world from the past", createdAt: past, cancellationToken: cancellationToken);
+                    AtProtoHttpResult<CreateRecordResult> createPostResult = await agent.Post("Hello world from the past", createdAt: past, cancellationToken: cancellationToken);
                     if (!createPostResult.Succeeded)
                     {
                         Console.ForegroundColor = ConsoleColor.Red;
@@ -157,7 +157,7 @@ static async Task PerformOperations(string? handle, string? password, string? au
 
                 {
                     // Simple post creation with a detected hashtag.
-                    AtProtoHttpResult<CreateRecordResponse> createPostResult = await agent.Post("Hello world #helloWorld", cancellationToken: cancellationToken);
+                    AtProtoHttpResult<CreateRecordResult> createPostResult = await agent.Post("Hello world #helloWorld", cancellationToken: cancellationToken);
                     if (!createPostResult.Succeeded)
                     {
                         Console.ForegroundColor = ConsoleColor.Red;
@@ -181,21 +181,21 @@ static async Task PerformOperations(string? handle, string? password, string? au
 
                 {
                     // Simple post creation and reply post creation.
-                    AtProtoHttpResult<CreateRecordResponse> createPostResult = await agent.Post("Another test post, this time to check replying.", cancellationToken: cancellationToken);
+                    AtProtoHttpResult<CreateRecordResult> createPostResult = await agent.Post("Another test post, this time to check replying.", cancellationToken: cancellationToken);
                     if (createPostResult.Succeeded)
                     {
                         // Let's pretend we didn't just create the post, and we just have the strong reference of the post we want to reply to.
                         StrongReference postToReplyTo = createPostResult.Result.StrongReference;
 
-                        AtProtoHttpResult<CreateRecordResponse> replyToHttpResult = await agent.ReplyTo(postToReplyTo, "This is a reply.", cancellationToken: cancellationToken);
+                        AtProtoHttpResult<CreateRecordResult> replyToHttpResult = await agent.ReplyTo(postToReplyTo, "This is a reply.", cancellationToken: cancellationToken);
                         if (!replyToHttpResult.Succeeded)
                         {
                             Console.ForegroundColor = ConsoleColor.Red;
                             Console.WriteLine($"{replyToHttpResult.StatusCode} occurred when creating the post.");
                             return;
                         }
 
-                        AtProtoHttpResult<CreateRecordResponse> replyToReplyHttpResult = await agent.ReplyTo(replyToHttpResult.Result!.StrongReference, "This is a reply to the reply.", cancellationToken: cancellationToken);
+                        AtProtoHttpResult<CreateRecordResult> replyToReplyHttpResult = await agent.ReplyTo(replyToHttpResult.Result!.StrongReference, "This is a reply to the reply.", cancellationToken: cancellationToken);
                         Debugger.Break();
 
                         if (!replyToReplyHttpResult.Succeeded)
@@ -247,7 +247,7 @@ static async Task PerformOperations(string? handle, string? password, string? au
                         return;
                     }
 
-                    AtProtoHttpResult<CreateRecordResponse> createPostResult = await agent.Post("Hello world with an image.", imageUploadResult.Result, cancellationToken: cancellationToken);
+                    AtProtoHttpResult<CreateRecordResult> createPostResult = await agent.Post("Hello world with an image.", imageUploadResult.Result, cancellationToken: cancellationToken);
                     Debugger.Break();
 
                     if (!createPostResult.Succeeded)
@@ -337,7 +337,7 @@ static async Task PerformOperations(string? handle, string? password, string? au
                         cancellationToken: cancellationToken);
 
 
-                    AtProtoHttpResult<CreateRecordResponse> multipleImagePostResult = await agent.Post(
+                    AtProtoHttpResult<CreateRecordResult> multipleImagePostResult = await agent.Post(
                         "Hello world with multiple images",
                         [
                             imageUploadResult.Result!,
@@ -367,10 +367,10 @@ static async Task PerformOperations(string? handle, string? password, string? au
 
                 {
                     // Repost
-                    AtProtoHttpResult<CreateRecordResponse> createPostResult = await agent.Post("Another test post, for reposting.", cancellationToken: cancellationToken);
+                    AtProtoHttpResult<CreateRecordResult> createPostResult = await agent.Post("Another test post, for reposting.", cancellationToken: cancellationToken);
                     if (createPostResult.Succeeded)
                     {
-                        AtProtoHttpResult<CreateRecordResponse> repostResult = await agent.Repost(createPostResult.Result.StrongReference, cancellationToken: cancellationToken);
+                        AtProtoHttpResult<CreateRecordResult> repostResult = await agent.Repost(createPostResult.Result.StrongReference, cancellationToken: cancellationToken);
                         Debugger.Break();
 
                         if (!repostResult.Succeeded)
@@ -398,10 +398,10 @@ static async Task PerformOperations(string? handle, string? password, string? au
 
                 {
                     // Like
-                    AtProtoHttpResult<CreateRecordResponse> createPostResult = await agent.Post("Another test post, for liking.", cancellationToken: cancellationToken);
+                    AtProtoHttpResult<CreateRecordResult> createPostResult = await agent.Post("Another test post, for liking.", cancellationToken: cancellationToken);
                     if (createPostResult.Succeeded)
                     {
-                        AtProtoHttpResult<CreateRecordResponse> likeResult = await agent.Like(createPostResult.Result.StrongReference, cancellationToken: cancellationToken);
+                        AtProtoHttpResult<CreateRecordResult> likeResult = await agent.Like(createPostResult.Result.StrongReference, cancellationToken: cancellationToken);
                         Debugger.Break();
 
                         if (!likeResult.Succeeded)
@@ -429,7 +429,7 @@ static async Task PerformOperations(string? handle, string? password, string? au
 
                 {
                     // Quote
-                    AtProtoHttpResult<CreateRecordResponse> createPostResult = await agent.Post("Another test post, for quoting.", cancellationToken: cancellationToken);
+                    AtProtoHttpResult<CreateRecordResult> createPostResult = await agent.Post("Another test post, for quoting.", cancellationToken: cancellationToken);
                     if (createPostResult.Succeeded)
                     {
                         var quoteResponse = await agent.Quote(createPostResult.Result.StrongReference, "Quote Dunk!", cancellationToken: cancellationToken);
@@ -451,7 +451,7 @@ static async Task PerformOperations(string? handle, string? password, string? au
                                                     new AspectRatio(1000, 1000),
                                                     cancellationToken: cancellationToken);
 
-                        AtProtoHttpResult<CreateRecordResponse> imageDunkQuoteResponse = await agent.Quote(
+                        AtProtoHttpResult<CreateRecordResult> imageDunkQuoteResponse = await agent.Quote(
                             createPostResult.Result.StrongReference,
                             "Dunk with an image",
                             imageUploadResult.Result!,
@@ -523,7 +523,7 @@ static async Task PerformOperations(string? handle, string? password, string? au
 
                     postBuilder += imageUploadResult.Result!;
 
-                    AtProtoHttpResult<CreateRecordResponse> facetedCreatePostResponse = await agent.Post(postBuilder, cancellationToken: cancellationToken);
+                    AtProtoHttpResult<CreateRecordResult> facetedCreatePostResponse = await agent.Post(postBuilder, cancellationToken: cancellationToken);
                     Debugger.Break();
 
                     if (facetedCreatePostResponse.Succeeded)

src/Directory.Build.props

@@ -16,7 +16,7 @@
     <!-- Always treat "S1135 Complete the task associated to this 'TODO'" as a warning -->
     <WarningsNotAsErrors>S1133,S1135</WarningsNotAsErrors>
     <!-- Remove until https://github.com/dotnet/runtime/issues/114307 -->
-    <!--<IsAotCompatible>true</IsAotCompatible>-->
+    <IsAotCompatible>true</IsAotCompatible>
   </PropertyGroup>
 
   <Choose>