Skip to content

dont use default camera credentials #738

@netforce

Description

@netforce

Dont use known default credentials when trying to add a camera. This will result in people leaving an unsecured open cameras on their network and creating major security risks.

Instead ask for credentials after discovery, before trying to add.

I notice trying to add camera's with non-default credentials takes a lot of time in the getRtspUrls (2 mins plus), ask for credentials after discovery, not after failing to add them with default creds.

www-data   57862  0.0  0.0   2576   932 ?        S    12:44   0:00 sh -c node /usr/share/bluecherry/onvif/getRtspUrls.js '169.254.96.183:80' 'root' 'pass'
www-data   57863  0.3  0.3 610500 56232 ?        Sl   12:44   0:00 node /usr/share/bluecherry/onvif/getRtspUrls.js 169.254.96.183:80 root pass
root       58245  0.0  0.0   6332  2140 pts/3    S+   12:46   0:00 grep blue

==> /var/log/bluecherry.log <==
2025-03-09T12:38:39.382453+01:00 eelco-gamews bc-server[31120]: I(4/192.168.10.110): Device's thread ordered to terminate
2025-03-09T12:38:39.382795+01:00 eelco-gamews bc-server[31120]: I(4/192.168.10.110): Shutting down device thread
2025-03-09T12:38:39.396935+01:00 eelco-gamews bc-server[31120]: I(2/M3114): Device's thread ordered to terminate
2025-03-09T12:38:39.397107+01:00 eelco-gamews bc-server[31120]: I(2/M3114): Shutting down device thread
2025-03-09T12:38:39.400898+01:00 eelco-gamews bc-server[31120]: I(3/P1344-109): Device's thread ordered to terminate
2025-03-09T12:38:39.401095+01:00 eelco-gamews bc-server[31120]: I(3/P1344-109): Shutting down device thread

Metadata

Metadata

Assignees

Labels

No fields configured for Feature.

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions