Fix for #36

- Prevent NPE

Author: paulrutter

CHANGELOG.txt

@@ -1,4 +1,7 @@
-1.3.4 - 22 Aptril 2021
+1.3.5 - 22 April 2021
+- Fix for #36
+
+1.3.4 - 22 April 2021
 - Updated to browscap 6000043.
 - Updated unit tests accordingly (new bots mostly).
 

README.md

@@ -42,7 +42,7 @@ Add this to the dependencies in your pom.xml.
 <dependency>
   <groupId>com.blueconic</groupId>
   <artifactId>browscap-java</artifactId>
-  <version>1.3.4</version>
+  <version>1.3.5</version>
 </dependency>
 ```
 

pom.xml

@@ -4,7 +4,7 @@
     <groupId>com.blueconic</groupId>
     <artifactId>browscap-java</artifactId>
     <packaging>jar</packaging>
-    <version>1.3.4</version>
+    <version>1.3.5</version>
     <name>browscap-java</name>
     <description>A blazingly fast and memory efficient Java client on top of the BrowsCap CSV source files.</description>
 

src/main/java/com/blueconic/browscap/impl/UserAgentParserImpl.java

@@ -29,7 +29,7 @@ class UserAgentParserImpl implements UserAgentParser {
             "rv:", "build", "bot", "like gecko", "applewebkit", "trident", "mozilla", "windows nt 4", "windows nt 5.0",
             "windows nt 5.1", "windows nt 5.2", "windows nt 6.0", "windows nt 6.1", "windows nt 6.2", "windows nt 6.3",
             "windows nt 10.0", "android?4.0", "android?4.1", "android?4.2", "android?4.3", "android?4.4", "android?2.3",
-    "android?5"};
+            "android?5"};
 
     // Common prefixes to filter irrelevant rules and speed up processing
     static final String[] FILTER_PREFIXES = {"mozilla/5.0", "mozilla/4"};
@@ -64,6 +64,9 @@ class UserAgentParserImpl implements UserAgentParser {
      */
     @Override
     public Capabilities parse(final String userAgent) {
+        if (userAgent == null || userAgent.length() == 0) {
+            return myDefaultCapabilities;
+        }
 
         final SearchableString searchString = myDomain.getSearchableString(userAgent.toLowerCase());
 
@@ -110,9 +113,10 @@ Filter[] buildFilters() {
         for (final String pattern : FILTER_PREFIXES) {
             result.add(createPrefixFilter(pattern));
         }
-        
+
         // Build filters for specific contains constraints
-        final List<Filter> commonFilters = Stream.of(COMMON).parallel().map(this::createContainsFilter).collect(toList());
+        final List<Filter> commonFilters =
+                Stream.of(COMMON).parallel().map(this::createContainsFilter).collect(toList());
         result.addAll(commonFilters);
 
         return result.toArray(new Filter[0]);