Skip to content

Commit d4ab859

Browse files
committed
OMG lint was mad at me
1 parent d1d2e59 commit d4ab859

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

45 files changed

+184
-171
lines changed

packages/flame_mini_sprite/example/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ environment:
99
sdk: ">=2.17.6 <3.0.0"
1010

1111
dependencies:
12-
flame: ^1.14.0
12+
flame: ^1.32.0
1313
flame_mini_sprite:
1414
path: ../
1515
flutter:
Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,3 @@
1-
library mini_sprite;
2-
31
export 'src/mini_library.dart';
42
export 'src/mini_map.dart';
53
export 'src/mini_sprite.dart';

packages/mini_sprite/test/src/mini_library_test.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// Ignore for tests
12
// ignore_for_file: prefer_const_constructors
23

34
import 'package:mini_sprite/mini_sprite.dart';

packages/mini_sprite/test/src/mini_map_test.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ void main() {
4343
'fromDataString returns the correct instance with width and height',
4444
() {
4545
const data =
46+
// Ignore for tests
4647
// ignore: lines_longer_than_80_chars
4748
'{"width":2,"height":2,"objects":[{"x": 0, "y": 0, "data": {"sprite": "player"}}]}';
4849
final instance = MiniMap.fromDataString(data);

packages/mini_sprite/test/src/mini_sprite_test.dart

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// Ignore for tests
12
// ignore_for_file: prefer_const_constructors
23

34
import 'package:mini_sprite/mini_sprite.dart';

packages/mini_sprite_editor/lib/app/view/app.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ class App extends StatelessWidget {
5555
if (spriteRaw != null) {
5656
try {
5757
sprite = MiniSprite.fromDataString(spriteRaw);
58-
} catch (_) {
58+
} on Exception catch (_) {
5959
// ignore on invalid sprite data
6060
}
6161
}

packages/mini_sprite_editor/lib/config/view/config_dialog.dart

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -291,7 +291,7 @@ class _ColorTile extends StatelessWidget {
291291
}
292292

293293
class _ColorButton extends StatelessWidget {
294-
const _ColorButton({super.key, required this.color, required this.onPressed});
294+
const _ColorButton({required this.color, required this.onPressed, super.key});
295295

296296
final Color color;
297297
final VoidCallback onPressed;

packages/mini_sprite_editor/lib/library/cubit/library_cubit.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import 'dart:async';
2+
13
import 'package:bloc/bloc.dart';
24
import 'package:equatable/equatable.dart';
35
import 'package:flutter/services.dart';
@@ -100,6 +102,6 @@ class LibraryCubit extends Cubit<LibraryState> {
100102
void copyToClipboard() {
101103
final library = MiniLibrary(state.sprites);
102104
final data = library.toDataString();
103-
_setClipboardData(ClipboardData(text: data));
105+
unawaited(_setClipboardData(ClipboardData(text: data)));
104106
}
105107
}

packages/mini_sprite_editor/lib/library/view/library_panel.dart

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import 'dart:async';
2+
13
import 'package:flame/widgets.dart';
24
import 'package:flame_mini_sprite/flame_mini_sprite.dart';
35
import 'package:flutter/material.dart';
@@ -56,7 +58,7 @@ class _LibraryPanelState extends State<LibraryPanel> {
5658
return BlocListener<SpriteCubit, SpriteState>(
5759
listenWhen: (previous, current) => previous.pixels != current.pixels,
5860
listener: (context, state) {
59-
_onSpriteChange(state.pixels);
61+
unawaited(_onSpriteChange(state.pixels));
6062
},
6163
child: Card(
6264
child: Column(
@@ -102,7 +104,9 @@ class _LibraryPanelState extends State<LibraryPanel> {
102104
IconButton(
103105
key: const Key('import_library_from_clipboard_key'),
104106
onPressed: () {
105-
context.read<LibraryCubit>().importFromClipboard();
107+
unawaited(
108+
context.read<LibraryCubit>().importFromClipboard(),
109+
);
106110
ScaffoldMessenger.of(context).showSnackBar(
107111
SnackBar(content: Text(l10n.importSuccess)),
108112
);

packages/mini_sprite_editor/lib/map/cubit/map_cubit.dart

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
import 'dart:async';
2+
13
import 'package:bloc/bloc.dart';
24
import 'package:equatable/equatable.dart';
35
import 'package:flutter/services.dart';
@@ -23,7 +25,7 @@ class MapCubit extends Cubit<MapState> {
2325
width: state.mapSize.width.toInt(),
2426
height: state.mapSize.height.toInt(),
2527
).toDataString();
26-
_setClipboardData(ClipboardData(text: data));
28+
unawaited(_setClipboardData(ClipboardData(text: data)));
2729
}
2830

2931
Future<void> importFromClipboard() async {

0 commit comments

Comments
 (0)