Fixes #524 - onContextAvailable not being called on all child controllers

Eric Kuck · Eric Kuck · commit f72b5bed650c · 2019-03-26T18:24:30.000-05:00
diff --git a/build.gradle b/build.gradle
@@ -4,7 +4,7 @@ buildscript {
         google()
     }
     dependencies {
-        classpath 'com.android.tools.build:gradle:3.2.1'
+        classpath 'com.android.tools.build:gradle:3.3.1'
     }
 }
 
diff --git a/conductor/src/main/java/com/bluelinelabs/conductor/Router.java b/conductor/src/main/java/com/bluelinelabs/conductor/Router.java
@@ -546,6 +546,8 @@ public void rebindIfNeeded() {
 
             if (transaction.controller.getNeedsAttach()) {
                 performControllerChange(transaction, null, true, new SimpleSwapChangeHandler(false));
+            } else {
+                setControllerRouter(transaction.controller);
             }
         }
     }
diff --git a/demo/build.gradle b/demo/build.gradle
@@ -4,8 +4,8 @@ android {
     compileSdkVersion rootProject.ext.compileSdkVersion
 
     compileOptions {
-        sourceCompatibility JavaVersion.VERSION_1_7
-        targetCompatibility JavaVersion.VERSION_1_7
+        sourceCompatibility 1.8
+        targetCompatibility 1.8
     }
 
     defaultConfig {
diff --git a/dependencies.gradle b/dependencies.gradle
@@ -3,7 +3,7 @@ ext {
     compileSdkVersion = 28
     targetSdkVersion = 28
 
-    butterknifeVersion = '9.0.0-rc1'
+    butterknifeVersion = '10.1.0'
     picassoVersion = '2.5.2'
     leakCanaryVersion = '1.5.4'
     rxJavaVersion = '1.3.8'

Original file line number	Diff line number	Diff line change
`@@ -4,7 +4,7 @@ buildscript {`
`4`	`4`	`google()`
`5`	`5`	`}`
`6`	`6`	`dependencies {`
`7`		`- classpath 'com.android.tools.build:gradle:3.2.1'`
	`7`	`+ classpath 'com.android.tools.build:gradle:3.3.1'`
`8`	`8`	`}`
`9`	`9`	`}`
`10`	`10`
Original file line number	Diff line number	Diff line change
`@@ -546,6 +546,8 @@ public void rebindIfNeeded() {`
`546`	`546`
`547`	`547`	`if (transaction.controller.getNeedsAttach()) {`
`548`	`548`	`performControllerChange(transaction, null, true, new SimpleSwapChangeHandler(false));`
	`549`	`+ } else {`
	`550`	`+ setControllerRouter(transaction.controller);`
`549`	`551`	`}`
`550`	`552`	`}`
`551`	`553`	`}`
Original file line number	Diff line number	Diff line change
`@@ -4,8 +4,8 @@ android {`
`4`	`4`	`compileSdkVersion rootProject.ext.compileSdkVersion`
`5`	`5`
`6`	`6`	`compileOptions {`
`7`		`- sourceCompatibility JavaVersion.VERSION_1_7`
`8`		`- targetCompatibility JavaVersion.VERSION_1_7`
	`7`	`+ sourceCompatibility 1.8`
	`8`	`+ targetCompatibility 1.8`
`9`	`9`	`}`
`10`	`10`
`11`	`11`	`defaultConfig {`