bump golangci-lint to 2.8.0 (#983)

Author: bluenviron-bot

.github/workflows/lint.yml

@@ -22,7 +22,7 @@ jobs:
 
     - uses: golangci/golangci-lint-action@v9
       with:
-        version: v2.6.1
+        version: v2.8.0
 
   go_mod:
     runs-on: ubuntu-22.04

client.go

@@ -75,12 +75,27 @@ func ssrcsMapToList(m map[uint8]uint32) []uint32 {
 }
 
 func clientExtractExistingSSRCs(setuppedMedias map[*description.Media]*clientMedia) []uint32 {
-	var ret []uint32
+	n := 0
+	for _, media := range setuppedMedias {
+		for range media.formats {
+			n++
+		}
+	}
+
+	if n == 0 {
+		return nil
+	}
+
+	ret := make([]uint32, n)
+	n = 0
+
 	for _, media := range setuppedMedias {
 		for _, forma := range media.formats {
-			ret = append(ret, forma.localSSRC)
+			ret[n] = forma.localSSRC
+			n++
 		}
 	}
+
 	return ret
 }
 

pkg/base/header.go

@@ -104,8 +104,10 @@ func (h Header) marshalSize() int {
 	// sort headers by key
 	// in order to obtain deterministic results
 	keys := make([]string, len(h))
+	i := 0
 	for key := range h {
-		keys = append(keys, key)
+		keys[i] = key
+		i++
 	}
 	sort.Strings(keys)
 
@@ -126,8 +128,10 @@ func (h Header) marshalTo(buf []byte) int {
 	// sort headers by key
 	// in order to obtain deterministic results
 	keys := make([]string, len(h))
+	i := 0
 	for key := range h {
-		keys = append(keys, key)
+		keys[i] = key
+		i++
 	}
 	sort.Strings(keys)
 

pkg/format/rtplpcm/decoder_test.go

@@ -19,7 +19,7 @@ func TestDecode(t *testing.T) {
 			err := d.Init()
 			require.NoError(t, err)
 
-			var samples []byte
+			var samples []byte //nolint:prealloc
 
 			for _, pkt := range ca.pkts {
 				var partial []byte

pkg/headers/authenticate.go

@@ -76,11 +76,10 @@ func (h *Authenticate) Unmarshal(v base.HeaderValue) error {
 
 	v0 := v[0]
 
-	i := strings.IndexByte(v0, ' ')
-	if i < 0 {
+	method, v0, found := strings.Cut(v0, " ")
+	if !found {
 		return fmt.Errorf("unable to split between method and keys (%v)", v0)
 	}
-	method, v0 := v0[:i], v0[i+1:]
 
 	switch method {
 	case "Basic":

pkg/headers/authorization.go

@@ -58,11 +58,10 @@ func (h *Authorization) Unmarshal(v base.HeaderValue) error {
 
 	v0 := v[0]
 
-	i := strings.IndexByte(v0, ' ')
-	if i < 0 {
+	method, v0, found := strings.Cut(v0, " ")
+	if !found {
 		return fmt.Errorf("unable to split between method and keys (%v)", v0)
 	}
-	method, v0 := v0[:i], v0[i+1:]
 
 	switch method {
 	case "Basic":

server_session.go

@@ -32,12 +32,27 @@ import (
 type readFunc func([]byte) bool
 
 func serverSessionExtractExistingSSRCs(medias map[*description.Media]*serverSessionMedia) []uint32 {
-	var ret []uint32
+	n := 0
+	for _, media := range medias {
+		for range media.formats {
+			n++
+		}
+	}
+
+	if n == 0 {
+		return nil
+	}
+
+	ret := make([]uint32, n)
+	n = 0
+
 	for _, media := range medias {
 		for _, forma := range media.formats {
-			ret = append(ret, forma.localSSRC)
+			ret[n] = forma.localSSRC
+			n++
 		}
 	}
+
 	return ret
 }
 

server_stream.go

@@ -16,12 +16,27 @@ import (
 )
 
 func serverStreamExtractExistingSSRCs(medias map[*description.Media]*serverStreamMedia) []uint32 {
-	var ret []uint32
+	n := 0
+	for _, media := range medias {
+		for range media.formats {
+			n++
+		}
+	}
+
+	if n == 0 {
+		return nil
+	}
+
+	ret := make([]uint32, n)
+	n = 0
+
 	for _, media := range medias {
 		for _, forma := range media.formats {
-			ret = append(ret, forma.localSSRC)
+			ret[n] = forma.localSSRC
+			n++
 		}
 	}
+
 	return ret
 }