core: helper: Only abort if server returns bad request

patrickelectric · joaoantoniocardoso · commit 73dffa458161 · 2024-12-04T18:42:17.000-03:00
Sometimes it can result as redirect or any other, register service will take care for us

Signed-off-by: Patrick José Pereira &lt;patrickelectric@gmail.com&gt;
diff --git a/core/services/helper/main.py b/core/services/helper/main.py
@@ -317,7 +317,7 @@ def detect_service(port: int) -> ServiceInfo:
             "127.0.0.1", port=port, path="/", timeout=1.0, method="GET", follow_redirects=10
         )
         log_msg = f"Detecting service at port {port}"
-        if response.status != http.client.OK:
+        if response.status == http.client.BAD_REQUEST:
             # If not valid web server, documentation will not be available
             logger.debug(f"{log_msg}: Invalid: {response.status} - {response.decoded_data}")
             return info

Original file line number	Diff line number	Diff line change
`@@ -317,7 +317,7 @@ def detect_service(port: int) -> ServiceInfo:`
`317`	`317`	`"127.0.0.1", port=port, path="/", timeout=1.0, method="GET", follow_redirects=10`
`318`	`318`	`)`
`319`	`319`	`log_msg = f"Detecting service at port {port}"`
`320`		`- if response.status != http.client.OK:`
	`320`	`+ if response.status == http.client.BAD_REQUEST:`
`321`	`321`	`# If not valid web server, documentation will not be available`
`322`	`322`	`logger.debug(f"{log_msg}: Invalid: {response.status} - {response.decoded_data}")`
`323`	`323`	`return info`