remove notifs package (#970)

This is part of indexer stuff which isn't actually used anywhere.

Author: bnewbold

cmd/bigsky/main.go

@@ -20,7 +20,6 @@ import (
 	"github.com/bluesky-social/indigo/did"
 	"github.com/bluesky-social/indigo/events"
 	"github.com/bluesky-social/indigo/indexer"
-	"github.com/bluesky-social/indigo/notifs"
 	"github.com/bluesky-social/indigo/plc"
 	"github.com/bluesky-social/indigo/repomgr"
 	"github.com/bluesky-social/indigo/util"
@@ -449,11 +448,9 @@ func runBigsky(cctx *cli.Context) error {
 
 	evtman := events.NewEventManager(persister)
 
-	notifman := &notifs.NullNotifs{}
-
 	rf := indexer.NewRepoFetcher(db, repoman, cctx.Int("max-fetch-concurrency"))
 
-	ix, err := indexer.NewIndexer(db, notifman, evtman, cachedidr, rf, true, false, cctx.Bool("spidering"))
+	ix, err := indexer.NewIndexer(db, evtman, cachedidr, rf, true, false, cctx.Bool("spidering"))
 	if err != nil {
 		return err
 	}

indexer/indexer.go

@@ -14,7 +14,6 @@ import (
 	"github.com/bluesky-social/indigo/events"
 	lexutil "github.com/bluesky-social/indigo/lex/util"
 	"github.com/bluesky-social/indigo/models"
-	"github.com/bluesky-social/indigo/notifs"
 	"github.com/bluesky-social/indigo/repomgr"
 	"github.com/bluesky-social/indigo/util"
 	"github.com/bluesky-social/indigo/xrpc"
@@ -31,9 +30,8 @@ const MaxOpsSliceLength = 200
 type Indexer struct {
 	db *gorm.DB
 
-	notifman notifs.NotificationManager
-	events   *events.EventManager
-	didr     did.Resolver
+	events *events.EventManager
+	didr   did.Resolver
 
 	Crawler *CrawlDispatcher
 
@@ -47,7 +45,7 @@ type Indexer struct {
 	log *slog.Logger
 }
 
-func NewIndexer(db *gorm.DB, notifman notifs.NotificationManager, evtman *events.EventManager, didr did.Resolver, fetcher *RepoFetcher, crawl, aggregate, spider bool) (*Indexer, error) {
+func NewIndexer(db *gorm.DB, evtman *events.EventManager, didr did.Resolver, fetcher *RepoFetcher, crawl, aggregate, spider bool) (*Indexer, error) {
 	db.AutoMigrate(&models.FeedPost{})
 	db.AutoMigrate(&models.ActorInfo{})
 	db.AutoMigrate(&models.FollowRecord{})
@@ -56,7 +54,6 @@ func NewIndexer(db *gorm.DB, notifman notifs.NotificationManager, evtman *events
 
 	ix := &Indexer{
 		db:             db,
-		notifman:       notifman,
 		events:         evtman,
 		didr:           didr,
 		doAggregations: aggregate,
@@ -424,14 +421,6 @@ func (ix *Indexer) handleRecordDelete(ctx context.Context, evt *repomgr.RepoEven
 		if err := ix.db.Where("reposter = ? AND rkey = ?", evt.User, op.Rkey).Delete(&models.RepostRecord{}).Error; err != nil {
 			return err
 		}
-
-		ix.log.Warn("TODO: remove notifications on delete")
-		/*
-		   if err := ix.notifman.RemoveRepost(ctx, fp.Author, rr.ID, evt.User); err != nil {
-		           return nil, err
-		   }
-		*/
-
 	case "app.bsky.feed.vote":
 		return ix.handleRecordDeleteFeedLike(ctx, evt, op)
 	case "app.bsky.graph.follow":
@@ -518,10 +507,6 @@ func (ix *Indexer) handleRecordCreate(ctx context.Context, evt *repomgr.RepoEven
 			return nil, err
 		}
 
-		if err := ix.notifman.AddRepost(ctx, fp.Author, rr.ID, evt.User); err != nil {
-			return nil, err
-		}
-
 	case *bsky.FeedLike:
 		return nil, ix.handleRecordCreateFeedLike(ctx, rec, evt, op)
 	case *bsky.GraphFollow:
@@ -602,10 +587,6 @@ func (ix *Indexer) handleRecordCreateGraphFollow(ctx context.Context, rec *bsky.
 		return err
 	}
 
-	if err := ix.notifman.AddFollow(ctx, fr.Follower, fr.Target, fr.ID); err != nil {
-		return err
-	}
-
 	return nil
 }
 
@@ -812,26 +793,16 @@ func (ix *Indexer) createMissingPostRecord(ctx context.Context, puri *util.Parse
 
 func (ix *Indexer) addNewPostNotification(ctx context.Context, post *bsky.FeedPost, fp *models.FeedPost, mentions []*models.ActorInfo) error {
 	if post.Reply != nil {
-		replyto, err := ix.GetPost(ctx, post.Reply.Parent.Uri)
+		_, err := ix.GetPost(ctx, post.Reply.Parent.Uri)
 		if err != nil {
 			ix.log.Error("probably shouldn't error when processing a reply to a not-found post")
 			return err
 		}
-
-		if err := ix.notifman.AddReplyTo(ctx, fp.Author, fp.ID, replyto); err != nil {
-			return err
-		}
-	}
-
-	for _, mentioned := range mentions {
-		if err := ix.notifman.AddMention(ctx, fp.Author, fp.ID, mentioned.Uid); err != nil {
-			return err
-		}
 	}
 
 	return nil
 }
 
 func (ix *Indexer) addNewVoteNotification(ctx context.Context, postauthor models.Uid, vr *models.VoteRecord) error {
-	return ix.notifman.AddUpVote(ctx, vr.Voter, vr.Post, vr.ID, postauthor)
+	return nil
 }

indexer/posts_test.go

@@ -10,7 +10,6 @@ import (
 	bsky "github.com/bluesky-social/indigo/api/bsky"
 	"github.com/bluesky-social/indigo/carstore"
 	"github.com/bluesky-social/indigo/events"
-	"github.com/bluesky-social/indigo/notifs"
 	"github.com/bluesky-social/indigo/plc"
 	"github.com/bluesky-social/indigo/repomgr"
 	"github.com/bluesky-social/indigo/util"
@@ -56,14 +55,13 @@ func testIndexer(t *testing.T) *testIx {
 	}
 
 	repoman := repomgr.NewRepoManager(cs, &util.FakeKeyManager{})
-	notifman := notifs.NewNotificationManager(maindb, repoman.GetRecord)
 	evtman := events.NewEventManager(events.NewMemPersister())
 
 	didr := testPLC(t)
 
 	rf := NewRepoFetcher(maindb, repoman, 10)
 
-	ix, err := NewIndexer(maindb, notifman, evtman, didr, rf, false, true, true)
+	ix, err := NewIndexer(maindb, evtman, didr, rf, false, true, true)
 	if err != nil {
 		t.Fatal(err)
 	}