signatures are errors

brianolson · brianolson · commit 991d2f987ccf · 2025-03-20T13:39:36.000-04:00
diff --git a/cmd/relay/bgs/validator.go b/cmd/relay/bgs/validator.go
@@ -436,7 +436,7 @@ func (val *Validator) HandleSync(ctx context.Context, host *models.PDS, msg *atp
 	err = val.VerifyCommitSignature(ctx, commit, hostname, &hasWarning)
 	if err != nil {
 		// signature errors are metrics counted inside VerifyCommitSignature()
-		logger.Warn("invalid sig", "err", err)
+		return nil, err
 	}
 
 	return &commit.Data, nil

Original file line number	Diff line number	Diff line change
`@@ -436,7 +436,7 @@ func (val Validator) HandleSync(ctx context.Context, host models.PDS, msg *atp`
`436`	`436`	`err = val.VerifyCommitSignature(ctx, commit, hostname, &hasWarning)`
`437`	`437`	`if err != nil {`
`438`	`438`	`// signature errors are metrics counted inside VerifyCommitSignature()`
`439`		`- logger.Warn("invalid sig", "err", err)`
	`439`	`+ return nil, err`
`440`	`440`	`}`
`441`	`441`
`442`	`442`	`return &commit.Data, nil`