-
Notifications
You must be signed in to change notification settings - Fork 36
Description
There might be general interest in adding "limit" or "range" information to data_keys in the event descriptor [1]. The primary goal is to have more intelligent defaults for live-plots and autogenerated post-processing.
Ophyd v1 already does this [2] with their own special keys lower_ctrl_limit and upper_ctrl_limit. data_keys object in the schema supports arbitrary additional properties (items) I guess this is a JSON schema default.
See @ddkohler's issue against YEPS [3]. The Wright Group has a long-standing concept of data being "signed". Seems like this behavior could be captured by special cases of range for their purposes.
WrightTools signed |
Descriptor range |
|---|---|
False |
(-inf, +inf) |
True |
(0, +inf) |
We could have multiple range types perhaps. Display range, alarm range, warning range, control range. What do existing systems do?
| interface | properties |
|---|---|
| Ophyd.v1 | lower_ctrl_limit upper_ctrl_limit |
| PyTango | get_max_value get_min_value is_min_warning is_max_warning is_min_alarm is_max_alarm |
| yaq | get_limits |
[1] https://github.com/bluesky/event-model/blob/master/event_model/schemas/event_descriptor.json
[2] https://github.com/bluesky/ophyd/blob/master/ophyd/signal.py#L1469-L1470
[3] yaq-project/yeps#15