chore: address review comments

Author: shihab-dls

src/ophyd_async/fastcs/odin/_odin_io.py

@@ -61,7 +61,7 @@ def __init__(
     ) -> None:
         self._drv = odin_driver
         self._path_provider = path_provider
-        self._detector_bit_depth = Reference(detector_bit_depth)
+        self._detector_bit_depth = detector_bit_depth
         super().__init__()
 
     async def open(self, name: str, exposures_per_event: int = 1) -> dict[str, DataKey]:
@@ -70,7 +70,7 @@ async def open(self, name: str, exposures_per_event: int = 1) -> dict[str, DataK
 
         await asyncio.gather(
             self._drv.fp.data_datatype.set(
-                f"uint{await self._detector_bit_depth().get_value()}"
+                f"uint{await self._detector_bit_depth.get_value()}"
             ),
             self._drv.fp.data_compression.set("BSLZ4"),
             self._drv.fp.frames.set(exposures_per_event),
@@ -81,7 +81,7 @@ async def open(self, name: str, exposures_per_event: int = 1) -> dict[str, DataK
             self._drv.mw.acquisition_id.set(info.filename),
         )
 
-        await self._drv.fp.start_writing.trigger(wait=True)
+        await self._drv.fp.start_writing.trigger()
 
         await asyncio.gather(
             wait_for_value(self._drv.fp.writing, True, timeout=DEFAULT_TIMEOUT),
@@ -124,6 +124,6 @@ def collect_stream_docs(
 
     async def close(self) -> None:
         await asyncio.gather(
-            self._drv.fp.stop_writing.trigger(wait=True),
-            self._drv.mw.stop.trigger(wait=True),
+            self._drv.fp.stop_writing.trigger(),
+            self._drv.mw.stop.trigger(),
         )

tests/unit_tests/epics/eiger/test_odin_io.py

@@ -83,7 +83,7 @@ async def test_bit_depth_is_passed_before_open_and_set_to_data_type_after_open(
     driver, writer = odin_driver_and_writer
     initialise_signals_to_armed(driver)
 
-    assert await writer._detector_bit_depth().get_value() == EIGER_BIT_DEPTH
+    assert await writer._detector_bit_depth.get_value() == EIGER_BIT_DEPTH
     assert await driver.fp.data_datatype.get_value() == ""
     await writer.open(ODIN_DETECTOR_NAME)
     get_mock_put(driver.fp.data_datatype).assert_called_once_with(