Skip to content

Commit 6359512

Browse files
committed
Fix test by callback on writing from confighdfwrite
1 parent cd68373 commit 6359512

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

src/ophyd_async/fastcs/odin/_odin_io.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ class OdinHdfIO(Device):
3333
writing: SignalR[Writing]
3434
config_hdf_write: SignalW[Writing]
3535
frames_written: SignalR[int]
36-
config_hdf_frames: SignalRW[int]
36+
config_hdf_frames: SignalW[int]
3737
dataset_data_dims_0: SignalRW[int]
3838
dataset_data_dims_1: SignalRW[int]
3939
dataset_data_chunks_0: SignalRW[int]

tests/fastcs/odin/test_odin_io.py

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55

66
from ophyd_async.core import init_devices
77
from ophyd_async.fastcs.odin import OdinHdfIO, OdinWriter, Writing # noqa: PLC2701
8-
from ophyd_async.testing import get_mock_put, set_mock_value
8+
from ophyd_async.testing import callback_on_mock_put, get_mock_put, set_mock_value
99

1010
OdinDriverAndWriter = tuple[OdinHdfIO, OdinWriter]
1111

@@ -65,5 +65,11 @@ async def test_when_closed_then_data_capture_turned_off(
6565
odin_driver_and_writer: OdinDriverAndWriter,
6666
):
6767
driver, writer = odin_driver_and_writer
68+
69+
def set_writing_signal(value, *args, **kwargs):
70+
set_mock_value(driver.writing, value)
71+
72+
callback_on_mock_put(driver.config_hdf_write, set_writing_signal)
73+
6874
await writer.close()
6975
get_mock_put(driver.config_hdf_write).assert_called_once_with(Writing.OFF, wait=ANY)

0 commit comments

Comments
 (0)