Add missing docstrings, remove unused enum class (#822)

* Add missing docstrings, remove unused enum class

* Add missing classes to __all__ to satisfy doc build

Author: jwlodek

src/ophyd_async/epics/adkinetix/__init__.py

@@ -1,10 +1,11 @@
 from ._kinetix import KinetixDetector
 from ._kinetix_controller import KinetixController
-from ._kinetix_io import KinetixDriverIO, KinetixTriggerMode
+from ._kinetix_io import KinetixDriverIO, KinetixReadoutMode, KinetixTriggerMode
 
 __all__ = [
     "KinetixDetector",
     "KinetixController",
     "KinetixDriverIO",
     "KinetixTriggerMode",
+    "KinetixReadoutMode",
 ]

src/ophyd_async/epics/adkinetix/_kinetix_io.py

@@ -14,6 +14,8 @@ class KinetixTriggerMode(StrictEnum):
 
 
 class KinetixReadoutMode(StrictEnum):
+    """Readout mode for ADKinetix detector."""
+
     SENSITIVITY = 1
     SPEED = 2
     DYNAMIC_RANGE = 3

src/ophyd_async/epics/advimba/__init__.py

@@ -1,6 +1,13 @@
 from ._vimba import VimbaDetector
 from ._vimba_controller import VimbaController
-from ._vimba_io import VimbaDriverIO, VimbaExposeOutMode, VimbaOnOff, VimbaTriggerSource
+from ._vimba_io import (
+    VimbaConvertFormat,
+    VimbaDriverIO,
+    VimbaExposeOutMode,
+    VimbaOnOff,
+    VimbaOverlap,
+    VimbaTriggerSource,
+)
 
 __all__ = [
     "VimbaDetector",
@@ -9,4 +16,6 @@
     "VimbaExposeOutMode",
     "VimbaOnOff",
     "VimbaTriggerSource",
+    "VimbaOverlap",
+    "VimbaConvertFormat",
 ]

src/ophyd_async/epics/advimba/_vimba_io.py

@@ -5,15 +5,9 @@
 from ophyd_async.epics.core import PvSuffix
 
 
-class VimbaPixelFormat(StrictEnum):
-    INTERNAL = "Mono8"
-    EXT_ENABLE = "Mono12"
-    EXT_TRIGGER = "Ext. Trigger"
-    MULT_TRIGGER = "Mult. Trigger"
-    ALIGNMENT = "Alignment"
-
-
 class VimbaConvertFormat(StrictEnum):
+    """Convert pixel format for the Vimba detector."""
+
     NONE = "None"
     MONO8 = "Mono8"
     MONO16 = "Mono16"
@@ -34,6 +28,8 @@ class VimbaTriggerSource(StrictEnum):
 
 
 class VimbaOverlap(StrictEnum):
+    """Overlap modes for the Vimba detector."""
+
     OFF = "Off"
     PREV_FRAME = "PreviousFrame"
 
@@ -46,7 +42,7 @@ class VimbaOnOff(StrictEnum):
 
 
 class VimbaExposeOutMode(StrictEnum):
-    """Modes for exposure on the Vimba detector."""
+    """Exposure control modes for Vimba detectors."""
 
     TIMED = "Timed"  # Use ExposureTime PV
     TRIGGER_WIDTH = "TriggerWidth"  # Expose for length of high signal