Skip to content

Comments

Update to released scanspec#1069

Open
coretl wants to merge 2 commits intomainfrom
coretl-patch-2
Open

Update to released scanspec#1069
coretl wants to merge 2 commits intomainfrom
coretl-patch-2

Conversation

@coretl
Copy link
Collaborator

@coretl coretl commented Oct 3, 2025

No description provided.

@coretl coretl requested a review from gkalua October 3, 2025 13:49
@coretl
Copy link
Collaborator Author

coretl commented Dec 12, 2025

@claude

@claude
Copy link

claude bot commented Dec 12, 2025

Claude finished @coretl's task in 1m 12s —— View job


Review Complete

  • Read changed files and understand the update
  • Analyze the scanspec version change
  • Check for potential issues or concerns
  • Provide review feedback

Summary

This PR updates scanspec from >=0.8 to >=0.9.0 and removes the alpha version pin (scanspec>=1.0a1) from dev dependencies. This follows the pattern established in PR #1047 where scanspec was pinned to stable releases for downstream stability.

Changes:

  • Runtime dependency: scanspec>=0.8scanspec>=0.9.0
  • Removed dev dependency: scanspec>=1.0a1 (no longer needed as 0.9.0 is released)

Analysis:
✅ Clean dependency update to released version
✅ Consistent with project's stability strategy (PR #1047)
✅ Scanspec is used in PMAC trajectory and PandA trigger modules
✅ No breaking API changes expected for minor version bump

Recommendation: LGTM - straightforward dependency update to stable release.


@coretl
Copy link
Collaborator Author

coretl commented Dec 12, 2025

@claude update uv lock file

@claude
Copy link

claude bot commented Dec 12, 2025

Claude finished @coretl's task in 2m 13s —— View job


Unable to Update uv Lock File

  • Read repository guidelines
  • Check current dependency configuration
  • Attempted to update uv lock file
  • Identified permissions limitation

Summary

I'm unable to update the uv lock file due to environment restrictions. The Claude workflow (.github/workflows/claude.yml:52) is configured with very limited tool permissions, allowing only:

  • GitHub PR comment commands (gh pr comment, gh pr diff, gh pr view)
  • Inline comment creation
  • Git commands (status, diff, log, add, commit, push, rm)

The workflow does not permit:

  • Installing packages (pip install, curl, etc.)
  • Running uv command
  • Executing arbitrary shell commands

To update the lock file, please:

Run this command locally:

uv lock

Then commit and push the updated uv.lock file:

git add uv.lock
git commit -m "Update uv.lock for scanspec>=0.9.0"
git push

Alternative: If you'd like Claude to handle lock file updates in the future, you can modify .github/workflows/claude.yml to:

  1. Add uv installation step: - uses: astral-sh/setup-uv@v7
  2. Update --allowedTools to include Bash(uv:*)

However, for this PR, the manual approach above is the quickest solution.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant