Add fan_dev_shm_enable signal to Odin#1127
Conversation
beb6e65 to
3a2a85a
Compare
|
Hi, @GDYendell is this signal in the IOC? |
|
Yep that looks right. For I03 it is |
|
Great, thanks |
|
The B21 SAXS detector does not have this PV(though curiously the WAXS one does): @GDYendell, I know this PV was always meant to be temporary but I don't think we're in a position where we can remove it soon? Can we add it to the B21 SAXS detector instead? FYI @RJCD-Diamond |
This is related to: #1117 annoyingly the detector on b21 that doesn't have the nexpi PV and the DevShmCache is the newer detector |
|
The PV isn't temporary. What might change is that we don't rely on toggling it off and on to clear the memory when the consuming process deletes the images as soon as they have been processed. Although it would probably still needed in some cases like scan failure where there might be some images left behind. |
|
@jsouter Are you able to add DevShmCache and nexpi to the b21 eiger's? |
The PVs are dynamically created by fastcs-eiger directly from the API as reported by the eiger. One of the Eigers on B21 (I think SAXS?) does not provide EDIT: nexpi is missing from the SAXS detector (Eiger 1 Si 4M) |
|
@DominicOram @jacob720 I thought we were going to delete ADOdin from ophyd-async and switch testing FastCS Odin instead? That would mean this change would be deleted shortly... |
We're actively testing the FastCS Eiger + ADOdin in the meantime with this patched on to make sure Hyperion works with FastCS Eiger / StandardDetector generally. Once #1158 is merged then happy to drop this |
Needed for DiamondLightSource/mx-bluesky#1076
We are currently migrating to the ophyd-async Eiger, and trying to use this in Hyperion. We need to be able to turn on dev/shm streaming for GPU analysis during xray centring, and turn it off to clear the memory, this PR adds the relevant PV to the Odin device.