Pass detector name + datakey suffix to providers instead of writer name to match filenames to datakeys.#1205
Merged
jwlodek merged 8 commits intobluesky:mainfrom Feb 23, 2026
Conversation
… prepare and hints for better control of what's passed to providers
Member
Author
|
Resolves #1204 . I think using |
…consistent within class
jwlodek
changed the title
coretl
requested changes
Feb 20, 2026
Collaborator
coretl
left a comment
coretl
left a comment
There was a problem hiding this comment.
Thanks, this is much cleaner, just some comments on naming so it is clear that the DetectorDataLogic is getting its datakey_name passed into the prepare_ methods rather than having to calculate it from detector_name
Co-authored-by: Tom C (DLS) <101418278+coretl@users.noreply.github.com>
Co-authored-by: Tom C (DLS) <101418278+coretl@users.noreply.github.com>
Co-authored-by: Tom C (DLS) <101418278+coretl@users.noreply.github.com>
coretl
reviewed
Feb 20, 2026
Co-authored-by: Tom C (DLS) <101418278+coretl@users.noreply.github.com>
Member
Author
|
Should we also rename the argument for path providers? Since we pass datakey names to then now, not a device name. |
Collaborator
Yes please |
coretl
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.