Tail Emission Calculation is Incorrect and will not trigger until 0.2 BLUR per block is reached

[hooftly]

As You can see here

blur/src/cryptonote_config.h

Line 62 in a733e52

#define FINAL_SUBSIDY_PER_MINUTE ((uint64_t)200000000000) /* 3 * pow(10, 11) */

You have #define FINAL_SUBSIDY_PER_MINUTE ((uint64_t)200000000000) set Which was changed with commit f411ef3

BLUR uses 12 Decimal points. According to the website https://blur.cash and your emission chart here https://docs.google.com/spreadsheets/d/12PcagebZLTjgf-aTmpKZX5Ck-p3QHOa834CKVyKy1m4 Blur is supposed to begin Tail Emission at 2 Coins per block.

The correct parameter should be #define FINAL_SUBSIDY_PER_MINUTE ((uint64_t)2000000000000) (add a zero) to allow for 2 coins per block.

It appears that you believe XMR will have a tail emission of 3 coins per block (Shown here https://discordapp.com/channels/453123992233181195/453123992736366594/508915394140962826 ) but in reality, it will be 0.6 XMR. Tail Emission is Calculated per minute and its set at 0.3 XMR per minute. XMR's block time is 2 minutes to block rewards will be 0.6 XMR per block because blocktime is 2 Minutes. BLURS block time is 1 Minute so the Tail Emission Calculation is cut in Half.

See here for info on Moneros Tail Emission https://web.getmonero.org/resources/moneropedia/tail-emission.html

Further Monero is already below a 3 coin block reward. It surprises me you haven't noticed this considering the issues you have raised over there.

Anyways your Tail Emission is wrong. 0.2 BLUR per block not 2

[who-biz]

It does appear that there are only 11 zeroes there. Good catch.

As I said on Discord, our plan is to have emission be static at 2.0 BLUR/block once we hit 2.0 in rewards... Current code does not reflect that however. But we are a ways off from that point currently. I also do not think that our current emission scheme accounts for the first block's reward being 360,000 BLUR. So there are some known issues around the emission, including this line in blockchain.cpp

blur/src/cryptonote_core/blockchain.cpp

Line 3418 in ec4856a

already_generated_coins = base_reward < (MONEY_SUPPLY-already_generated_coins) ? already_generated_coins + base_reward : MONEY_SUPPLY;

I know that we spoke about this, and that you disagree that line will be a problem. I'm just trying to elaborate that there are other issues that will need resolved as well.

Thanks for the detailed issue report, it is helpful. I'll leave this open until the emission stuff is properly addressed.

[who-biz]

@hooftly Please note that the issue you mentioned has been resolved in this commit: 44f099d.

Changes to blockchain.cpp (and other areas this may affect) still need made. Will leave this open until those are addressed and merged into master.

[who-biz]

This issue still needs resolved, relatively soon.

As I said on Discord, our plan is to have emission be static at 2.0 BLUR/block once we hit 2.0 in rewards... Current code does not reflect that however. But we are a ways off from that point currently.

Regarding emission, the words above are no longer accurate. Decision was made not to inflate supply at 2.0 BLUR/block. Static rewards will be necessary to incentivize mining once we hit tail emission. Presently network transaction frequency is far too low for fee-based rewards to be viable