-
Notifications
You must be signed in to change notification settings - Fork 1
Newtrack #11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Newtrack #11
Conversation
@JosephPeterDevlin could you take a look at my modifcations? |
@mattsignorelli There is a problem with them, this line with the Toy AGS as
|
Ok I kinda fixed it but it is super slow. Was it this slow in your original implementation? |
1 particle for 1000 turns should not take several seconds |
I guarantee most of the tracking time is spent writing to the tensor and poor performance practices in the track loop (which i too am guilty of). I wonder if we can try to quickly eek-out a memcopy kernel and just skip this 3-vector every single turn thing instead just tracking the quaternion always |
No, it wasn't that slow before. 1 particle for 10,000 turns was 6 seconds before. |
I just tried it with storing 3-vectors and 1 particle for 1,000 turns only took 0.76 seconds. This is about the same speed as before. I don't understand the advantage of tracking the quaternion always if I'm going to want to turn every single turn into a spin vector in the end anyway. |
No description provided.