Skip to content

Commit 777fab6

Browse files
authored
Correlations: Filter by org id when returning correlation count in get response (grafana#124819)
Filter by org id when returning correlation count in get response
1 parent 54967c6 commit 777fab6

3 files changed

Lines changed: 8 additions & 3 deletions

File tree

pkg/services/correlations/correlations.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ func (s CorrelationsService) handleDatasourceDeletion(ctx context.Context, event
130130
}
131131

132132
func (s *CorrelationsService) Usage(ctx context.Context, scopeParams *quota.ScopeParameters) (*quota.Map, error) {
133-
return s.CountCorrelations(ctx)
133+
return s.CountCorrelations(ctx, nil)
134134
}
135135

136136
func readQuotaConfig(cfg *setting.Cfg) (*quota.Map, error) {

pkg/services/correlations/database.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -282,12 +282,15 @@ func (s CorrelationsService) getCorrelation(ctx context.Context, cmd GetCorrelat
282282
return correlation, nil
283283
}
284284

285-
func (s CorrelationsService) CountCorrelations(ctx context.Context) (*quota.Map, error) {
285+
func (s CorrelationsService) CountCorrelations(ctx context.Context, orgId *int64) (*quota.Map, error) {
286286
u := &quota.Map{}
287287
var err error
288288
count := int64(0)
289289
err = s.SQLStore.WithDbSession(ctx, func(sess *db.Session) error {
290290
q := sess.Table("correlation")
291+
if orgId != nil {
292+
q.Where("org_id = ?", orgId)
293+
}
291294
count, err = q.Count()
292295

293296
if err != nil {
@@ -354,7 +357,7 @@ func (s CorrelationsService) getCorrelations(ctx context.Context, cmd GetCorrela
354357
return GetCorrelationsResponseBody{}, err
355358
}
356359

357-
count, err := s.CountCorrelations(ctx)
360+
count, err := s.CountCorrelations(ctx, &cmd.OrgId)
358361
if err != nil {
359362
return GetCorrelationsResponseBody{}, err
360363
}

pkg/tests/api/correlations/correlations_read_test.go

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -172,6 +172,7 @@ func TestIntegrationReadCorrelation(t *testing.T) {
172172

173173
require.Len(t, response.Correlations, 1)
174174
require.EqualValues(t, correlation, response.Correlations[0])
175+
require.EqualValues(t, response.TotalCount, 1)
175176

176177
require.NoError(t, res.Body.Close())
177178
})
@@ -191,6 +192,7 @@ func TestIntegrationReadCorrelation(t *testing.T) {
191192
require.NoError(t, err)
192193

193194
require.Len(t, response.Correlations, 0)
195+
require.EqualValues(t, response.TotalCount, 0)
194196

195197
require.NoError(t, res.Body.Close())
196198
})

0 commit comments

Comments
 (0)