Skip to content

Commit 8960aae

Browse files
committed
Fix test
1 parent f2dff76 commit 8960aae

1 file changed

Lines changed: 15 additions & 21 deletions

File tree

src/functTest/groovy/com/bmuschko/gradle/docker/tasks/image/DockerBuildImageFunctionalTest.groovy

Lines changed: 15 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ ARG user
5353
USER \$user"""
5454
buildFile << """
5555
import com.bmuschko.gradle.docker.tasks.image.DockerBuildImage
56-
import com.bmuschko.gradle.docker.tasks.image.DockerExistingImage
56+
import com.bmuschko.gradle.docker.tasks.image.DockerInspectImage
5757
import com.bmuschko.gradle.docker.tasks.image.DockerRemoveImage
5858
5959
task buildImage(type: DockerBuildImage) {
@@ -63,31 +63,21 @@ USER \$user"""
6363
images.add("${createUniqueImageId()}")
6464
}
6565
66-
task inspectImage(type: DockerInspectImageUser) {
66+
task inspectImage(type: DockerInspectImage) {
6767
dependsOn buildImage
68-
imageId = buildImage.imageId
68+
targetImageId buildImage.imageId
69+
onNext { image ->
70+
def user = image.config?.user ?: (image.containerConfig?.user ?: 'not set')
71+
println "user: \$user"
72+
}
6973
}
7074
7175
task removeImage(type: DockerRemoveImage) {
7276
force = true
73-
imageId = buildImage.imageId
77+
targetImageId buildImage.imageId
7478
}
7579
7680
inspectImage.finalizedBy tasks.removeImage
77-
78-
class DockerInspectImageUser extends DockerExistingImage {
79-
DockerInspectImageUser() {
80-
onNext({ image ->
81-
println "user: \$image.containerConfig.user"
82-
})
83-
}
84-
85-
@Override
86-
void runRemoteCommand() {
87-
def image = dockerClient.inspectImageCmd(imageId.get()).exec()
88-
nextHandler.execute(image)
89-
}
90-
}
9181
"""
9282

9383
when:
@@ -467,17 +457,21 @@ USER \$user"""
467457
468458
task verifyTagsMissing(type: DockerOperation) {
469459
dependsOn deleteOriginalTag
460+
def imageIdValue = buildImageWithTag.imageId
461+
def imagesValue = buildImageWithTag.images
470462
onNext {
471-
if (inspectImageCmd(buildImageWithTag.imageId.get()).exec().repoTags.containsAll(buildImageWithTag.images.get())) {
463+
if (inspectImageCmd(imageIdValue.get()).exec().repoTags.containsAll(imagesValue.get())) {
472464
throw new GradleException("There should be configured tags missing now")
473465
}
474466
}
475467
}
476468
477469
task verifyTagsPresent(type: DockerOperation) {
478470
dependsOn buildImageWithTag
471+
def imageIdValue = buildImageWithTag.imageId
472+
def imagesValue = buildImageWithTag.images
479473
onNext {
480-
if (!inspectImageCmd(buildImageWithTag.imageId.get()).exec().repoTags.containsAll(buildImageWithTag.images.get())) {
474+
if (!inspectImageCmd(imageIdValue.get()).exec().repoTags.containsAll(imagesValue.get())) {
481475
throw new GradleException("All configured tags should be present now")
482476
}
483477
}
@@ -648,7 +642,7 @@ USER \$user"""
648642
649643
task buildImageWithTags(type: DockerBuildImage) {
650644
dependsOn dockerfile
651-
images = ['test/image:123', "registry.com:5000/test/image:\$project.version"]
645+
images = ['test/image:123', "registry.com:5000/test/image:\${project.version}".toString()]
652646
}
653647
654648
task buildImageWithTag(type: DockerBuildImage) {

0 commit comments

Comments
 (0)