eth/filters: rangeLogs should error on invalid block range (#33763) (#3688)

* eth/filters: rangeLogs should error on invalid block range (#33763)

Fixes log filter to reject out of order block ranges.

* eth/filters: fix testFilters

---------

Co-authored-by: vickkkkkyy <vickyaviles847@gmail.com>

Author: allformless

eth/filters/filter.go

@@ -389,7 +389,7 @@ func (f *Filter) rangeLogs(ctx context.Context, firstBlock, lastBlock uint64) ([
 	}
 
 	if firstBlock > lastBlock {
-		return nil, nil
+		return nil, errInvalidBlockRange
 	}
 	mb := f.sys.backend.NewMatcherBackend()
 	defer mb.Close()

eth/filters/filter_test.go

@@ -360,7 +360,8 @@ func testFilters(t *testing.T, history uint64, noHistory bool) {
 				want: `[{"address":"0xff00000000000000000000000000000000000000","topics":["0x0000000000000000000000000000000000000000000000000000746f70696333"],"data":"0x","blockNumber":"0x3e7","transactionHash":"0x53e3675800c6908424b61b35a44e51ca4c73ca603e58a65b32c67968b4f42200","transactionIndex":"0x0","blockHash":"0x2e4620a2b426b0612ec6cad9603f466723edaed87f98c9137405dd4f7a2409ff","logIndex":"0x0","removed":false}]`,
 			},
 			{
-				f: sys.NewRangeFilter(int64(rpc.LatestBlockNumber), int64(rpc.FinalizedBlockNumber), nil, nil),
+				f:   sys.NewRangeFilter(int64(rpc.LatestBlockNumber), int64(rpc.FinalizedBlockNumber), nil, nil, false),
+				err: errInvalidBlockRange.Error(),
 			},
 			{
 				f:   sys.NewRangeFilter(int64(rpc.SafeBlockNumber), int64(rpc.LatestBlockNumber), nil, nil),