fix: add nil check for ObjectInfo in P2P approval handlers to prevent panic

Author: andyzhang2023

base/types/gfsptask/approval.go

@@ -477,6 +477,9 @@ func (m *GfSpReplicatePieceApprovalTask) GetSignBytes() []byte {
 }
 
 func (m *GfSpReplicatePieceApprovalTask) Key() coretask.TKey {
+	if m.GetObjectInfo() == nil || m.GetObjectInfo().Id.IsNil() {
+		return GfSpReplicatePieceApprovalTaskKey("", "", "")
+	}
 	return GfSpReplicatePieceApprovalTaskKey(
 		m.GetObjectInfo().GetBucketName(),
 		m.GetObjectInfo().GetObjectName(),

modular/p2p/p2pnode/approval.go

@@ -111,6 +111,11 @@ func (a *ApprovalProtocol) onGetApprovalRequest(s network.Stream) {
 		log.Errorw("failed to unmarshal replicate piece approval request msg", "error", err)
 		return
 	}
+	if req.GetObjectInfo() == nil || req.GetObjectInfo().Id.IsNil() {
+		log.Warnw("ignore invalid replicate piece approval request: missing object info",
+			"remote", s.Conn().RemotePeer())
+		return
+	}
 	ctx := log.WithValue(context.Background(), log.CtxKeyTask, req.Key().String())
 	log.Debugf("%s received replicate piece approval request from %s, object_id: %d",
 		s.Conn().LocalPeer(), s.Conn().RemotePeer(), req.GetObjectInfo().Id.Uint64())
@@ -171,6 +176,11 @@ func (a *ApprovalProtocol) onGetApprovalResponse(s network.Stream) {
 		log.Errorw("failed to unmarshal replicate piece approval response msg", "error", err)
 		return
 	}
+	if resp.GetObjectInfo() == nil || resp.GetObjectInfo().Id.IsNil() {
+		log.Warnw("ignore invalid replicate piece approval response: missing object info",
+			"remote", s.Conn().RemotePeer())
+		return
+	}
 	ctx := log.WithValue(context.Background(), log.CtxKeyTask, resp.Key().String())
 	log.Debugf("%s received approval response from %s, object_id: %d",
 		s.Conn().LocalPeer(), s.Conn().RemotePeer(), resp.GetObjectInfo().Id.Uint64())