fix(builtins/typed_array,iterable,generator,error,bigint,eval): convert panics to EngineError::Panic using js_expect

Part of #3241. It changes the following:
core/engine/src/builtins/typed_array/builtin.rs: converted 30 panics
core/engine/src/builtins/typed_array/object.rs: converted 3 panics
core/engine/src/builtins/iterable/async_from_sync_iterator.rs: converted 8 panics
core/engine/src/builtins/generator/mod.rs: converted 3 panics
core/engine/src/builtins/error/aggregate.rs: converted 1 panic
core/engine/src/builtins/bigint/mod.rs: converted 1 panic
core/engine/src/builtins/eval/mod.rs: converted 1 panic

Author: KaustubhOG

core/engine/src/builtins/bigint/mod.rs

@@ -13,7 +13,7 @@
 //! [mdn]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/BigInt
 
 use crate::{
-    Context, JsArgs, JsBigInt, JsResult, JsString, JsValue,
+    Context, JsArgs, JsBigInt, JsExpect, JsResult, JsString, JsValue,
     builtins::BuiltInObject,
     context::intrinsics::{Intrinsics, StandardConstructor, StandardConstructors},
     error::JsNativeError,
@@ -122,7 +122,12 @@ impl BigInt {
         }
 
         // 2. Return the BigInt value that represents ℝ(number).
-        Ok(JsBigInt::from(number.to_bigint().expect("This conversion must be safe")).into())
+        Ok(JsBigInt::from(
+            number
+                .to_bigint()
+                .js_expect("This conversion must be safe")?,
+        )
+        .into())
     }
 
     /// The abstract operation `thisBigIntValue` takes argument value.

core/engine/src/builtins/error/aggregate.rs

@@ -8,7 +8,7 @@
 //! [mdn]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/AggregateError
 
 use crate::{
-    Context, JsArgs, JsResult, JsString, JsValue,
+    Context, JsArgs, JsExpect, JsResult, JsString, JsValue,
     builtins::{
         Array, BuiltInBuilder, BuiltInConstructor, BuiltInObject, IntrinsicObject,
         iterable::IteratorHint,
@@ -128,7 +128,7 @@ impl BuiltInConstructor for AggregateError {
                 .build(),
             context,
         )
-        .expect("should not fail according to spec");
+        .js_expect("should not fail according to spec")?;
 
         // 5. Return O.
         Ok(o.into())

core/engine/src/builtins/eval/mod.rs

@@ -10,7 +10,7 @@
 //! [mdn]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/eval
 
 use crate::{
-    Context, JsArgs, JsResult, JsString, JsValue, SpannedSourceText,
+    Context, JsArgs, JsExpect, JsResult, JsString, JsValue, SpannedSourceText,
     builtins::{BuiltInObject, function::OrdinaryFunction},
     bytecompiler::{ByteCompiler, prepare_eval_declaration_instantiation},
     context::intrinsics::Intrinsics,
@@ -152,7 +152,7 @@ impl Eval {
                     .slots()
                     .function_object()
                     .downcast_ref::<OrdinaryFunction>()
-                    .expect("must be function object");
+                    .js_expect("must be function object")?;
 
                 // ii. Set inFunction to true.
                 let mut flags = Flags::IN_FUNCTION;

core/engine/src/builtins/generator/mod.rs

@@ -10,10 +10,11 @@
 //! [mdn]: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Generator
 
 use crate::{
-    Context, JsArgs, JsData, JsError, JsResult, JsString,
+    Context, JsArgs, JsData, JsError, JsExpect, JsResult, JsString,
     builtins::iterable::create_iter_result_object,
     context::intrinsics::Intrinsics,
     error::JsNativeError,
+    error::PanicError,
     js_string,
     object::{CONSTRUCTOR, JsObject},
     property::Attribute,
@@ -101,7 +102,9 @@ impl GeneratorContext {
         context: &mut Context,
     ) -> CompletionRecord {
         std::mem::swap(&mut context.vm.stack, &mut self.stack);
-        let frame = self.call_frame.take().expect("should have a call frame");
+        let Some(frame) = self.call_frame.take() else {
+            return CompletionRecord::Throw(PanicError::new("should have a call frame").into());
+        };
         let fp = frame.fp;
         let rp = frame.rp;
         context.vm.push_frame(frame);
@@ -125,16 +128,21 @@ impl GeneratorContext {
     }
 
     /// Returns the async generator object, if the function that this [`GeneratorContext`] is from an async generator, [`None`] otherwise.
-    pub(crate) fn async_generator_object(&self) -> Option<JsObject> {
-        let frame = self.call_frame.as_ref()?;
+    pub(crate) fn async_generator_object(&self) -> JsResult<Option<JsObject>> {
+        let Some(frame) = self.call_frame.as_ref() else {
+            return Ok(None);
+        };
+
         if !frame.code_block().is_async_generator() {
-            return None;
+            return Ok(None);
         }
 
-        self.stack
+        let val = self
+            .stack
             .get_register(frame, CallFrame::ASYNC_GENERATOR_OBJECT_REGISTER_INDEX)
-            .expect("registers must have an async generator object")
-            .as_object()
+            .js_expect("registers must have an async generator object")?;
+
+        Ok(val.as_object())
     }
 }
 
@@ -306,7 +314,7 @@ impl Generator {
 
         let mut r#gen = generator_obj
             .downcast_mut::<Self>()
-            .expect("already checked this object type");
+            .js_expect("already checked this object type")?;
 
         // 8. Push genContext onto the execution context stack; genContext is now the running execution context.
         // 9. Resume the suspended evaluation of genContext using NormalCompletion(value) as the result of the operation that suspended it. Let result be the value returned by the resumed computation.

core/engine/src/builtins/iterable/async_from_sync_iterator.rs

@@ -1,5 +1,5 @@
 use crate::{
-    Context, JsArgs, JsData, JsError, JsNativeError, JsResult, JsValue,
+    Context, JsArgs, JsData, JsError, JsExpect, JsNativeError, JsResult, JsValue,
     builtins::{
         BuiltInBuilder, IntrinsicObject, Promise,
         iterable::{IteratorRecord, IteratorResult, create_iter_result_object},
@@ -99,7 +99,7 @@ impl AsyncFromSyncIterator {
         let mut sync_iterator_record = object
             .as_ref()
             .and_then(JsObject::downcast_ref::<Self>)
-            .expect("async from sync iterator prototype must be object")
+            .js_expect("async from sync iterator prototype must be object")?
             .sync_iterator_record
             .clone();
 
@@ -108,7 +108,7 @@ impl AsyncFromSyncIterator {
             &context.intrinsics().constructors().promise().constructor(),
             context,
         )
-        .expect("cannot fail with promise constructor");
+        .js_expect("cannot fail with promise constructor")?;
 
         // 5. If value is present, then
         //     a. Let result be Completion(IteratorNext(syncIteratorRecord, value)).
@@ -143,7 +143,7 @@ impl AsyncFromSyncIterator {
         let sync_iterator_record = object
             .as_ref()
             .and_then(JsObject::downcast_ref::<Self>)
-            .expect("async from sync iterator prototype must be object")
+            .js_expect("async from sync iterator prototype must be object")?
             .sync_iterator_record
             .clone();
         // 5. Let syncIterator be syncIteratorRecord.[[Iterator]].
@@ -154,7 +154,7 @@ impl AsyncFromSyncIterator {
             &context.intrinsics().constructors().promise().constructor(),
             context,
         )
-        .expect("cannot fail with promise constructor");
+        .js_expect("cannot fail with promise constructor")?;
 
         // 6. Let return be Completion(GetMethod(syncIterator, "return")).
         let r#return = sync_iterator.get_method(js_string!("return"), context);
@@ -173,7 +173,7 @@ impl AsyncFromSyncIterator {
                 promise_capability
                     .resolve()
                     .call(&JsValue::undefined(), &[iter_result], context)
-                    .expect("cannot fail according to spec");
+                    .js_expect("cannot fail according to spec")?;
 
                 // c. Return promiseCapability.[[Promise]].
                 return Ok(promise_capability.promise().clone().into());
@@ -225,7 +225,7 @@ impl AsyncFromSyncIterator {
         let sync_iterator_record = object
             .as_ref()
             .and_then(JsObject::downcast_ref::<Self>)
-            .expect("async from sync iterator prototype must be object")
+            .js_expect("async from sync iterator prototype must be object")?
             .sync_iterator_record
             .clone();
         // 5. Let syncIterator be syncIteratorRecord.[[Iterator]].
@@ -236,7 +236,7 @@ impl AsyncFromSyncIterator {
             &context.intrinsics().constructors().promise().constructor(),
             context,
         )
-        .expect("cannot fail with promise constructor");
+        .js_expect("cannot fail with promise constructor")?;
 
         // 6. Let throw be Completion(GetMethod(syncIterator, "throw")).
         let throw = sync_iterator.get_method(js_string!("throw"), context);
@@ -267,7 +267,7 @@ impl AsyncFromSyncIterator {
                             .into()],
                         context,
                     )
-                    .expect("cannot fail according to spec");
+                    .js_expect("cannot fail according to spec")?;
 
                 // h. Return promiseCapability.[[Promise]].
                 return Ok(promise_capability.promise().clone().into());